From: Doug Evans <dje@google.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patchv4 4/5] Keep objfile original filename
Date: Thu, 19 Sep 2013 23:37:00 -0000 [thread overview]
Message-ID: <21051.35494.124735.388497@ruffy.mtv.corp.google.com> (raw)
In-Reply-To: <20130919135631.GD16978@host2.jankratochvil.net>
Jan Kratochvil writes:
> gdb/
> 2013-09-15 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Pass down original filename for objfile.
> * coffread.c (coff_symfile_read): Update symbol_file_add_separate call.
> * elfread.c (elf_symfile_read): Likewise.
> * jit.c (jit_object_close_impl): Update allocate_objfile call, no
> longer set ORIGINAL_NAME.
> (jit_bfd_try_read_symtab): Update symbol_file_add_from_bfd call.
> * jv-lang.c (get_dynamics_objfile): Update allocate_objfile call.
> * machoread.c (macho_add_oso_symfile): Add parameter name. Update
> symbol_file_add_from_bfd call.
> (macho_symfile_read_all_oso): Update two macho_add_oso_symfile calls.
> (macho_check_dsym): Add parameter filenamep. Change function comment.
> Set *filenamep.
> (macho_symfile_read): New variable dsym_filename. Update
> macho_check_dsym call. Use it for symbol_file_add_separate.
> * objfiles.c (allocate_objfile): Add parameter name. New comment for
> it. Use it for objfile->original_name.
> (objfile_name): Return OBFD's filename, if available.
> * objfiles.h (allocate_objfile): Add new parameter name.
> * solib-sunos.c (allocate_rt_common_objfile): Remove variable name.
> Update allocate_objfile call. Remove obstack_copy0 call.
> * solib.c (solib_read_symbols): Update symbol_file_add_from_bfd call.
> * symfile-mem.c (symbol_file_add_from_memory): Update
> symbol_file_add_from_bfd call.
> * symfile.c (read_symbols): Update symbol_file_add_separate call, new
> comment for it.
> (symbol_file_add_with_addrs): New parameter name, add function comment
> for it. Remove variable name. Update allocate_objfile call.
> (symbol_file_add_separate): New parameter name, add function comment
> for it. Update symbol_file_add_with_addrs call.
> (symbol_file_add_from_bfd): New parameter name. Update
> symbol_file_add_with_addrs call.
> (symbol_file_add): Update symbol_file_add_from_bfd call.
> (reread_symbols): New variable original_name. Save
> objfile->original_name by it.
> * symfile.h (symbol_file_add_from_bfd, symbol_file_add_separate): Add
> second parameter.
LGTM
next prev parent reply other threads:[~2013-09-19 23:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 14:20 Jan Kratochvil
2013-09-19 23:37 ` Doug Evans [this message]
2013-09-24 14:01 ` [commit] " Jan Kratochvil
2014-01-07 13:37 ` Yao Qi
2014-01-07 18:47 ` Jan Kratochvil
2014-01-08 2:47 ` Yao Qi
2014-01-08 3:23 ` Tom Tromey
2014-01-08 6:26 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21051.35494.124735.388497@ruffy.mtv.corp.google.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox