From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5870 invoked by alias); 19 Sep 2013 17:47:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5854 invoked by uid 89); 19 Sep 2013 17:47:23 -0000 Received: from mail-qe0-f73.google.com (HELO mail-qe0-f73.google.com) (209.85.128.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 19 Sep 2013 17:47:23 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD,SPF_SOFTFAIL autolearn=ham version=3.3.2 X-HELO: mail-qe0-f73.google.com Received: by mail-qe0-f73.google.com with SMTP id 6so1039719qea.4 for ; Thu, 19 Sep 2013 10:47:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=hZ+P62bVf+NzxwtvJIqjm9GZPlTSxhFKvCng0DlOZuU=; b=fPiNgJbEpCgwcfpNMmbFr+bz7g/xzMMbmJGD3sgDFX4HTnOPlMmmZym9dIOA3I1Wcg MSdN9PRnIwBKPUBuEnrVaGWMlQuqyA1SMFepzrsBc0RTnAMmSsWHGE8o/aeond7IWKHD +Ex3q9G6suyO3L3c7Vu9oJ9jxL3c4+PEjXsE6pLdrwp7moVawrKsqItDjGmSIrP5qstW /WVMAWghoWfvA6UnXLFPSPV4DgN5SeYEE/fOu6a7eVVou90JqoLUpglH45ACTTb8QjZD 89KehF7t5b3va772GpP31fnTfBJEL679RCai2ZHlv6cC107Uk7DYnt8VqdqdW8eH5BjX jpLA== X-Gm-Message-State: ALoCoQkEJFwPnHleQ4mgdJttZ+oPiTVgO/JqvslkCTCOPKI+YzB2c80giXsLIL/kIMBcdczh8/njYsIvqHtcCEEp92m7s5+QOcr1fjiUEaOnaka5P5UEPqA1qEq5aHVlhlUXEP29wBge2M00Ex9E1cbsnBQCApWlCMQ2qH19btpVd0hk62OrqJpPuaTp38nNeUuUUWqFCPjGgcAToHejREoEsuKpcA7rMg== X-Received: by 10.236.51.9 with SMTP id a9mr1047932yhc.41.1379612840689; Thu, 19 Sep 2013 10:47:20 -0700 (PDT) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id k45si1061145yhn.4.1969.12.31.16.00.00 (version=TLSv1.1 cipher=AES128-SHA bits=128/128); Thu, 19 Sep 2013 10:47:20 -0700 (PDT) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id 2C0CF31C1C3; Thu, 19 Sep 2013 10:47:20 -0700 (PDT) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21051.14503.630825.429806@ruffy.mtv.corp.google.com> Date: Thu, 19 Sep 2013 17:47:00 -0000 To: Yao Qi Cc: Subject: Re: [RFC 1/3] New make target 'check-perf' and new dir gdb.perf In-Reply-To: <1377663394-4975-2-git-send-email-yao@codesourcery.com> References: <520B7F70.6070207@codesourcery.com> <1377663394-4975-1-git-send-email-yao@codesourcery.com> <1377663394-4975-2-git-send-email-yao@codesourcery.com> X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00694.txt.bz2 Yao Qi writes: > When we add performance tests, we think typical 'make check' should > not run performance tests. We add a new makefile target 'check-perf' > to run performance test only. > > We also add a new dir gdb.perf in testsuite for all performance tests. > However, current 'make check' logic will either run dejagnu in > directory testsuite or iterate all gdb.* directories which has *.exp > files. Both of them will run tests in gdb.perf, so we have to filter > gdb.perf out. In makefile target 'check-single', we pass a list of > gdb.* directories except gdb.perf. We also update $(TEST_DIRS) to > filter out gdb.perf too, so that tests in gdb.perf can't be run in > target check-parallel. An alternative is as Tom suggests, do something like "if [skip_perf_tests] ..." at the top of each perf.exp file. That has the flair consistency, but I'm not sure which I like better, though I do like consistency. Thoughts?