From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20498 invoked by alias); 16 Sep 2013 22:22:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20489 invoked by uid 89); 16 Sep 2013 22:22:17 -0000 Received: from mail-vc0-f202.google.com (HELO mail-vc0-f202.google.com) (209.85.220.202) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 16 Sep 2013 22:22:17 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD,SPF_SOFTFAIL autolearn=ham version=3.3.2 X-HELO: mail-vc0-f202.google.com Received: by mail-vc0-f202.google.com with SMTP id gd11so576737vcb.3 for ; Mon, 16 Sep 2013 15:22:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=eGi0PQkPnB34sDduHYk0+Roeq5co6tmmaTscoQioB+4=; b=fOBbvfmUHwLFTFPYr7NI3/oLiOasVmUpmSyB8HFrlObeHIhjr44r8tE1Xez6+peurS XK/t8pMQxsQUdkDuMzgL5UCowf2CwokVQ9HpUPxRoZvg9E0z0LmTAD5nMu7iyApCErY/ 7FBIF56eaO+RK0z9O1Eos0ddcpc2lIHc5IjiHR/9RY7KfGs6GiwD+POW+WU2TZu+3rnu UscetBHLfj5dPMkwwmHaO62vmvng+Nva4u3LaMUItTWOf8jnLrZDtDcuyLet4Xh2E2Qa Sk5/nYEXLkgK8ROLP2YlPGjFNIe29De41nau7TQjPGDMzXzNzywFhHiGb6RxTEx+RVvR otgw== X-Gm-Message-State: ALoCoQlLgukDag/wVFqR143+lrcH3GHDn+x6AETye9mc4VEMV3knubRdsNlzsx7Z/34gzYYSZd4kIPatpDP7okeixruGiY7LUK4MclnGPla3+9JvHalXV6LWI4dKyhjmcCHOag/RwVXg/MWkXc5Zr6NJsz3gYYNjKUh6iQwY1LcSaIqkwzIh/NBj9M4Vt9KsnT3s8hSWhYAlD6+tKK8D2M+rB7EKGXCn+Q== X-Received: by 10.236.176.1 with SMTP id a1mr10976264yhm.10.1379370134104; Mon, 16 Sep 2013 15:22:14 -0700 (PDT) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id a49si2377161yhc.5.1969.12.31.16.00.00 (version=TLSv1.1 cipher=AES128-SHA bits=128/128); Mon, 16 Sep 2013 15:22:14 -0700 (PDT) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id 9037E31C239; Mon, 16 Sep 2013 15:22:13 -0700 (PDT) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21047.33940.998451.19883@ruffy.mtv.corp.google.com> Date: Mon, 16 Sep 2013 22:22:00 -0000 To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patchv3 1/5] Mostly code cleanup: Constification In-Reply-To: <20130915193742.GA20411@host2.jankratochvil.net> References: <20130915193742.GA20411@host2.jankratochvil.net> X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00472.txt.bz2 Jan Kratochvil writes: > Hi, > > this is mostly a code cleanup, just the main.c part is not exactly the same. > > > Jan > > > gdb/ > 2013-09-15 Jan Kratochvil > > Constification. > * main.c (captured_main): Wrap symbol_file_add_main calls with > TRY_CATCH. Twice. > * symfile.c (symbol_file_add_main_1): Make args parameter const. > (symbol_file_add): Make name parameter const. > (symbol_file_add_main, symbol_file_add_main_1): Make args parameter const. > (symfile_bfd_open): Make name parameter const, rename it to cname. Add > variable name. Change their usage accordingly. > * symfile.h (symbol_file_add, symfile_bfd_open): Make first parameter > const. > (symbol_file_add_main): Make args parameter const. > > --- a/gdb/main.c > +++ b/gdb/main.c > @@ -950,8 +950,15 @@ captured_main (void *data) > catch_command_errors returns non-zero on success! */ > if (catch_command_errors (exec_file_attach, execarg, > !batch_flag, RETURN_MASK_ALL)) > - catch_command_errors (symbol_file_add_main, symarg, > - !batch_flag, RETURN_MASK_ALL); > + { > + volatile struct gdb_exception e; > + > + TRY_CATCH (e, RETURN_MASK_ALL) > + { > + symbol_file_add_main (symarg, !batch_flag); > + } > + exception_print (gdb_stderr, e); > + } > } > else > { > @@ -959,8 +966,15 @@ captured_main (void *data) > catch_command_errors (exec_file_attach, execarg, > !batch_flag, RETURN_MASK_ALL); > if (symarg != NULL) > - catch_command_errors (symbol_file_add_main, symarg, > - !batch_flag, RETURN_MASK_ALL); > + { > + volatile struct gdb_exception e; > + > + TRY_CATCH (e, RETURN_MASK_ALL) > + { > + symbol_file_add_main (symarg, !batch_flag); > + } > + exception_print (gdb_stderr, e); > + } > } > > if (corearg && pidarg) There is catch_command_errors_const. Would that work here?