Re: [RFA 02/15] Remove some unneeded psymtab initializations

Simon Marchi
2018-07-17T15:27:37Z

Hi Tom,

This LGTM, I just have one comment. I think it can be pushed on its own
too.

On 2018-05-10 18:23, Tom Tromey wrote:
> diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
> index 8960fdc38d..be477e3d30 100644
> --- a/gdb/dwarf2read.c
> +++ b/gdb/dwarf2read.c
> @@ -6517,13 +6517,7 @@ dwarf2_create_include_psymtab (const char
> *name, struct partial_symtab *pst,
> subpst->dependencies[0] = pst;
> subpst->number_of_dependencies = 1;
>
> - subpst->globals_offset = 0;
> - subpst->n_global_syms = 0;
> - subpst->statics_offset = 0;
> - subpst->n_static_syms = 0;
> - subpst->compunit_symtab = NULL;
> subpst->read_symtab = pst->read_symtab;
> - subpst->readin = 0;

Just above this, there is:

subpst->textlow = 0;
subpst->texthigh = 0;

Can they be removed too? Same thing in xcoffread.

Simon