From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43062 invoked by alias); 18 Jul 2018 14:04:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43037 invoked by uid 89); 18 Jul 2018 14:04:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:sk:NAM02-B X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Jul 2018 14:04:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1531922685; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=/jPuUTEb6ilYATIt8aZXPhnMtoBD9wJCy4+dN1MadeM=; b=HntHZqOSL3twazhPqxWlBpBTLspxat7OUln+aQ4qutGdBCTjw2ic6tnEp52TCMop /1B1F/eVEVU174FvV9ZLHtVh62617xQvy75lVSgH9ohnfro5VVbi4ZieAWKpsnPT z8CoiWjxSo3NrhVBEpjy8OeIIPLZYPvqalEVf/0QGCA=; Received: from ESESBMB504.ericsson.se (Unknown_Domain [153.88.183.117]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id 59.9A.22015.DF84F4B5; Wed, 18 Jul 2018 16:04:45 +0200 (CEST) Received: from ESESBMR503.ericsson.se (153.88.183.135) by ESESBMB504.ericsson.se (153.88.183.187) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 18 Jul 2018 16:04:44 +0200 Received: from ESESSMB502.ericsson.se (153.88.183.163) by ESESBMR503.ericsson.se (153.88.183.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 18 Jul 2018 16:04:44 +0200 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (153.88.183.157) by ESESSMB502.ericsson.se (153.88.183.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Wed, 18 Jul 2018 16:04:44 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iFR7vY68lff2sNtIfiDPaAN3YAd8uItkoAmqtbfHx0o=; b=lBH7m3dGow1OgwWLQy6G674sRZ2fFONbq0Hl164LxcLKgn+3ifkQ1ReXxU9RjvMkztHntJPqn00P48geBnbhlQRLCtksyk7cQ3HxAFH+OcMYadacKcf/OPcRq/jaHVxcPxipJvC4NqRptyPHubxq92puHp3wwEdmlwT49THuaSc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [10.0.0.110] (192.222.164.54) by BYAPR15MB2391.namprd15.prod.outlook.com (2603:10b6:a02:8c::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.952.20; Wed, 18 Jul 2018 14:04:41 +0000 Subject: Re: [RFA 10/15] Introduce objfile::reset_psymtabs To: Tom Tromey , References: <20180510222357.27332-1-tom@tromey.com> <20180510222357.27332-11-tom@tromey.com> From: Simon Marchi Message-ID: <20f76245-16ea-526c-46a6-95b831761f55@ericsson.com> Date: Wed, 18 Jul 2018 14:04:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180510222357.27332-11-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-Path: simon.marchi@ericsson.com Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg00544.txt.bz2 On 2018-05-10 06:23 PM, Tom Tromey wrote: > This introduces a new method, objfile::reset_psymtabs, and changes > reread_symbols to use it. This method simply destroys the existing > partial symbols and recreates the psymtab_storage object. > > This patch fixes a latent bug -- namely, that reread_symbols should > clear objfile::psymbol_map, but does not. I can submit that > separately if you'd prefer. LGTM. Simon