From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23509 invoked by alias); 9 Jan 2020 19:32:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23495 invoked by uid 89); 9 Jan 2020 19:32:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx2.freebsd.org Received: from mx2.freebsd.org (HELO mx2.freebsd.org) (96.47.72.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Jan 2020 19:31:59 +0000 Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 7999C6911A; Thu, 9 Jan 2020 19:31:55 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47tx7v1h8fz4bKP; Thu, 9 Jan 2020 19:31:55 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-7.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id E6B8817F23; Thu, 9 Jan 2020 19:31:54 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: [PATCH v2 00/24] Multi-target support To: Pedro Alves , gdb-patches@sourceware.org References: <20191017225026.30496-1-palves@redhat.com> From: John Baldwin Openpgp: preference=signencrypt Message-ID: <20a1459c-e705-99e9-9277-51cec32b28c5@FreeBSD.org> Date: Thu, 09 Jan 2020 19:32:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00218.txt.bz2 On 10/29/19 12:13 PM, Pedro Alves wrote: > On 10/18/19 9:22 PM, John Baldwin wrote: >> On 10/17/19 3:50 PM, Pedro Alves wrote: >>> Here's v2 of the multi-target patchset, which addresses all the review >>> comments so far, I believe. Patch 15 is new, so all following patches >>> are shifted by one. >>> >>> This time, I've adjusted the host-specific nat files to function API >>> changes. I tried to find spots that would need changes using grep. I >>> built the series on AIX, x86/SPARC Solaris, 64-bit Windows, x86 >>> GNU/Linux -m64/-m32, and Aarch64 GNU/Linux. I'm currently running >>> this through the buildbot, will have results tomorrow. I don't expect >>> any serious major issue, if any, as so far runs that completed seem >>> OK. >> >> I (finally) have a patch to fix the build on FreeBSD/amd64 (and probably >> FreeBSD on other platforms) here: >> >> https://github.com/bsdjhb/gdb/commit/e58a36eaef6244d2040ce6f377497ee898978db4 >> > > Thanks! > >> It's a combined patch but has some commentary on bsd-kvm.c which is >> kind of special. That target adds new commands that need to find a >> target to operate on. I opted to have it look at the current inferior >> and if (using a dynamic cast) it is a bsd-kvm target the commands >> modify the state of that inferior. I haven't tested it though as I don't >> use bsd-kvm.c. > > I'd rather not merge the bsd-kvm.c parts into my patches as is, for the > reason that it doesn't appear necessary for a minimal keep-working-as-before > change. I think it would be fine as a follow up patch, though. Ok, that's fine. > For bsd-kvm.c, I _think_ that the only change necessary to keep things > building would be this: > > --- a/gdb/bsd-kvm.c > +++ b/gdb/bsd-kvm.c > @@ -136,7 +136,7 @@ bsd_kvm_target_open (const char *arg, int from_tty) > core_kd = temp_kd; > push_target (&bsd_kvm_ops); > > - add_thread_silent (bsd_kvm_ptid); > + add_thread_silent (&bsd_kvm_ops, bsd_kvm_ptid); > inferior_ptid = bsd_kvm_ptid; > > Right? See updated patch below. Ok, this works for me. -- John Baldwin