From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id dW9fOiELbGj5Bi4AWB0awg (envelope-from ) for ; Mon, 07 Jul 2025 14:00:01 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=akkartik.com header.i=@akkartik.com header.a=rsa-sha256 header.s=fm3 header.b=D6Pny2HR; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm2 header.b=L+bKeZl8; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id CB75A1E089; Mon, 7 Jul 2025 14:00:01 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8E2A31E089 for ; Mon, 7 Jul 2025 14:00:00 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 20FF83857356 for ; Mon, 7 Jul 2025 18:00:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 20FF83857356 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=akkartik.com header.i=@akkartik.com header.a=rsa-sha256 header.s=fm3 header.b=D6Pny2HR; dkim=pass (2048-bit key, unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm2 header.b=L+bKeZl8 Received: from fout-b1-smtp.messagingengine.com (fout-b1-smtp.messagingengine.com [202.12.124.144]) by sourceware.org (Postfix) with ESMTPS id 9292B3858D32 for ; Mon, 7 Jul 2025 17:59:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9292B3858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=akkartik.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=akkartik.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9292B3858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=202.12.124.144 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1751911170; cv=none; b=nzu2qrQbpMTiNRZO//fFXxeNP6ruMDLOoBWeXAxH76RdcssxB90rhHFZ0IEBFd7EIFTOA9tk8tRd9Ig7yBSeMeGExM2tgEB0ajQmk856Zb4zzMxQS2BtR8FgbXqP5l6k2+QTiGU7UA2XCxdy4EZ5j/3uxlQI8K9YUgmbsiwPY/A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1751911170; c=relaxed/simple; bh=Q/3GDXEUsjsH+7McrPGGbEebUvJPwss3QygUO/4sYp8=; h=DKIM-Signature:DKIM-Signature:MIME-Version:Date:From:To: Message-Id:Subject; b=N1fDVemMLcOE/b7kFNeZbJ27OHqPJ2DqTfKa23dTqRlJzn8Z7jmNExi8r1NwoUaDST/uYKIh+DBA9rVhdHmM7pC2wlTR9Lt96lV1+fh87d31wd3ueRjP6c3PE8wygjpSK32gMkCslhZ4GhK46WKz02ifgt6An5AZ3uVJKuxQAYY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9292B3858D32 Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailfout.stl.internal (Postfix) with ESMTP id 306991D00129 for ; Mon, 7 Jul 2025 13:59:30 -0400 (EDT) Received: from phl-imap-08 ([10.202.2.84]) by phl-compute-11.internal (MEProxy); Mon, 07 Jul 2025 13:59:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkartik.com; h= cc:content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1751911170; x=1751997570; bh=Q/3GDXEUsjsH+7McrPGGbEebUvJPwss3QygUO/4sYp8=; b= D6Pny2HRz/NRG/qhoL4eRCLUCrbyk3bRXBjjt4smYA+wEM0FNnYAwzsy/H61Uxrv zD2FaL93Hga1HXn84U7I1F9/GR8a1sRW+whEDTHT5VBqJgT+7nsJv4WOIh5xtPBF xGctEqF2WCrGnJBmxEXewuttHMEKa2T4/0L2vmOmMBC7w2GA7rxYE6zS/fdbnRwL iuB05n2HRGBvRiXrSkbly/8kWHBU4Oev3/fubEJ0JyF4dH8Q5iUIKawSiIFyG+Xl dGd3+Kzdwr2CUGuK51i+I33M6YVZOGfTcaX5PRq9q1K5rzmsphBkufPh4qoc1lpo BhDmWEI2dgCts5gJSumRxw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1751911170; x=1751997570; bh=Q /3GDXEUsjsH+7McrPGGbEebUvJPwss3QygUO/4sYp8=; b=L+bKeZl8nvyEE8opA 6LhZjlUGU9W9L2ld4a7Qgw6VQOAC63KcHkeBRiSL9gJhEewuUF3X0/DoZbPwjwps vn3FL5SCb5J5fBvu4ZrY8kOVcPR1lK0aemW3fA2DrAtrKEV/KeGkAVAviCVfXPDF 0pc5PC484FfiLbGbxc4qMMRuqKaQPnh8d/lBQnFNkYDHJgoh71qYjtCY5WWNyBKV FEWbhfK6oytQvRF17d/9/jLuwkP46bkHyTYXn7UU8Tol7DONsoIIxJwNZomiUL+b 5xMdfGBVL4PT1VAmhNOw4wpKnsx53NHBR0oHyIODJ6wH9DkXjIivAWF1WMF45eKQ x4sMg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdefvdeghecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecunecujfgurhepofggfffhvffkjghfufgtgfesthejredtre dttdenucfhrhhomhepfdfmrghrthhikhcutehgrghrrghmfdcuoegrkhesrghkkhgrrhht ihhkrdgtohhmqeenucggtffrrghtthgvrhhnpeetheefteevleehheejveekjeejleeltd dvhedvteeikeeuheeikeejkedtueetleenucffohhmrghinhepshhouhhrtggvfigrrhgv rdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghksegrkhhkrghrthhikhdrtghomhdpnhgspghrtghpthhtohepuddpmhhouggvpehs mhhtphhouhhtpdhrtghpthhtohepghgusgdqphgrthgthhgvshesshhouhhrtggvfigrrh gvrdhorhhg X-ME-Proxy: Feedback-ID: id12946ff:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id CB1572CE0071; Mon, 7 Jul 2025 13:59:29 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 X-ThreadId: T05b9059f6652f8fe Date: Mon, 07 Jul 2025 10:59:09 -0700 From: "Kartik Agaram" To: gdb-patches@sourceware.org Message-Id: <209b0e96-b408-4cf4-9d50-40a51f6df8f5@app.fastmail.com> In-Reply-To: <20250606161014.1367913-2-ak@akkartik.com> References: <20250602233957.1130697-2-ak@akkartik.com> <20250606161014.1367913-2-ak@akkartik.com> Subject: Re: [PATCH v4] gdb: redo whitespace-stripping from commands Content-Type: text/plain Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi, just a friendly ping on this patch. Please let me know if there's anything more I can do for it. On Fri, Jun 6, 2025, at 09:10, Kartik K. Agaram wrote: > Before this patch, trailing whitespace was not stripped from 'set' and > 'complete' commands. Now I've added 'with' to that list of commands > because it may contain one of those commands. To accomplish this, I'm > fixing an ancient TODO to provide a per-command flag controlling > whitespace-stripping. > > Any subcommands of 'with' besides 'complete' or 'set' will continue to > strip whitespace as before, because they go through a recursive call to > execute_command. The outer call for 'with' won't strip whitespace, then > the recursive call will. > > I've also cleaned up 2 obsolete TODOs and NOTEs in related code. > > Tested on x86_64-linux. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29784 > Reviewed-By: Guinevere Larsen > --- > Changes for v4: > * Ugh, removed a stray quote character from the commit description.