From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15022 invoked by alias); 1 Aug 2013 23:50:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15002 invoked by uid 89); 1 Aug 2013 23:50:03 -0000 X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RDNS_NONE,SPF_PASS autolearn=ham version=3.3.1 Received: from Unknown (HELO mail-qa0-f73.google.com) (209.85.216.73) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 01 Aug 2013 23:50:03 +0000 Received: by mail-qa0-f73.google.com with SMTP id f14so2127qak.0 for ; Thu, 01 Aug 2013 16:49:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:mime-version:content-type:content-transfer-encoding:message-id :date:to:cc:subject:in-reply-to:references:x-mailer :x-gm-message-state; bh=fVcvHOsROfaNBTpKJQ3qqxmDyme48Al/8ctOiA+PQvw=; b=k9bqjHWm/es5GDmbMRKhHsZ8iE1slFPH4tU/IQNhBBRc/VzXtH87N4A9V0LjrOUj0L vyJo9JBSejJXNs9Rvr7vn/wfxcaU4I6M7LK8LJSIXHaZq4zzMD0PWnOgFXrCO6J5AHs6 85WM61wfvU7si4TNkL4lqWHB7ZmxDUrPJXxSOQbjwoFfZtNxQ0QrfdSfxWmJ3HPuw94N rvq7nqholC+hFkt1YSI6Ydw3QAu0Fi/tR70aV735CPhumWE5bQg/wuhLTW9adgyuK95N zgGmLB19tQ5FzIU5wcae4w0FyYjtg+CRFTUaiHWbS7oAm2Ihi3j5lUVkD3asvWJFNscJ p3cg== X-Received: by 10.236.42.116 with SMTP id i80mr1623967yhb.26.1375400995331; Thu, 01 Aug 2013 16:49:55 -0700 (PDT) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id m65si2125949yhn.0.2013.08.01.16.49.55 for (version=TLSv1.1 cipher=AES128-SHA bits=128/128); Thu, 01 Aug 2013 16:49:55 -0700 (PDT) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id B41FB31C03C; Thu, 1 Aug 2013 16:49:54 -0700 (PDT) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <20986.62497.975502.698564@ruffy.mtv.corp.google.com> Date: Thu, 01 Aug 2013 23:50:00 -0000 To: Tom Tromey Cc: gdb-patches Subject: Re: [RFA] remove duplicates in search_symbols In-Reply-To: <8738r68uze.fsf@fleche.redhat.com> References: <8738r68uze.fsf@fleche.redhat.com> X-Gm-Message-State: ALoCoQn8EP/gcKBM+IHawLgh4x99wvUf4gGiYU519xkgCkvvUKyd0RfohFli5WW0FRUUsjN/DgahJj+EGDbLSjPCnyAxGsMEAwVh9PuHltTpQuOQVa3ohS7NRlJrYqA1dpL1P/1kzR6PPrK6AndN/89buH62Zhz48ljvW5i77Wv24vFB/j1LlvFQvEoEDgCFCr6YFrF3emEiFAhl59fSFlGqnNcK2K5I6A== X-SW-Source: 2013-08/txt/msg00054.txt.bz2 Tom Tromey writes: > >>>>> "Doug" == Doug Evans writes: > > >> 2013-06-15 Doug Evans > >> > >> * symtab.c (do_free_search_symbols_cleanup): Change arg to, > >> effectively, struct symbol_search **. > >> (make_cleanup_free_search_symbols): Change arg to struct > >> symbol_search **. > >> All callers updated. > >> (compare_search_syms): Compare symtab file name and block as well. > >> (search_symbols_equal): New function. > >> (sort_search_symbols_remove_dups): Renamed from sort_search_symbols. > >> New args new_head, new_tail. Result is now void. Remove dups after > >> sorting the symbols. > >> (search_symbols): Sort all found symbols once, after all > >> have been found, > >> and remove duplicates. Simplify cleanup tracking of result. > >> * symtab.h (make_cleanup_free_search_symbols): Update prototype. > > Doug> Ping. > > Looks good to me. > > It seems make_cleanup_free_search_symbols isn't used outside of > symtab.c. Thanks. Yeah, all of these are not used outside of symtab.c. struct symbol_search { ... }; extern void search_symbols (char *, enum search_domain, int, char **, struct symbol_search **); extern void free_search_symbols (struct symbol_search *); extern struct cleanup *make_cleanup_free_search_symbols (struct symbol_search **); I'm semi-ambivalent about keeping them as an exported part of the API so I left making them static for another pass.