From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17745 invoked by alias); 17 Jul 2013 05:31:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17718 invoked by uid 89); 17 Jul 2013 05:31:12 -0000 X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_20,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RDNS_NONE,SPF_PASS autolearn=ham version=3.3.1 Received: from Unknown (HELO mail-vc0-f201.google.com) (209.85.220.201) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 17 Jul 2013 05:31:10 +0000 Received: by mail-vc0-f201.google.com with SMTP id gf11so150359vcb.0 for ; Tue, 16 Jul 2013 22:31:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:mime-version:content-type:content-transfer-encoding:message-id :date:to:cc:subject:in-reply-to:references:x-mailer :x-gm-message-state; bh=1ShsKDzb2vF+3aDMb2OnYHROyrm3G/DG01BNxPeom8Q=; b=Uc89CWcKe2yQfkWZVXjyLR2XuSFzjv/OMJPDycZqyvYZgpTecwAARQpqaS3AlMa0IG MjYTxKCG73vQ2bErGuxZ0vTSx5jb/dbBujD9c3S/h3D9fMVjrlLWoexCSUrsggs3GKd4 UuPJWq85OniY3AGvLrcB2kHdpCf9byLpCQ4YmQXeJEQ6bpm7BJafJOrHAq2N128VeJnc NLt0DIQifLECZ8TlrbBd76kvJR+hPFEGhtq//amPlW5atsjwwo7H3f8zJIhXwVxz3hL/ b8BmRT/nwMCxm3b5kJBhc4wU2GQwYJxJDG0AZrYFu2RrqUOIUV91CwYNkPX21aTkwVIz Vfig== X-Received: by 10.236.88.231 with SMTP id a67mr2734059yhf.39.1374039062895; Tue, 16 Jul 2013 22:31:02 -0700 (PDT) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id p73si2106854yhh.5.2013.07.16.22.31.02 for (version=TLSv1.1 cipher=AES128-SHA bits=128/128); Tue, 16 Jul 2013 22:31:02 -0700 (PDT) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id 5A6EE31C23B; Tue, 16 Jul 2013 22:31:02 -0700 (PDT) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <20966.11285.786955.625470@ruffy.mtv.corp.google.com> Date: Wed, 17 Jul 2013 05:31:00 -0000 To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: Build regression with --enable-targets=all [Re: [RFA] Remove target_section.bfd] In-Reply-To: <20130717043245.GA3037@host2.jankratochvil.net> References: <20130717043245.GA3037@host2.jankratochvil.net> X-Gm-Message-State: ALoCoQkRK+iKLFRRYynlb0wpbq7AN+lxf/D9o+Q9MVRSq43FLoixT3mEO2uX2OIpguWtazxFI0xZFVks1IFqs5NJYLWIBXAMB2WIY1IEzgaWls+CatxfrLErWsa+Fl6sUuyaI2TRIUcDP88eqpwC5Iu6PWc4hHXfldmMG6QHS02XpqC0yH7nKPoZOfPOExXhR4y8IdMBNfAhtHu+LZAZ4Y3qfKHqJ9LXng== X-SW-Source: 2013-07/txt/msg00379.txt.bz2 Jan Kratochvil writes: > On Tue, 16 Jul 2013 00:42:33 +0200, Doug Evans wrote: > > 2013-07-15 Doug Evans > > > > * target.h (struct target_section): Delete member bfd. > > All users updated to use the_bfd_section->owner instead. > > * exec.c (add_to_section_table): Assert bfd is expected value. > > Remove initialization of target_section.bfd. > > (remove_target_sections): Update. > > (section_table_available_memory): Update. > > (section_table_xfer_memory_partial): Update. > > (print_section_info): Update. > > (exec_set_section_address): Update. > > * record-full.c (record_full_core_xfer_partial): Update. > > * solib-svr4.c (svr4_relocate_section_addresses): Update. > > * solib-target.c (solib_target_relocate_section_addresses): Update. > > * symfile.c (build_section_addr_info_from_section_table): Update. > > * target.c (memory_xfer_live_readonly_partial): Update. > > (memory_xfer_partial_1): Update. > > With --enable-targets=all I get: > > nto-tdep.c: In function nto_relocate_section_addresses: > nto-tdep.c:309:48: error: struct target_section has no member named bfd > make: *** [nto-tdep.o] Error 1 > ppc64-tdep.c: In function ppc64_convert_from_func_ptr_addr: > ppc64-tdep.c:386:40: error: struct target_section has no member named bfd > make: *** [ppc64-tdep.o] Error 1 > solib-aix.c: In function solib_aix_relocate_section_addresses: > solib-aix.c:393:18: error: struct target_section has no member named bfd > make: *** [solib-aix.o] Error 1 > s390-tdep.c: In function s390_load: > s390-tdep.c:1182:15: error: struct target_section has no member named bfd > s390-tdep.c:1182:15: error: left-hand operand of comma expression has no effect [-Werror=unused-value] > cc1: all warnings being treated as errors Yikes. Committed. 2013-07-16 Doug Evans * nto-tdep.c (nto_relocate_section_addresses): Update, target_section.bfd deleted. * ppc64-tdep.c (ppc64_convert_from_func_ptr_addr): Ditto. * s390-tdep.c (s390_load): Ditto. * solib-aix.c (solib_aix_relocate_section_addresses): Ditto. Index: nto-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/nto-tdep.c,v retrieving revision 1.50 diff -u -p -r1.50 nto-tdep.c --- nto-tdep.c 16 Jul 2013 20:43:48 -0000 1.50 +++ nto-tdep.c 17 Jul 2013 05:20:19 -0000 @@ -306,7 +306,7 @@ nto_relocate_section_addresses (struct s /* Neutrino treats the l_addr base address field in link.h as different than the base address in the System V ABI and so the offset needs to be calculated and applied to relocations. */ - Elf_Internal_Phdr *phdr = find_load_phdr (sec->bfd); + Elf_Internal_Phdr *phdr = find_load_phdr (sec->the_bfd_section->owner); unsigned vaddr = phdr ? phdr->p_vaddr : 0; sec->addr = nto_truncate_ptr (sec->addr + lm_addr (so) - vaddr); Index: ppc64-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/ppc64-tdep.c,v retrieving revision 1.3 diff -u -p -r1.3 ppc64-tdep.c --- ppc64-tdep.c 4 Jun 2013 02:44:35 -0000 1.3 +++ ppc64-tdep.c 17 Jul 2013 05:20:19 -0000 @@ -383,7 +383,8 @@ ppc64_convert_from_func_ptr_addr (struct gdb_byte buf[8]; int res; - res = bfd_get_section_contents (s->bfd, s->the_bfd_section, + res = bfd_get_section_contents (s->the_bfd_section->owner, + s->the_bfd_section, &buf, addr - s->addr, 8); if (res != 0) return extract_unsigned_integer (buf, 8, byte_order) Index: s390-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/s390-tdep.c,v retrieving revision 1.212 diff -u -p -r1.212 s390-tdep.c --- s390-tdep.c 24 Jun 2013 22:18:31 -0000 1.212 +++ s390-tdep.c 17 Jul 2013 05:20:19 -0000 @@ -1179,7 +1179,8 @@ s390_load (struct s390_prologue_data *da struct target_section *secp; secp = target_section_by_addr (¤t_target, addr.k); if (secp != NULL - && (bfd_get_section_flags (secp->bfd, secp->the_bfd_section) + && (bfd_get_section_flags (secp->the_bfd_section->owner, + secp->the_bfd_section) & SEC_READONLY)) return pv_constant (read_memory_integer (addr.k, size, data->byte_order)); Index: solib-aix.c =================================================================== RCS file: /cvs/src/src/gdb/solib-aix.c,v retrieving revision 1.7 diff -u -p -r1.7 solib-aix.c --- solib-aix.c 30 May 2013 17:31:00 -0000 1.7 +++ solib-aix.c 17 Jul 2013 05:20:19 -0000 @@ -390,8 +390,8 @@ static void solib_aix_relocate_section_addresses (struct so_list *so, struct target_section *sec) { - bfd *abfd = sec->bfd; struct bfd_section *bfd_sect = sec->the_bfd_section; + bfd *abfd = bfd_sect->owner; const char *section_name = bfd_section_name (abfd, bfd_sect); struct lm_info *info = so->lm_info;