From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id hZZQNKV+qWpxCw8AWB0awg (envelope-from ) for ; Tue, 15 Sep 2026 13:21:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1789492901; bh=fVd07v31qNkF1YrJhQrPk0tGXmoNaXdqvxYOqbOXZ/A=; h=Date:Subject:From:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=NsDbSCIKPB+kMpQnX51HRCF7XEG4JcPPtkkmKCj+3HBJmmvMhWqdvk+FtWUi0/WtX /UueKeTxF3pbNiPia1IEbtAOWWNewTcNDHvrzDfWejM5AVLnxE8WL5bMCCo2AsjDE/ OoqFzQ03iSl6/fKXUTVP9oP0VrZEKwseef+9Mw6Q= Received: by simark.ca (Postfix, from userid 112) id B88981E06B; Tue, 15 Sep 2026 13:21:41 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=iUHtgn1h; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 14A091E01F for ; Tue, 15 Sep 2026 13:21:41 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A59B44BA902F for ; Tue, 15 Sep 2026 17:21:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A59B44BA902F Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=iUHtgn1h Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id DBB8D4BA902F for ; Tue, 15 Sep 2026 17:21:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DBB8D4BA902F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DBB8D4BA902F Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789492878; cv=none; b=V/GYwB0X8PAAvZYe9Jw579WcdEqmfPQEqlVhBfOP9J0WSOJPCUlgEv8k7dq0wmRjKVX8MlnBj2CNIrRRDCpbmKup8G7gvr6YlzQChS89a43GWflzLx8W4jdvMUeJHf2ttWJ2Lm40MOGNA4lepuJ+RD2zJJlNpYDKxEp+RldGILI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789492878; c=relaxed/simple; bh=fVd07v31qNkF1YrJhQrPk0tGXmoNaXdqvxYOqbOXZ/A=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=q4/zn96IbfqX0bHJWRDM16bFI5DVU0EPWhUi7GRLXbvSCiIqvcIfuf/h3l/eJ2oeNHV2GhDl/LBuOm0Fli16T5hmO+betos5j66vj7F9qlRLkFOGmQ6LGIWkqBAvyrzIbn7byn0PeR/OGpA9bFpgNoFn1kUBos4gOqMcgsyXtW4= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=iUHtgn1h DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DBB8D4BA902F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1789492878; bh=fVd07v31qNkF1YrJhQrPk0tGXmoNaXdqvxYOqbOXZ/A=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=iUHtgn1hxMcApO8PyjuLeAGvNne36Iju6mNdSOi/Nx//U+PMVuSdRsnV2u8SrsC1y II0doTFR7j9QFPEH5tpV8ClBxYkVywWIqO8aURhK67AVW1OLCcNFQV6WtvGLIo1yin 6uuGkOtkXY9jp7kIjDdQSneKdZDyq4DeGcEOyI/c= Received: by simark.ca (Postfix) id A51B31E01F; Tue, 15 Sep 2026 13:21:17 -0400 (EDT) Message-ID: <20947682-a728-4eaa-b914-5bcc3be11897@simark.ca> Date: Tue, 15 Sep 2026 13:21:17 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv3] gdb: resolve class name via DW_AT_signature in cooked index From: Simon Marchi To: Tom Tromey , Andrew Burgess Cc: gdb-patches@sourceware.org References: <295672ce0ea0bf20911fbbc997f38fe9f62b19be.1787952498.git.aburgess@redhat.com> <897f5eb957bdfd90cd3fd5efa662021ed5c2aef2.1788269262.git.aburgess@redhat.com> <1a67b29f-e2f1-480a-ae2b-e0d0d5acfdca@simark.ca> <874ifvy4u7.fsf@tromey.com> <87ecewc6gn.fsf@redhat.com> <875x06dd6f.fsf@redhat.com> <87y0d2v9rt.fsf@tromey.com> <8ff7fcd2-f79c-48fc-9730-fbaf4dc17ec3@simark.ca> Content-Language: en-US In-Reply-To: <8ff7fcd2-f79c-48fc-9730-fbaf4dc17ec3@simark.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-09-15 11:55, Simon Marchi wrote: > Having a bad parent is rare, that would only happen when some > (nameless) type has a DW_AT_signature and the matching type unit can't > be found. That would be a buggy producer that "forgets" to add the > necessary type units. > > But the basic case where the name fixup is needed isn't an error case, > it's just what happens when using clang with -fdebug-types-section, > since structures/classes are nameless: > > 0x0000099e: DW_TAG_structure_type > DW_AT_declaration [DW_FORM_flag_present] (true) > DW_AT_signature [DW_FORM_ref_sig8] (0xdf1329ababfff8ca) > > So I suppose you'll get one fixup to do per structure/class type. > > Doing the fixups in parallel is easy, since it's just looking up the > signature -> maps, and the "finalize" step already exists, so why not. I tested this patch on a big program (Blender). I moved the deferred name computation to set_contents (done serially). It takes 0.014 seconds to do it for 820602 names. So yeah, I'm fine if you want to move it to set_contents (done serially) for simplicity. Simon