From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id DfPNH4R7vGEQCQAAWB0awg (envelope-from ) for ; Fri, 17 Dec 2021 06:59:00 -0500 Received: by simark.ca (Postfix, from userid 112) id 724611F0CE; Fri, 17 Dec 2021 06:59:00 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, NICE_REPLY_A autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7E8361F0B9 for ; Fri, 17 Dec 2021 06:58:59 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EEFFA3858430 for ; Fri, 17 Dec 2021 11:58:58 +0000 (GMT) Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by sourceware.org (Postfix) with ESMTPS id 4749A3858407 for ; Fri, 17 Dec 2021 11:58:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4749A3858407 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f54.google.com with SMTP id i22so3505360wrb.13 for ; Fri, 17 Dec 2021 03:58:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=q4fFDL0UQMo9ndktmIaYCRRcvYK3fVomFLhgtludlI8=; b=ZMVsi239YB9/pHX3+fUkLKBn8SbrtD2STBnNdwaQExbjtic2mWFS9paFea+YlYXGOB hH2s7EwAT1kykJTzu3+wZIldHryVuFYGSo7ObSPb+Cx5T7SZNhh7JY/pX99SYBqIhCiY 9dZc/hpoeglBm35gaa0fMyWkzvZdstdYn0FrsKqif+CZuIKazlo1EU9L1EQkMra6Pn7K 6CEWeamRWRgu/TWgcXUCb3ykm1grJrIayzPEIdM6lZAfZkLlW8G8w0SolKMi26lVJc9z Vr69yY7wVNZOkW0m+wlCuZBv3s1jIB6NZG0wY1CzjFO6z1sUmtH4qFj2AvCOF1OcvF/a CzNw== X-Gm-Message-State: AOAM530C8jMkforZS3+czommvmdUi3GYV6fH4xMUmwsZuUO8xQxpVopP 4J05OHgO/66aD/qVNZx2ACkDRE+0BV8= X-Google-Smtp-Source: ABdhPJwvHsRmJV/XeZkOa6V98qMgOPSUdz7zu8doU13qhIPQj9fgn+NoKUuRdtwLQhRHd9LN3J8yVw== X-Received: by 2002:adf:fb09:: with SMTP id c9mr2297251wrr.223.1639742327180; Fri, 17 Dec 2021 03:58:47 -0800 (PST) Received: from ?IPV6:2001:8a0:f912:1a00:fb57:3faf:e98:b979? ([2001:8a0:f912:1a00:fb57:3faf:e98:b979]) by smtp.gmail.com with ESMTPSA id k7sm7477450wrg.105.2021.12.17.03.58.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Dec 2021 03:58:46 -0800 (PST) Message-ID: <20927c21-877a-9a22-692e-448955430247@palves.net> Date: Fri, 17 Dec 2021 11:58:44 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH 21/29] gdb/testsuite: Remove duplicates from gdb.base/shlib-call.exp Content-Language: en-US To: Lancelot SIX References: <20211121175636.779325-1-lsix@lancelotsix.com> <20211121175636.779325-22-lsix@lancelotsix.com> <20211216225701.ufirbtwtqxd6o4kt@Plymouth> From: Pedro Alves In-Reply-To: <20211216225701.ufirbtwtqxd6o4kt@Plymouth> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-12-16 22:57, Lancelot SIX wrote: >> Let's not fix DUPLICATEs with duplication. :-) Write instead: >> >> with_test_prefix "after restart" { >> gdb_test_no_output "set print sevenbit-strings" >> gdb_test_no_output "set print address off" >> gdb_test_no_output "set width 0" >> } >> >> Actually, I take that back. We should just delete these 3 "set" commands and the same ones >> at the bottom too. Setting width to 0 is already done centrally. The other two make >> no difference in this test. I strongly suspect this is very very old test code. >> >> The "Start with a fresh gdb" block could just use clean_restart. > > Hi, > > I did the changes and added some more cleanup (removed trailing > whitespaces). You missed removing the 3 set commands after the first clean_restart. OK with that change.