Re: [patch] Improve symbol lookup performance noted in PR 15519

Doug Evans
2013-06-06T19:03:26Z

[-- Attachment #1: Type: text/plain, Size: 1594 bytes --]

On Thu, Jun 6, 2013 at 3:18 AM, Pedro Alves <palves@redhat.com> wrote:
>> # Check inheritance of typedefs.
>> -foreach klass {"A" "D" "E" "F"} {
>> +foreach klass {"A" "D" "E" "F" "A2" "D2"} {
>> gdb_test "ptype ${klass}::value_type" "type = int"
>> gdb_test "whatis ${klass}::value_type" "type = int"
>> gdb_test "p (${klass}::value_type) 0" " = 0"
>> @@ -57,6 +58,13 @@ if ![runto 'marker1'] then {
>> continue
>> }
>>
>> +# Check inheritance of typedefs again, but this time with an active block.
>> +foreach klass {"A" "D" "A2" "D2"} {
>> + gdb_test "ptype ${klass}::value_type" "type = int"
>> + gdb_test "whatis ${klass}::value_type" "type = int"
>> + gdb_test "p (${klass}::value_type) 0" " = 0"
>> +}
>> +
>
> Looks like this will create duplicate messages in gdb.sum.
> Could you use with_test_prefix to make them unique please?

Fixed.

>> # Print class types and values.
>> Index: testsuite/gdb.cp/derivation2.cc
>> ===================================================================
>> RCS file: testsuite/gdb.cp/derivation2.cc
>> diff -N testsuite/gdb.cp/derivation2.cc
>> --- /dev/null 1 Jan 1970 00:00:00 -0000
>> +++ testsuite/gdb.cp/derivation2.cc 5 Jun 2013 22:21:18 -0000
>> @@ -0,0 +1,49 @@
> ...
>> + You should have received a copy of the GNU General Public License
>> + along with this program. If not, see <http://www.gnu.org/licenses/>.
>> + */
>
> (this placement for */ looks a little odd.)

Cut-n-paste from derivation.cc.

bash$ grep "^ *[*]/$" testsuite/*/*.* | wc
277 482 7364

I'm not going to worry about it.

[-- Attachment #2: gdb-130606-derivation-test-names-1.patch.txt --]
[-- Type: text/plain, Size: 2059 bytes --]

2013-06-06 Doug Evans <dje@google.com>

* gdb.cp/derivation.exp: Make tests have unique names.

Index: gdb.cp/derivation.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.cp/derivation.exp,v
retrieving revision 1.25
diff -u -p -r1.25 derivation.exp
--- gdb.cp/derivation.exp 5 Jun 2013 22:28:51 -0000 1.25
+++ gdb.cp/derivation.exp 6 Jun 2013 18:59:35 -0000
@@ -40,15 +40,17 @@ if {[prepare_for_testing $testfile.exp $
}

# Check inheritance of typedefs.
-foreach klass {"A" "D" "E" "F" "A2" "D2"} {
- gdb_test "ptype ${klass}::value_type" "type = int"
- gdb_test "whatis ${klass}::value_type" "type = int"
- gdb_test "p (${klass}::value_type) 0" " = 0"
-}
-foreach klass {"Z" "ZZ"} {
- gdb_test "ptype ${klass}::value_type" "type = float"
- gdb_test "whatis ${klass}::value_type" "type = float"
- gdb_test "p (${klass}::value_type) 0" " = 0"
+with_test_prefix "before run" {
+ foreach klass {"A" "D" "E" "F" "A2" "D2"} {
+ gdb_test "ptype ${klass}::value_type" "type = int"
+ gdb_test "whatis ${klass}::value_type" "type = int"
+ gdb_test "p (${klass}::value_type) 0" " = 0"
+ }
+ foreach klass {"Z" "ZZ"} {
+ gdb_test "ptype ${klass}::value_type" "type = float"
+ gdb_test "whatis ${klass}::value_type" "type = float"
+ gdb_test "p (${klass}::value_type) 0" " = 0"
+ }
}

# Set it up at a breakpoint so we can play with the variable values.
@@ -59,10 +61,12 @@ if ![runto 'marker1'] then {
}

# Check inheritance of typedefs again, but this time with an active block.
-foreach klass {"A" "D" "A2" "D2"} {
- gdb_test "ptype ${klass}::value_type" "type = int"
- gdb_test "whatis ${klass}::value_type" "type = int"
- gdb_test "p (${klass}::value_type) 0" " = 0"
+with_test_prefix "at marker1" {
+ foreach klass {"A" "D" "A2" "D2"} {
+ gdb_test "ptype ${klass}::value_type" "type = int"
+ gdb_test "whatis ${klass}::value_type" "type = int"
+ gdb_test "p (${klass}::value_type) 0" " = 0"
+ }
}

gdb_test "up" ".*main.*" "up from marker1"