From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6228 invoked by alias); 20 May 2013 20:27:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6215 invoked by uid 89); 20 May 2013 20:27:20 -0000 X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD,SPF_PASS,TW_GD autolearn=ham version=3.3.1 Received: from mail-ye0-f201.google.com (HELO mail-ye0-f201.google.com) (209.85.213.201) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 20 May 2013 20:27:13 +0000 Received: by mail-ye0-f201.google.com with SMTP id q9so136057yen.4 for ; Mon, 20 May 2013 13:27:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:mime-version:content-type:content-transfer-encoding :message-id:date:to:cc:subject:in-reply-to:references:x-mailer :x-gm-message-state; bh=5VDveJm5BzWujhZt/iHgpAibTz56Uv1FO+o0vQaK82o=; b=mz1dO8/fSzqiilm55SL9Eap04Nyi/Pg4ibZeQ5dkN46x1JNyPlhHPD7gTlkKP+HgGu SSJfAko6qx4E0C/+/GXOZmPuEwD5xIUUGHR1c/JBUwZd8vmEtTfVxK64pzfuFsnPpiO/ sfvimdKGvfYaqirBR+FhTEP/qjIP3DFK46kdMG6fDOcuyJA4063nU9lkwJKULaJ4n4wt 4PlXjFzkqMepHQjjxA8OBTFg7YvRJQFZjsGsgVaWYw7G5pvn5INtwlC7oO1FXCqziKyB AuCJ+1+NFCG3D3JTemkfDBkFjzDBivljzy6PNSnoHQ3Te4j0Tk91TJ7M8i9W1ck+PHbu k0+w== X-Received: by 10.236.70.170 with SMTP id p30mr32978293yhd.5.1369081631447; Mon, 20 May 2013 13:27:11 -0700 (PDT) Received: from corp2gmr1-2.hot.corp.google.com (corp2gmr1-2.hot.corp.google.com [172.24.189.93]) by gmr-mx.google.com with ESMTPS id h2si2239967yhj.2.2013.05.20.13.27.11 for (version=TLSv1.1 cipher=AES128-SHA bits=128/128); Mon, 20 May 2013 13:27:11 -0700 (PDT) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-2.hot.corp.google.com (Postfix) with ESMTP id E41305A41D4; Mon, 20 May 2013 13:27:10 -0700 (PDT) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <20890.34590.365415.345999@ruffy.mtv.corp.google.com> Date: Mon, 20 May 2013 20:27:00 -0000 To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: new maint.exp FAIL w/-fdebug-types-section [Re: [RFA 1/2, doc RFA] maint check-symtabs, maint expand-symtabs] In-Reply-To: <20130519112343.GA1260@host2.jankratochvil.net> References: <20130519112343.GA1260@host2.jankratochvil.net> X-Gm-Message-State: ALoCoQmUW0v2/PTs/Ai4Kj5KuqPTYbnkb6vjpqNvVk2zwgxIcFyC2CH5Ty1pRczURZUvKeak6FYcY2ejZ52YQ2dErQ5JeMgRaYzCQLA8QXUkr1p1wFA8xsA+HdwoETgtcP+T4V56SqJAjITzKJwWHyFIJimN5BHEJVuxInBavvyXQb25yCcrbnzsLa2Ik6lQYuBgKLYyJLjFuaFJjY6dmJrTLeUx+5LYRA== X-SW-Source: 2013-05/txt/msg00746.txt.bz2 Jan Kratochvil writes: > On Mon, 13 May 2013 22:20:59 +0200, Doug Evans wrote: > > +# Test "mt expand-symtabs" here as it's easier to verify before we > > +# run the program. > > +gdb_test_no_output "mt set per on" "mt set per on for expand-symtabs" > > +gdb_test_multiple "mt expand-symtabs $subdir/break\[.\]c$" \ > > + "mt expand-symtabs" { > > + -re "#primary symtabs: 1 \\(\[+\]1\\),.*$gdb_prompt $" { > > + # This should expand exactly one (primary) symtab. > > + pass "mt expand-symtabs" > > + } > > + } > > +gdb_test "mt set per off" ".*" "mt set per off for expand-symtabs" > > $ runtest CC_FOR_TARGET="gcc -gdwarf-4 -fdebug-types-section -g0" gdb.base/maint.exp > FAIL: gdb.base/maint.exp: mt expand-symtabs > > mt expand-symtabs gdb.base/break[.]c$ > Command execution time: 0.001000 (cpu), 0.000717 (wall) > Space used: 4292608 (+0 for this command) > #symtabs: 11 (+11), #primary symtabs: 2 (+2), #blocks: 9 (+9) > (gdb) FAIL: gdb.base/maint.exp: mt expand-symtabs Blech. My normal testing uses .debug_types as a matter of course. Committed. 2013-05-20 Doug Evans * gdb.base/maint.exp: Fix test for "mt expand-symtabs" to account for -fdebug-types-section. diff -u -p -r1.65 maint.exp --- testsuite/gdb.base/maint.exp 17 May 2013 18:09:06 -0000 1.65 +++ testsuite/gdb.base/maint.exp 20 May 2013 20:19:16 -0000 @@ -89,8 +89,11 @@ gdb_test "maint print registers" "Name.* gdb_test_no_output "mt set per on" "mt set per on for expand-symtabs" gdb_test_multiple "mt expand-symtabs $subdir/break\[.\]c$" \ "mt expand-symtabs" { - -re "#primary symtabs: 1 \\(\[+\]1\\),.*$gdb_prompt $" { - # This should expand exactly one (primary) symtab. + -re "#primary symtabs: (1|2) \\(\[+\](1|2)\\),.*$gdb_prompt $" { + # This should expand one or at most two primary symtabs. + # "Normally" it will expand just the one for break.c, but if the + # file is compiled with -fdebug-types-section then a second primary + # symtab for break.c will be created for any types. pass "mt expand-symtabs" } }