From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29765 invoked by alias); 14 Mar 2013 18:34:00 -0000 Received: (qmail 29755 invoked by uid 22791); 14 Mar 2013 18:33:58 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-ye0-f202.google.com (HELO mail-ye0-f202.google.com) (209.85.213.202) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Mar 2013 18:33:54 +0000 Received: by mail-ye0-f202.google.com with SMTP id q5so256050yen.3 for ; Thu, 14 Mar 2013 11:33:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:mime-version:content-type:content-transfer-encoding :message-id:date:to:cc:subject:in-reply-to:references:x-mailer :x-gm-message-state; bh=3w8iLmOWCJ02/mAAkaxiTxIHHM+T2XeqT3HMjCuGGQY=; b=BksmqkSXbFfo3G4DH8IiFr0hocdOOPZxCJfDbt1qzDJAaVlWueByjOumUPJB8NMEU9 XPpTCF5drskSr+/rEQWu74h3UKBeMgFnUsjWBEoA1Jv5QB1kTBN3TbwsODLuShstGFSD 2OAApCQdEHzHuNAcCR5bumRB+t0LVVoN+oGRxRE+9eQLESzCymPMtSzgAEVEGWzh3FNL uxwVRnngcDJmFBgMVnBzRHg3YFWIK7KR+4YZgHp5Qp1aArbJwacSxae+LpuoIstQo9FJ GjV1F9js9bYJaWXs/g2e0opqu5KoJfIL1L64pstym3Npy7Zc1hs3nXI94ozVcorpgIZo p67w== X-Received: by 10.236.112.84 with SMTP id x60mr2227596yhg.9.1363286033894; Thu, 14 Mar 2013 11:33:53 -0700 (PDT) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id i65si387597yhh.5.2013.03.14.11.33.53 (version=TLSv1.1 cipher=AES128-SHA bits=128/128); Thu, 14 Mar 2013 11:33:53 -0700 (PDT) Received: from ruffy2.mtv.corp.google.com (ruffy2.mtv.corp.google.com [172.17.128.107]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id 5EC1731C0AC; Thu, 14 Mar 2013 11:33:53 -0700 (PDT) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <20802.6160.809589.215736@ruffy2.mtv.corp.google.com> Date: Thu, 14 Mar 2013 18:34:00 -0000 To: Yao Qi Cc: Subject: Re: [PATCH v3 12/15] Write tracepoint definition in CTF and read. In-Reply-To: <1362800844-27940-13-git-send-email-yao@codesourcery.com> References: <1362800844-27940-1-git-send-email-yao@codesourcery.com> <1362800844-27940-13-git-send-email-yao@codesourcery.com> X-Gm-Message-State: ALoCoQkrhqo5HiBxs0Ky8SGqVijl2oT+1pCwH4gSDDpX0fvbKcLPpY8n7qUEm56E3OGofCESIo9f2u1xhfI+mk37CuuzAZY+QvivaEKcKR/Sni874TkV2U0JKDtLTPGibIaOSLiFDyLn5K/EFfXW64Z0zzJcoE0H6Yz18kt2O0zHVibLH4ws+9e9K9af10Is6El6xQDLOn7n1BWG8LO6QYrIg9SGX8I40w== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00646.txt.bz2 Yao Qi writes: > This patch teaches GDB to write uploaded tracepoints to CTF, and also > read them out from CTF. > > gdb: > > 2013-03-08 Yao Qi > > * ctf.c (CTF_EVENT_ID_TP_DEF): New macro. > ctf_write_header): Define event type "tp_def" in metadata. > (ctf_write_uploaded_tp): Write tracepoint definition to CTF. > (SET_ARRAY_FIELD, SET_STRING_FIELD): New macros. > (ctf_read_tp): New. > (ctf_open): Call ctf_read_tp. Adjust the event id checking. > Call merge_uploaded_tracepoints. >[...] > @@ -371,6 +375,34 @@ ctf_write_header (struct trace_file_writer *self) > "\t};\n" > "};\n", CTF_EVENT_ID_TSV_DEF); > > + ctf_save_write_metadata (&writer->tcs, "\n"); > + ctf_save_write_metadata (&writer->tcs, > + "event {\n\tname = \"tp_def\";\n" > + "\tid = %u;\n\tfields := struct { \n" > + "\t\tuint64_t addr;\n" > + "\t\tuint64_t traceframe_usage;\n" > + "\t\tint32_t number;\n" > + "\t\tint32_t enabled;\n" > + "\t\tint32_t step;\n" > + "\t\tint32_t pass;\n" > + "\t\tint32_t hit_count;\n" > + "\t\tint32_t type;\n" > + "\t\tchars cond;\n" > + > + "\t\tuint32_t action_num;\n" > + "\t\tchars actions[action_num];\n" > + > + "\t\tuint32_t step_action_num;\n" > + "\t\tchars step_actions[step_action_num];\n" > + > + "\t\tchars at_string;\n" > + "\t\tchars cond_string;\n" > + > + "\t\tuint32_t cmd_num;\n" > + "\t\tchars cmd_strings[cmd_num];\n" > + "\t};\n" > + "};\n", CTF_EVENT_ID_TP_DEF); Nit: CTF_EVENT_ID_TP_DEF is a lonnggg way from the %u that uses it. Split into two pieces?