From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9156 invoked by alias); 14 Mar 2013 17:49:45 -0000 Received: (qmail 9132 invoked by uid 22791); 14 Mar 2013 17:49:43 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vc0-f202.google.com (HELO mail-vc0-f202.google.com) (209.85.220.202) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Mar 2013 17:49:38 +0000 Received: by mail-vc0-f202.google.com with SMTP id gf12so72539vcb.1 for ; Thu, 14 Mar 2013 10:49:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:mime-version:content-type:content-transfer-encoding :message-id:date:to:cc:subject:in-reply-to:references:x-mailer :x-gm-message-state; bh=r9qufQJfhqyEiQAa6NUmqUkqXPH3RbPqzCgyfx/ZvQU=; b=GqQfscqNmseCEtVhmb09VCaCYyGuZSMwzhdVshfJXcvWZ93UMA6Cx+xM+r9+o3m2OQ MZ1XV8c0o2BI8GTAtWvvqlqVpG6f9zET2pUBVjauMVlyeG8rda9N6y26iEup5aQg682D 9o8eYs6nTP2laJLG6N3BLWfpvb//AyjMix2VhURNkqk7LlBLy+QnOZMMQgnjibonoSbz 3qQ4mvRp9JjWCE+ILbZPj48boYzf1eCCoekPubRcxWgZa23CDX7dqdNZAe+Zk8QqLaSZ CeuWo9TGrZwtmwh6ZrrbiTG3v7yldS1ifKgz7MQjqbcBtPo9kC6hwtnE9fyBvRG389Z4 8wcA== X-Received: by 10.236.9.10 with SMTP id 10mr2011121yhs.44.1363283377522; Thu, 14 Mar 2013 10:49:37 -0700 (PDT) Received: from corp2gmr1-2.hot.corp.google.com (corp2gmr1-2.hot.corp.google.com [172.24.189.93]) by gmr-mx.google.com with ESMTPS id f64si367575yhj.7.2013.03.14.10.49.37 (version=TLSv1.1 cipher=AES128-SHA bits=128/128); Thu, 14 Mar 2013 10:49:37 -0700 (PDT) Received: from ruffy2.mtv.corp.google.com (ruffy2.mtv.corp.google.com [172.17.128.107]) by corp2gmr1-2.hot.corp.google.com (Postfix) with ESMTP id D08875A41B0; Thu, 14 Mar 2013 10:49:36 -0700 (PDT) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <20802.3504.290457.930526@ruffy2.mtv.corp.google.com> Date: Thu, 14 Mar 2013 17:49:00 -0000 To: Yao Qi Cc: Tom Tromey , Subject: Re: [PATCH v3 02/15] Save trace into CTF format In-Reply-To: <514055B3.6040306@codesourcery.com> References: <1362800844-27940-1-git-send-email-yao@codesourcery.com> <1362800844-27940-3-git-send-email-yao@codesourcery.com> <87k3pcfo8d.fsf@fleche.redhat.com> <514055B3.6040306@codesourcery.com> X-Gm-Message-State: ALoCoQkP1NEOlAEmrGfjB/+/f3S+SdvJA28hSDKrTtaHsQ70jK237mA7UoLEgSaHh8HHPentFHIiEUxC1Inl+1sWVP1SCHyUGJM4RRgYNqyNjhp273cEsJQyvdmx50Er+eskmxPVKWrdpC3h3a2ThipAWIkho0n7dMv1ZD8yq9Kuxxmh5HE3PTl7q/0GDJX4gxHL3l/J5qjDO3pg6yx0o7HjF1hXN9KE5Q== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00642.txt.bz2 Hi. Just some nits. Yao Qi writes: > 2013-03-13 Hui Zhu > Yao Qi > > * Makefile.in (REMOTE_OBS): Add ctf.o. > (SFILES): Add ctf.c. > (HFILES_NO_SRCDIR): Add ctf.h. > * ctf.c, ctf.h: New files. > * tracepoint.c : Include 'ctf.h'. > (collect_pseudocommand): Remove static. > (trace_save_command): Parse option "-ctf". > Produce different trace file writers per option. > Adjust output message. > (trace_save_tfile, trace_save_ctf): New. > * tracepoint.h (trace_save_tfile, trace_save_ctf): Declare. > * mi/mi-main.c: Include 'ctf.h'. > (mi_cmd_trace_save): Handle option '-ctf'. Call either > trace_save_tfile or trace_save_ctf. > +/* Write a unsigned 32-bit integer to datastream file represented by > + HANDLER. */ > + > +#define ctf_save_write_uint32(HANDLER, U32) \ > + ctf_save_write (HANDLER, (gdb_byte *) &U32, 4) Technically speaking, HANDLE and U32 should be in parens. Also, I think convention is that they be lowercase (still uppercase in the comment). [One might also just want to make this a function instead of a macro, but either way is fine with me at least for now.] > +/* This is the implementation of trace_file_write_ops method > + start. It creates the directory DIRNAME, metadata and datastream > + in the directory. */ > + > +static void > +ctf_start (struct trace_file_writer *self, const char *dirname) > +{ > + char *file_name; > + struct cleanup *old_chain; > + struct ctf_trace_file_writer *writer > + = (struct ctf_trace_file_writer *) self; > + int i; > + > + /* Create DIRNAME. */ > + if (mkdir (dirname, S_IRWXU | S_IRGRP | S_IXGRP | S_IROTH | S_IXOTH) > + && errno != EEXIST) > + error (_("Unable to open directory '%s' for saving trace data (%s)"), > + dirname, safe_strerror (errno)); I see remote-fileio.c doesn't assume S_IXGRP,et.al. are portable. Probably want to do the same here.