From: Hannes Domani <ssbssa@yahoo.de>
To: Tom Tromey <tom@tromey.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Guinevere Larsen <guinevere@redhat.com>,
Thiago Jung Bauermann <thiago.bauermann@linaro.org>
Subject: Re: [PATCH v2] Prevent downgrading of hardware watchpoints if possible
Date: Sun, 23 Aug 2026 16:52:31 +0000 (UTC) [thread overview]
Message-ID: <20703733.1253913.1787503951514@mail.yahoo.com> (raw)
In-Reply-To: <875x13qrwz.fsf@tromey.com>
Am Freitag, 21. August 2026 um 19:56:00 MESZ hat Tom Tromey <tom@tromey.com> Folgendes geschrieben:
> >>>>> "Hannes" == Hannes Domani <ssbssa@yahoo.de> writes:
>
> Hannes> The lazy flag of a value can tell us if the value contents are available.
> Hannes> But this could be either because it was simply never actually accessed,
> Hannes> or it tried to be accessed, and failed.
> Hannes> The latter are interesting for watchpoints, the former are not.
>
> Hannes> Currently it only uses lazy values if they are at the head of the value
> Hannes> chain, but this is fragile logic, and degrades some watchpoints to
> Hannes> software watchpoints where it's actually not necessary.
>
> Hannes> So this adds a new value flag 'm_fetch_lazy_failed' which tells if the
> Hannes> watchpoint expression actually tried to access the value and failed.
> Hannes> And this is used instead of the value chain location to tell if a lazy
> Hannes> value should be used as a watchpoint location.
>
> Thanks for doing this. I think this is ok.
> Approved-By: Tom Tromey <tom@tromey.com>
Pushed, thanks.
Hannes
prev parent reply other threads:[~2026-08-23 16:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260727150150.1014621-1-ssbssa.ref@yahoo.de>
2026-07-27 14:57 ` Hannes Domani
2026-08-10 17:20 ` Hannes Domani
2026-08-21 17:55 ` Tom Tromey
2026-08-23 16:52 ` Hannes Domani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20703733.1253913.1787503951514@mail.yahoo.com \
--to=ssbssa@yahoo.de \
--cc=gdb-patches@sourceware.org \
--cc=guinevere@redhat.com \
--cc=thiago.bauermann@linaro.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox