From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id am6qNuNMP2YbGA4AWB0awg (envelope-from ) for ; Sat, 11 May 2024 06:48:03 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=yahoo.de header.i=@yahoo.de header.a=rsa-sha256 header.s=s2048 header.b=EeP4Q+an; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id CBC211E0C1; Sat, 11 May 2024 06:48:03 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 17FAA1E030 for ; Sat, 11 May 2024 06:48:01 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8911138708B6 for ; Sat, 11 May 2024 10:48:00 +0000 (GMT) Received: from sonic304-21.consmr.mail.ir2.yahoo.com (sonic304-21.consmr.mail.ir2.yahoo.com [77.238.179.146]) by sourceware.org (Postfix) with ESMTPS id B4ED73858C41 for ; Sat, 11 May 2024 10:47:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B4ED73858C41 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=yahoo.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=yahoo.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B4ED73858C41 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=77.238.179.146 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715424464; cv=none; b=FAQqDC+MkePVLHcXKqEMEDG655EkeELdwcKep6VKngc+yW5kAW1O2vliNyi1LoUyVROhJxAQtQCoBAXCkjtgkCpcoPnjwfaaoswvuYBS0R6P8xrqIFzQxTAzHkSmjUS2UcGUZhpk455BiOqVTavHNjg/pMyHUFzKUm65axY5gWk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715424464; c=relaxed/simple; bh=jHh9mrBvF8V8giy98PTSsJ8t0n0qGPtZR9w9WaMPrOo=; h=DKIM-Signature:Date:From:To:Message-ID:Subject:MIME-Version; b=QyD/gq5/2jndI7u6hSyon5ztUpuNRkqYHS1o1p+McsuWQCMMYSfBN8OWzfOK3SImSm4aV3572sIhgNoEzZ1cjqASqr2Q1CH7tsmV3pkPFx5rHil4RCIhWqHlGkXIl32NmpFunj5brplksIxbumizc43ZmLSlkpcMOvolA1JdZIw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1715424461; bh=jHh9mrBvF8V8giy98PTSsJ8t0n0qGPtZR9w9WaMPrOo=; h=Date:From:To:In-Reply-To:References:Subject:From:Subject:Reply-To; b=EeP4Q+antORTOE2ynn5ldcK/g7+XGLbK9uvttreLFCYZWtq4sztrTe/23EFC6/LfX2JGO869JQx+MBSatc7GZUTrHZv2ONzaxhtbYcsDeyK/j42FozS4BUbRagj469XRdFDyqOLV0BhV+akgFWtJFP7aPc4zJUIm0ZCE1FvPyt3sdozPrPxUqxYldO8KpSOKDvLdNTfNCHxY1Ra6yZkvxAKG4Sk1sFk4YhsnzgxtWMVq86jhbUXF44Z8Q5k67TiBLFLmsJgr9q3PpsLA7LZjgMCIjQyWh7yDJzTpGIXWKtQKkX6CEjUAUhPE5dQBQf9NIEbwlUtbKX/7NfQdtyKAMw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1715424461; bh=IrvsO+/45kyzDeg3E8DX39aPZpHV4Lw1MDc9h3/Xvuz=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=VaPzxmtKMwnOey7Lan08xpVvcHekcwB+TOcgnOEnyEBiDUuAbdx36cVyBCI+K34uxPnAjeXC6kQl+yH3nikC2eCIGXsK4hHLF/383dqWBwg0i3d9CHKCtYtpTUp3tY9TkjxcYCNtjZyoJpzA9rJr3C/2XxGqrQ9xTt4LBo4CgXM4iMfN4/boGYukpkn5+yHdESAGqy2RzWoLb6XQhmQl6pKevpPMOJ4sEY0b1kkU89RP3DwErBvQBMjYUqZCblMZ1avqcCvlJ3hqpKEcRTUE5tn32+nzO/PQnNFe7hadm+Bc2H5Mw9d++02v4Ozz9NokeYjParq0NidlovCBdYQTYQ== X-YMail-OSG: jw.T5_oVM1nYyMwa1KxxCxcGfkhFEX1SwCkBpz.DpK0acZFEHavVcnrhAwmAUQr ZcemPpa2bJsj3OLtee5fdhG7hnGuuS7h7WdMOPPfjfUZ8gfqQ9ZW.0KzB0rqPot5mKtoNwsMw4O7 ew10Bs8h1vF_pHMVxTnNXJRzY0iyN0.9KH2.LshKVDlJIPhcqKHGxXUafcuxZEZVcrdswf1zxu3T vEeBwfiK6CLRBcAlTlY_vAY_sbwUjdEuOuV6C6fmFWPW7gMr7XRwI.38CuGfS9YZuSGu951.C7FB Qt.jTKDfuoD5Jrp3yHXGq0iTOxvXZqOAeo3gxo20fwQvlfsqOUbvSjYtKx.wTxtfmt_0aVCJXLnb WgUJR997gOlP5BcShOs.VuwdztMam2Vvtlf6hjkR_Iod66cI2_Aixhog0BZZ0KVl3ipSNg.viy1w leU2jB_HtkIKMvWqFRyDwABVNkRWUEzfRZNX3v8M.YuVjMshVFx_k5boTp60j06FSmZk2whf_kxJ Tzi6ZmYv.bfFicjaqI2MkF1J0CgKVg4uM6Xm5kZbZrI3HHqdb.bpjr81W1B5wfLJmrU3jjK7QhLK YXSkdsVl6ptHOCJPiSp0UOpwOxxhC5gj.y8loj4DJdcGGC3o0vbsthOBp7V9n183RpWn9CxN8Cve 20sq9T9G_0pwer8nvd.r08EcIUtlnaXLlyTE3Qcy0ToYOW3FLVKU7mWqxSj4ijGK8cO53d1UjIWK 1yTB0NIxy4nyZvp_8DDDW2VAozJ3amVdJjSloKA1170tajZOASwr4BDWzs8Dqxj1yIGtDa0mrubU gJNUizwd59KRNqdmxe4z..vmTibtwJNxSINIZ47ddjT_KYHp2jVB.Xi37xA_yTMbU_6.mGbYxfuF JqSP06eFLCNNIbSjOiVuznxcxV699.91FHzDfj5cJKqy5lRVGIzzX69lzO9rV.lNkIuBu2iAJJUA p35j7.RYI9n5KCrwCtRfBif8BC6MhZILiRAj8lB32jjJI1srx12apEpPLtwWo8IVUiK.L9vkr8So s_TeRe4L3u_4cEBgFnaUk16AIfgqmfHJ7s3CibpzpCvcqTbD6eQ3IsL53URXKunWAY0mbxuhGzPd hztJ_GGmzyaMK6CBPpjs63v8jX9hPs4OfLGX3iDN32tG3znua.KfKPniqVG_WjbUa0OTl29ECeVM D4TmC08l.xjNUo1El.vT3fXgVNfKBn19a.r7FcEU9dQ2OL11RlvTtxyViALnDrbKl_3EMyfgDQnN aXH8Lco8zrfbD9jxMY_c6IZ2VsipduRsNgZjIYs8UkD3jWraiKKTRHMtyxGOEVt84AAwRCdjEi2t 7AKan1YPRi04ZyPxC2qYbz1h8Z.udkwGalzqFzzaFhasMKlvlV9VGCxDvkZWNZJpfiBFI3tL9mcF iXPGVqMDG86eex1.5UfQvd84tISKieZjsEnU2gi.TQuMKGI6KZqhYiNxX80Kcl1zoUSFT9DJLou5 gSdpxfE5sd9B2Bg8PuEMpldn69CauUZ5cPeCls7jbbrbfT5kXkdawuh7xBDUlz31CPCbBTFpshc7 ogaxD8d29tT.fx3Xa41TCF68SYz5t5FQjmkwcNYPmT.tYu3JCMCxw2J05D_8uAv5ns9pxQTuVJ5e w_XxPfDPezfsKhUURiHnnNdoObZMHxBGB5qmC3B44ag5CIo.QTBQnDSPBWys4yV7.H5y3xqL4zL7 LSswzuS8D2..41thb0V68Xgh_rOYy6bY4G_YhOS_jHhhDrhLaxrI_4H6u26EWHFgFifNBD0HRA4o 7DffU1QPqYfc0JR_riYeYYKs9chPLlut61ZHt0ZnoF6vXEPIjqzJiID_hWapJktjxHlsUpXetSt1 DaSZiFdOvgcRoEmR8aMNtAJXO51BLM5aWw8EmNgLfZjqAYtv2Hvyj7WekTgiZfH9ryXreBslPCEr Q.WQ33mCAW9JaJmpn.hYttrax59Yrl9SNTvFuV7xaKJeyPRcqp87MwDU28sg_RMxi0FOboPTYsGO RJCENWoaY63lBxFMcvikg10.OP689jp2Haas8XtX0k3pOQveNhpuMFbk2FDhdK1ATva9FtOKJYke e8EiaX8sXl61ByH3RDRy7r1ctsOQWURZeaAaEDsXjP82e0ShtfQzTKZxcu4N79uZGt.vakIB7vxF oKJ.7FKozgAaOQ0X_CvQmhIIlw.RhaZHfkOxOHRDZkfolCNrPKFZfCwVl79GTP2wYpNu_Tzxe0MU mZfTww_fovXC0dYQaBGHf0bS6KZQKVV8g03kJYJPmxhJpVjXB X-Sonic-MF: X-Sonic-ID: a7bc44e1-cf12-425b-8580-8b0ba0da48d8 Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.ir2.yahoo.com with HTTP; Sat, 11 May 2024 10:47:41 +0000 Date: Sat, 11 May 2024 10:47:36 +0000 (UTC) From: Hannes Domani To: "gdb-patches@sourceware.org" , Pedro Alves Message-ID: <2070125856.1678800.1715424457106@mail.yahoo.com> In-Reply-To: <724b9a77-ca0b-4014-a19d-c187580400e2@palves.net> References: <20240504110942.922-1-ssbssa.ref@yahoo.de> <20240504110942.922-1-ssbssa@yahoo.de> <724b9a77-ca0b-4014-a19d-c187580400e2@palves.net> Subject: Re: [PATCH] Fix heap-use-after-free in index-cached with --disable-threading MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.22321 YMailNorrin X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Am Freitag, 10. Mai 2024 um 21:16:51 MESZ hat Pedro Alves Folgendes geschrieben: > On 2024-05-04 12:09, Hannes Domani wrote: > > > > --- a/gdb/dwarf2/cooked-index.c > > +++ b/gdb/dwarf2/cooked-index.c > > @@ -513,7 +513,7 @@ cooked_index_worker::wait (cooked_state desired_sta= te, bool allow_quit) > >=C2=A0 #else > >=C2=A0=C2=A0=C2=A0 /* Without threads, all the work is done immediately = on the main > >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 thread, and there is never anything to wa= it for.=C2=A0 */ > > -=C2=A0 done =3D true; > > +=C2=A0 done =3D desired_state =3D=3D cooked_state::CACHE_DONE; > > > I know nothing about this code, but I wondered if the "never" above in th= e comment > should say something else.=C2=A0 It matched the old code that just assign= ed to true, but > now it's conditional, which doesn't read like "never". The waiting is done in the #if CXX_STD_THREAD block above, and none of it is done in this #else block, so the comment is still fine. Hannes