Re: [PATCH] Fix for incorect breakpoint set in case of clang compiled binary

Tom Tromey
2012-11-27T15:59:05Z

>>>>> "Karthik" == KARTHIKVENKATESH BHAT <kv.bhat@samsung.com> writes:

Karthik> Please find the Changes after comments -

There are some formatting issues in the patch.

Karthik> + /* Clang always emits a line note before the prologue and another
Karthik> + one after.We trust clang to emit usable line notes */

Two spaces after the ".".
A "." followed by 2 spaces at the end of the second sentence.

Karthik> + return max(start_pc,post_prologue_pc);

Space before open paren and after the comma.

Tom