From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mcvvL3c5BGCzfgAAWB0awg (envelope-from ) for ; Sun, 17 Jan 2021 08:19:51 -0500 Received: by simark.ca (Postfix, from userid 112) id B44A51EF80; Sun, 17 Jan 2021 08:19:51 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 081A31E940 for ; Sun, 17 Jan 2021 08:19:51 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2DC3A389364A; Sun, 17 Jan 2021 13:19:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2DC3A389364A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1610889590; bh=RLhudduGQ+OIqsdpBDcg6qf7vxuJ7NPIGPDYp5WMAdg=; h=Date:To:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=eO0WOahkf6hKEJ3mo3o8ENVWGs4dT6VFjxbGRzNiijD8BfkdhVNsPj5DekEKyq/b1 hlgS+Pr8IKAuFOtOvDtmZ+mGHMiwIYyFiOIlqibep7++i5RTg0rI46Ehi2oZIDxZ/1 FQh5vSKhgcq6j5fXH2g6zLIvBnBCi34hI7Qxa5Q8= Received: from sonic309-24.consmr.mail.ir2.yahoo.com (sonic309-24.consmr.mail.ir2.yahoo.com [77.238.179.82]) by sourceware.org (Postfix) with ESMTPS id 7359838930CE for ; Sun, 17 Jan 2021 13:19:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7359838930CE X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1610889585; bh=snIIITdD7VsmiNgp759GY442KFNIpDuEfFaEmd7Sw7v=; h=Date:From:To:Subject:From:Subject:Reply-To; b=qIQQAFtMEoVesRIA3Uvl9oOdbXKWxekygzyO2eXH+okzSintYi+ULTrEv3h/JtMxwFo+BO2GsVoEXdzYyVQZnd2oMYqUMFoiWdLfUWbTn3fyuFa1Ak1bIDHZ9h5QWWTNXz4e2WfSy1hp+MbDKNC1ELShKdyF7GMOhwPnjeY37O621TdJ0TGKNX5K6iGDj6ai6/25Ma86r6dOxo4R2XLeWRtWvjdr2WvluyX0xlAWDitMHWnRDlFDEVHeEB91S0+oCf2JHHLVS5SIVFR4ki9kvEbMI7gJwZOYBYY6ShIkid1lnFKT9HK9OXTYrEULFjz5CpL0BoQ60BG1Pk1wlWi+lw== X-YMail-OSG: 1wZRyVwVM1nFCUQo1kTTq7QffnxRp3_YmQ5DYZ_FZ9S56uff_AOWZjogH59px90 jxZAubYcS78p7cirPG8MVJaBuSveGlof34GTj41lTS02py4PxJJBaMI4SQZ2lVZXClq4UlOWiBas Y1nJNTn2zb21rkUW25ONLIsmkE.vbNs6eKmY1chxIC81h.oAFkPBB_Q9CTQe2CaRuBCs68hkXZ9S ei53wD_aJ77MPq8PtEg7gBNm4erH30J.rr.G2bDn3ySkyo2elkpufaOZaT5lsJ3tUodQXu6voTjz l4d0Iay_2oC8bAoTG9CdwncFfQ99WCWVKg6D7oHvq4ToGKcCG0NoTDVPou8JMLV7DZnaHqtT9KOo DUIS.inj_hzvfv3XI9ghpYiCWxI17ufgJT53CZ0Dv.COCSZaMGHi0TXUs_ShLvWWT2NyN4TXzyLn qYE7DjuHZvdP3ktkByk9lQ2QgnaayWcWmigN4KXJVVWDm.iqQ3IcZv2MZbv5ulFBRHqv_qxw9tK3 V7WSXj4lS1dS4xvVRJhw3lCOg1_91XpOYi998q7LY59OYcg9tsMpGc6BLS5vi3CDZ_g9Cba.WaUQ qQaYJ38aDXq_RVNxpTDMAo1SstyXa85w9PAf.BuNqtqzhz5ne.ycwB3DOz9MlbTOv4LcBKAFUBVj SQP6qOXM0tVUKjhLVuQOo6VNHwFR4Vf2cqU2U7AvmLM0lXc6350eu973A7CRqzRLNjsmjWMN94f4 zvQDck5u3v575ZWrN71ERKPewNECo1bdZyVw6it3cOaSCItN0KWjQMV7iw6jJ8Yqr6j0ZS0RQZw_ 0GWWXAYeDQQs3blK1OzuSfXXD5egTWOHZgaKRJAwr4fjOBMna5iX3k8wFfG.m77fsfQdJ50zSIXA bnpUiSgVWO27JDNd_t52D95tn3tOeGgQxyIinEYKA0wLvp4QaEu73R1q6Hnn9GievGImPHucsQ_G l39Fe.mVmZdSbF2FvPwuXdX2qZtNbFfVEh7uGUm_.WqakIVOYmW99iVevUGwEUMSR8FdQPyidSbd ewNDEXDMTh2ii5ikCBKQ6Dlx9FXQa6eOjkLxM7_pvBPOxL92U.rUOJTUcPf53djWRnkYGw1D_CBD OVJpGNaHklnxq8Zd24AZUfG846KKdPBBmLjIUBJ0dgTrZ4QOoAItpLrFmc12EPE7YhXOBY03T4vD TCdlmTvkN8VVy0VfjU7uQg.s0JjwPGUKzYDJRKurtEApAh0RCxdn9n6Z3JYJW.SFxqJRq2n0VbE0 cmdpncZ59BNB5BrspwiE9tPtQCOCdepBvu4SaEqclzp.KOVHQu9GTgU4qrM4ZjXCcna3Z_HiRVi0 VOOF3rQOcbo8rsQ9hv2kExLqv7WcEcKa_moNDOQdLb9Owo6s1aIrIxKZvVX7JW5K4Wh..XNxC9oT 9_DOEMni3aGNfQOGglS9OM1R2sgjdpZY3UccOSmCvWwHmYYQhnee1o3ld3qXlHdWhUfebzYz7_Bx f2.p.n0IcBb3akSbFz_9ldK9qaQmWZDToIVKpmgM_5hafR_27__jpWYqU1O8Y6OKj4wDa356oVP4 Obw6fg2kc9lKblVixUnPzsJ0.0g4PljygTfbypuijZo2rDCB4TGYI6msHKMFtgxqqmm23EwksSKe .j1dBD54S2xf9btyNZFyDqwZWfabL4hJCfAPYRsmxBzpKEccMghd4oQYyenWLby17kYH2tZY_DZw 6URVZjw8d1KNyyfp7GJi5rcWcBpW9m52dCIcNRh3jjiwkmun1XSjzx5Q9gv6MMTZs9Sg9JhSadeI kpHitR8AElSs2QNvUtouf5xEtwh97j6wMg6uvOeTHbd1ik2QLW5dlXRlYlJbTy4l6.TxWswtF_sk lzopddLiOFahFBi1o6DEIjMDckImUbVutPy6.ZHe9tH2JM9oC5kIHEE852KxnpU07eZZDQ1.sFTU CKO7k20Lv5SFUWp9RbjNW0g9wSiHGB7avq75K8ro2ANg1x5n9GObSn8AfOt9AZcG4.ZQRl7qyk__ NI3Bh18Up0m3BnSzr5SNArwU17F4YALgSFqcSBCeDTAMbOL__kmq8v8xnc76KOhhA3MqXexory.2 HuH0gzWWE.6kukz8hmNRey5Ti4.EfYh1ZMYGxe7UA6igxp5WfB48wYY.wPAuJ2CCqPKqnXHMz0h9 2aBoqiVqBr10rzrSwkP2wWOPx_9RAIvNP.wyJ4HqAVNEbAzi6eCtMNTuiSJcw8.Rmsxg_gXfkJsG 8hrrORCHDcAADZUYvEBXDcnHsZvc0RuOLv6aepPzLmAQJw4QzJXax3pBmFxFAcSlHVstgNb1NmeN rIlGgXgp7HVfNdeCtiVavWuUc.oZibfjrjNYtPZP.1sxiy1h_qFqa5pmtgFyz7b28BgOEozh4Vne wl9igC7xLlIo8WZF5fUZ2a84uB25UWOwFtAU1sak5rdJ46Z_mwruZuJcYE1wbLdW_QXF5a6ekhSk 0v8hF5KxOokhPioNiR_hLsJiE0Ze092VPXpAlCP.FhCf442Z2VHuIOJGjYIo.Up4cH80VJw8aAiN OQL96mJ8RvwjGYQcSVyKSKLx6aK40H7EpoYdrHZqdaX1cRpvCt9Uhnf8BRpvMC3TYqs5ZQXgeaGL 0oZmt.FDf7HlVJB2MGrHbiabIt78g Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.ir2.yahoo.com with HTTP; Sun, 17 Jan 2021 13:19:45 +0000 Date: Sun, 17 Jan 2021 13:19:41 +0000 (UTC) To: Andrew Burgess Message-ID: <2060671008.4946685.1610889581434@mail.yahoo.com> In-Reply-To: <20210117113102.GM265215@embecosm.com> References: <20201229170227.821-1-ssbssa@yahoo.de> <20201229170227.821-2-ssbssa@yahoo.de> <20210115164811.GK265215@embecosm.com> <20210117113102.GM265215@embecosm.com> Subject: Re: [PATCH 2/4] Return true in TuiWindow.is_valid only if TUI is enabled MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.17501 YMailNorrin Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:76.0) Gecko/20100101 Firefox/76.0 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Hannes Domani via Gdb-patches Reply-To: Hannes Domani Cc: Tom Tromey , "gdb-patches@sourceware.org" Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Am Sonntag, 17. Januar 2021, 12:31:05 MEZ hat Andrew Burgess Folgendes geschrieben: > After further though I think there's an even better solution for this > issue.=C2=A0 See the patch below. This version crashes for me when I disable and then re-enable TUI, because tui_windows and tui_win_list are empty, not filled again in tui_enable, and= the tui_update_gdb_sizes call at the end of tui_enable dereferences TUI_CMD_WIN= . Also, and I think your previous patch behaves the same, but I can no longer= use the TuiWindows variables width/height/title inside my Window.close function= , because at this point tui_active=3D=3Dfalse, so the assertion inside is_val= id fails. This can be worked around by saving the values in some Window class members= , but it is more inconvenient. Hannes