From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5162 invoked by alias); 15 Oct 2012 18:03:28 -0000 Received: (qmail 5149 invoked by uid 22791); 15 Oct 2012 18:03:26 -0000 X-SWARE-Spam-Status: No, hits=-5.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-la0-f73.google.com (HELO mail-la0-f73.google.com) (209.85.215.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 15 Oct 2012 18:03:23 +0000 Received: by mail-la0-f73.google.com with SMTP id b11so331474lam.0 for ; Mon, 15 Oct 2012 11:03:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:content-type:content-transfer-encoding:message-id:date :to:cc:subject:in-reply-to:references:x-mailer:from :x-gm-message-state; bh=K2rjCrOKbrCCx6dzt7SHUmPJwum9v+CCcwuGgKYBV+E=; b=d3AXBKXBmAsnuhd+17FE8LLKuNZ1d1QAFNSBfBcbariqUDJx6jJ6kMQUtLltA1U8re msQlHyw4Skp/r8AUPt6tbQ2NGlwxWNewBfAWIFdut56tkzy+dGE7H5GsQ/3wURRmFA7v qJN687MlsPeIHf2aycd53p4mGCiM1jNQ7uCPxQp4dTkel6yoFjG5mqpHkk0Gkas75kBT JlG+m44ArSW5Ms09v6pmVMctoNeOK/6uZ+VzJXq952SuqKgVRE2+NcMZ4RUwNS/H0KVk MzVsZiqMX/1YRJKk9jwzbG6A7GAJBoHBy7cmA9wwSvmgQc8esJV+JLKzoAjD5rETD4Q+ Q/AA== Received: by 10.180.94.98 with SMTP id db2mr2884279wib.2.1350324201521; Mon, 15 Oct 2012 11:03:21 -0700 (PDT) Received: from hpza9.eem.corp.google.com ([74.125.121.33]) by gmr-mx.google.com with ESMTPS id ci6si764095wib.3.2012.10.15.11.03.21 (version=TLSv1/SSLv3 cipher=AES128-SHA); Mon, 15 Oct 2012 11:03:21 -0700 (PDT) Received: from ruffy2.mtv.corp.google.com (ruffy2.mtv.corp.google.com [172.17.128.107]) by hpza9.eem.corp.google.com (Postfix) with ESMTP id 6615B5C0050; Mon, 15 Oct 2012 11:03:20 -0700 (PDT) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <20604.20455.105300.495734@ruffy2.mtv.corp.google.com> Date: Mon, 15 Oct 2012 18:03:00 -0000 To: Yao Qi Cc: Subject: Re: [PATCH 2/2] new tracepoint downloaded MI notification. In-Reply-To: <1348793347-12556-3-git-send-email-yao@codesourcery.com> References: <1348793347-12556-1-git-send-email-yao@codesourcery.com> <1348793347-12556-3-git-send-email-yao@codesourcery.com> From: dje@google.com X-Gm-Message-State: ALoCoQmEzxyhBoHUkKRDs4qqmKO85ejZ3DG8Xcwh1d/9GVZcCzdcjjkn1zIFMU+ylOC77nBDAdEiW7tssP2WViRbjImRwenGYgOI1wQRoyZIMuvVb532f1OdwOmVlTPadqtAocFEJzvkdpPsJcWv0a2tGMswFuOjNKxTFPnvjODCUNJmCHgWfNA34UjaFiKMyMAW/dnoAPJCSSUcGdz+PhTztAz6foYw7w== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00227.txt.bz2 Yao Qi writes: > Hi, > This patch is to add a new MI notification to MI front-end when > tracepoints are downloaded to target. > > gdb: > > 2012-09-27 Yao Qi > > * target.c: Include "observer.h". > (target_download_tracepoint): New. > * target.h (target_download_tracepoint): Remoe macro. > Declare target_download_tracepoint. > * mi/mi-interp.c (mi_interpreter_init): > (mi_tracepoint_downloaded): New. > * observer.sh (struct bp_location): Forward declaration. > > * NEWS: Mention it. > > gdb/doc: > > 2012-09-27 Yao Qi > > * observer.texi (GDB Observers): New observer > 'tracepoint-downloaded'. > * gdb.texinfo (GDB/MI Async Records): Document for MI notification > "=tracepoint-downloaded". > > gdb/testsuite: > > 2012-09-27 Yao Qi > > * gdb.trace/mi-traceframe-changed.exp (test_tfind_remote): Adjust. > * gdb.trace/mi-tracepoint-downloaded.exp: New. Hi. It would be useful if the reason why this notification exists was specified in the code. E.g, "This notification exists because frontends ... [fill in the blank]."