From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24553 invoked by alias); 15 Oct 2012 17:41:38 -0000 Received: (qmail 24542 invoked by uid 22791); 15 Oct 2012 17:41:35 -0000 X-SWARE-Spam-Status: No, hits=-5.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-qc0-f201.google.com (HELO mail-qc0-f201.google.com) (209.85.216.201) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 15 Oct 2012 17:41:30 +0000 Received: by mail-qc0-f201.google.com with SMTP id a6so637580qch.0 for ; Mon, 15 Oct 2012 10:41:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:content-type:content-transfer-encoding:message-id:date :to:cc:subject:in-reply-to:references:x-mailer:from :x-gm-message-state; bh=YNJNj5l81nfBC8zCqRHhoXJ43Xs/3h4iPBfy32xS5AA=; b=GtVmUPZFFOPAQiMqPF5z/IORzozOCUTTh3dhNmpJPMY/tmVQRYftNUzm7O/8fapyIo 8bum3XPkv/c4d0AcmuMn9rVDmG0t/rF7+VuZI+lYb2nGmYwCh1seqYVkDKzXNDQHDxdT OxfNqZnZ6ijL815vLl+524j4ovoBJPNb4jea8u2PHHHvfrZ2QGewQQI88wHmt50incmO D1i61yeatTo/svMFKh9xLlt+SVo/pE3ZASIDhKbXTPk3NKoJtCSFi86MBQG0QbfgtLck A0lKdwruhQ5+74M+avrF+C9WhsDzaoiHRDKGnnwFhdOE/ZiK8JlULNPKaojWz7nwP7PB rGZw== Received: by 10.236.57.7 with SMTP id n7mr9507202yhc.41.1350322889540; Mon, 15 Oct 2012 10:41:29 -0700 (PDT) Received: from wpzn4.hot.corp.google.com (216-239-44-65.google.com [216.239.44.65]) by gmr-mx.google.com with ESMTPS id g7si691020anp.1.2012.10.15.10.41.29 (version=TLSv1/SSLv3 cipher=AES128-SHA); Mon, 15 Oct 2012 10:41:29 -0700 (PDT) Received: from ruffy2.mtv.corp.google.com (ruffy2.mtv.corp.google.com [172.17.128.107]) by wpzn4.hot.corp.google.com (Postfix) with ESMTP id 0FA621E0048; Mon, 15 Oct 2012 10:41:28 -0700 (PDT) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <20604.19144.405313.95372@ruffy2.mtv.corp.google.com> Date: Mon, 15 Oct 2012 17:41:00 -0000 To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: Regression for gdb.base/stap-probe.exp (and some others) [Re: [patch] Have gdb_breakpoint call pass] In-Reply-To: <20121012070149.GA5873@host2.jankratochvil.net> References: <20121012070149.GA5873@host2.jankratochvil.net> From: dje@google.com X-Gm-Message-State: ALoCoQk3GBdzDAih1Sw41UiKUHfF2lEXCf4t/Af/iWW3B7ZaJqHgRG7AH/zF7toixSAkKe+H6Bn44z5i7Sbsch734mnpViMC8ltXziCgezPzhcIlSWb5lP7LumAocJmIWRael+z93C4GBjig6q6OpLqXfB8thUE7g0b5YtzE3ALuRMlLNb7QnEcsniMPWHwif34LZp29gwuNpzSvQyGM7n88Xf+RAyQu/w== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00224.txt.bz2 Jan Kratochvil writes: > On Mon, 01 Oct 2012 18:49:21 +0200, dje@google.com wrote: > > 2012-10-01 Doug Evans > > > > * lib/gdb.exp (gdb_breakpoint): Fix varargs scan. > > Recognize "message" -> print pass and fail. Add eof case. > > (runto): Recognize message, no-message. Print pass/fail if requested, > > with same treatment as gdb_breakpoint. > > (runto_main): Pass no-message to runto. > > (gdb_internal_error_resync): Add log message. > > (gdb_file_cmd): Tweak internal error fail text for consistency. > > Running gdb/testsuite/gdb.base/stap-probe.exp ... > PASS: gdb.base/stap-probe.exp: without semaphore, not optimized: check argument not at probe point > PASS: gdb.base/stap-probe.exp: without semaphore, not optimized: info probes stap > -PASS: gdb.base/stap-probe.exp: without semaphore, not optimized: run to -pstap test:user > +FAIL: gdb.base/stap-probe.exp: without semaphore, not optimized: run to -pstap test:user > [...] > (many of PASS->FAIL for gdb.base/stap-probe.exp) This test doesn't run on the ubuntu box I was testing on, but oh well. This patch fixes stap-probe.exp on the Fedora box I tested on. I didn't test jmisc.exp but it is likely the same issue. Committed. 2012-10-15 Doug Evans * lib/gdb.exp (runto): Fix call to gdb_breakpoint. Index: gdb.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v retrieving revision 1.219 diff -u -p -r1.219 gdb.exp --- gdb.exp 11 Oct 2012 15:59:57 -0000 1.219 +++ gdb.exp 15 Oct 2012 17:33:54 -0000 @@ -460,7 +460,10 @@ proc runto { function args } { # We need to use eval here to pass our varargs args to gdb_breakpoint # which is also a varargs function. - if ![eval gdb_breakpoint $function $args] { + # But we also have to be careful because $function may have multiple + # elements, and we don't want Tcl to move the remaining elements after + # the first to $args. That is why $function is wrapped in {}. + if ![eval gdb_breakpoint {$function} $args] { return 0; }