From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126926 invoked by alias); 14 Jun 2016 19:08:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 126895 invoked by uid 89); 14 Jun 2016 19:07:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=H*F:D*freebsd.org, H*M:baldwin, HX-Greylist:0400, HX-Greylist:EDT X-Spam-User: qpsmtpd, 2 recipients X-HELO: bigwig.baldwin.cx Received: from bigwig.baldwin.cx (HELO bigwig.baldwin.cx) (96.47.65.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Tue, 14 Jun 2016 19:07:58 +0000 Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 6B3D7B997; Tue, 14 Jun 2016 15:07:56 -0400 (EDT) From: John Baldwin To: Yao Qi Cc: "gdb-patches@sourceware.org" , binutils@sourceware.org Subject: Re: [PATCH 5/8] Detect a frameless frame by comparing the FP register to -1. Date: Tue, 14 Jun 2016 19:08:00 -0000 Message-ID: <2059915.yo7jaW82vP@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.3-STABLE; KDE/4.14.3; amd64; ; ) In-Reply-To: References: <1465678115-58170-1-git-send-email-jhb@FreeBSD.org> <1465678115-58170-6-git-send-email-jhb@FreeBSD.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00257.txt.bz2 On Monday, June 13, 2016 12:22:41 PM Yao Qi wrote: > On Sat, Jun 11, 2016 at 9:48 PM, John Baldwin wrote: > > > > - if (cache->saved_regs[MEDIA_FP_REGNUM] >= 0) > > + if (cache->saved_regs[MEDIA_FP_REGNUM] == -1) > > cache->uses_fp = 1; > > I suspect it should be " != -1". saved_regs[MEDIA_FP_REGNUM] is initialized > to -1, so if it is not the initialized value (-1), FP should be set in > the prologue, and mark the flag uses_fp. Yes, you are correct. Alternatively, we could change this code to explicitly set 'cache->uses_fp' in the cases earlier in this function where it sets MEDIA_FP_REGNUM to a value. sh-tdep.c follows this model, but it only needs to set uses_fp in a few places. -- John Baldwin