From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23180 invoked by alias); 24 Aug 2012 19:00:12 -0000 Received: (qmail 23097 invoked by uid 22791); 24 Aug 2012 19:00:10 -0000 X-SWARE-Spam-Status: No, hits=-5.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-ey0-f201.google.com (HELO mail-ey0-f201.google.com) (209.85.215.201) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 24 Aug 2012 18:59:57 +0000 Received: by eabm6 with SMTP id m6so101710eab.0 for ; Fri, 24 Aug 2012 11:59:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:content-type:content-transfer-encoding:message-id:date :to:cc:subject:in-reply-to:references:x-mailer:from :x-gm-message-state; bh=uYVaOxsjNQEKzwEnOc01NswRRtWKU9o2KsXYdL4lN8o=; b=fzXqfew4LeUyIZYEwQIsbCAPUikDLWl+Ti0ETo5DhnSYjkZEzXXphUYrMvicmaoVnr B3CoeUCjDZXZUh0QYA+H33ndxPckr0evR3bXsBgecZtTwDEKvBbNEKr7sM7l9Nzs7uLx p7Cq55+98w3SbCK2zsbrUVgk/lqHnVM6vE8nxjxgYKdQLqpwYn88IysGr46iDuvFwnd+ IcVGQUYZw1+l944dTjoqwFm9YmiijpWvoHTyckHUiFaXZ9mkuzoM6CPxPGcoaSJXgKng unJdM4qvhD77y22Lj/apCZ8EXC7GljlD6IvOwUikdjngYVUaGat8kUAeegLPfjzyjo5+ vBzQ== Received: by 10.216.193.26 with SMTP id j26mr352524wen.1.1345834796124; Fri, 24 Aug 2012 11:59:56 -0700 (PDT) Received: by 10.216.193.26 with SMTP id j26mr352521wen.1.1345834796056; Fri, 24 Aug 2012 11:59:56 -0700 (PDT) Received: from hpza9.eem.corp.google.com ([74.125.121.33]) by gmr-mx.google.com with ESMTPS id fa8si34122wid.1.2012.08.24.11.59.56 (version=TLSv1/SSLv3 cipher=AES128-SHA); Fri, 24 Aug 2012 11:59:56 -0700 (PDT) Received: from ruffy2.mtv.corp.google.com (ruffy2.mtv.corp.google.com [172.18.110.129]) by hpza9.eem.corp.google.com (Postfix) with ESMTP id CC3165C006F; Fri, 24 Aug 2012 11:59:54 -0700 (PDT) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <20535.53033.569482.293453@ruffy2.mtv.corp.google.com> Date: Fri, 24 Aug 2012 19:00:00 -0000 To: Yao Qi Cc: Subject: Re: [PATCH 2/4] de-couple %Stop from notification: gdb In-Reply-To: <1345775139-13576-3-git-send-email-yao@codesourcery.com> References: <1345775139-13576-1-git-send-email-yao@codesourcery.com> <1345775139-13576-3-git-send-email-yao@codesourcery.com> From: dje@google.com X-Gm-Message-State: ALoCoQnBGKesMefPtZ7Os0DYpdZkUufyynpyfgWLFVoWcH4qYG/rR1/1Br8eYl3hYA4lXE/BsOMjz6einkDC6VmnBWzb0bQsncmTm1Yib5iHSvl3+mRCEwod1Jk+8OOl1OUbE0JumjnJ6hfK1OGHjBfsaSOtPRopJs7fotPb/q81y8Qu1ySM+rZx3CmMemAwXWGMNV9+gqIdL+gKDVocigZKZQLtsmMMoQ== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00770.txt.bz2 Yao Qi writes: > This patch is to de-couple vStopped/%Stop from notification in gdb side. Hi. Just a few nits, maybe more to follow. > gdb: > > 2012-08-24 Yao Qi > > (struct remote_state): Move to remote.h. What's the reason for moving struct remote_state to remote.h? [I did a simple grep and couldn't find a reason, I could have missing something of course.] Having it live in remote.c means the implementation is "private" to just that file. > diff --git a/gdb/remote-notif.c b/gdb/remote-notif.c > new file mode 100644 > index 0000000..ca7f821 > --- /dev/null > +++ b/gdb/remote-notif.c > @@ -0,0 +1,285 @@ > [...] > + > +extern struct remote_state *get_remote_state (void); Don't declare external functions in .c files, it should live in a header.