From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13729 invoked by alias); 1 Aug 2012 19:30:13 -0000 Received: (qmail 13717 invoked by uid 22791); 1 Aug 2012 19:30:12 -0000 X-SWARE-Spam-Status: No, hits=-4.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-ob0-f201.google.com (HELO mail-ob0-f201.google.com) (209.85.214.201) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 01 Aug 2012 19:29:55 +0000 Received: by obbun3 with SMTP id un3so5150357obb.0 for ; Wed, 01 Aug 2012 12:29:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:content-type:content-transfer-encoding:message-id:date :to:cc:subject:in-reply-to:references:x-mailer:from :x-gm-message-state; bh=8lbvGq1eBd9m5QkTTM/bC97LmFZ61+a1A3oVcJwAbXA=; b=a0EHeDSItr5cLoQP8eU9acyYoLTot0TtMs/0G4qo/I1wM5VWGY38pW4+/c10gOumgU lUk9KY5KNwOmY6EfA1j2vCxc2CHXui6GKvdPsxzULlmbeLZQl/c2NVVxUEdgdINGe1Er SGk3PQ4i7aV3bdKsH14ageeYGZdwQOHNCm6KFpGYvXXZ6C4hJ4d6R2Bu5xSxB+/5EJ8p bXI7LCffVFMA/BlFwL/BQWU/r6voM2rj+wrlrOaVfDq9A4vJSMjUTVRY/EdLgSjl8IhV LwmSB6Z7UL+xU/nw5oNunVPHbC25tfqoMW/ff8fDF18g/6zpWaOwAfuGWO6iZj6C/2EK DTZA== Received: by 10.42.250.75 with SMTP id mn11mr125725icb.12.1343849394524; Wed, 01 Aug 2012 12:29:54 -0700 (PDT) Received: by 10.42.250.75 with SMTP id mn11mr125717icb.12.1343849394415; Wed, 01 Aug 2012 12:29:54 -0700 (PDT) Received: from wpzn4.hot.corp.google.com (216-239-44-65.google.com [216.239.44.65]) by gmr-mx.google.com with ESMTPS id b6si1630829igp.1.2012.08.01.12.29.54 (version=TLSv1/SSLv3 cipher=AES128-SHA); Wed, 01 Aug 2012 12:29:54 -0700 (PDT) Received: from ruffy2.mtv.corp.google.com (ruffy2.mtv.corp.google.com [172.18.110.129]) by wpzn4.hot.corp.google.com (Postfix) with ESMTP id 2D7CE1E0043; Wed, 1 Aug 2012 12:29:53 -0700 (PDT) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <20505.33712.542750.969953@ruffy2.mtv.corp.google.com> Date: Wed, 01 Aug 2012 19:30:00 -0000 To: Sergio Durigan Junior Cc: Andreas Schwab , Pedro Alves , gdb-patches@sourceware.org, ratmice@gmail.com Subject: Re: [RFA] massively speed up "info var foo" on large programs In-Reply-To: References: <20120524175852.D38381E139C@ruffy2.mtv.corp.google.com> <4FBF47DD.4030100@redhat.com> <4FC91A33.5040900@redhat.com> <4FCCCE27.2060804@redhat.com> <20502.50281.392575.922986@ruffy2.mtv.corp.google.com> From: dje@google.com X-Gm-Message-State: ALoCoQmn1k5agivRkmbOtkJFh01ijpjhCFjDyip3M2vN7mGUnss9EJEYpiZABSZT4Um4YZFIEgsaka4ubmCT5cC5guJNUQKJM68SH5yhTfVfsMqaBmWYOfbF/SG5tW9O24Kamds5m7hAI59/V5xPJnN8qY+iADQSYYKj4h1X1beiCX1J6XBV7RBqgrWUjg83Bdxx1bdT5Y1G X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00032.txt.bz2 Sergio Durigan Junior writes: > On Tuesday, July 31 2012, I wrote: > > > I have just tested your patch on ppc64 and it works OK; I don't have a > > s390x machine right now but I'll check tomorrow when I wake up. > > FWIW the patch also works OK on s390x RHEL 6.3. > > -- > Sergio Thanks. How about this? I will check it into cvs head and 7.5 in a few days if there are no objections. 2012-08-01 Doug Evans * gdb.base/info-fun.exp: Fix failures on m68k, ppc64, s390x. Index: info-fun.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/info-fun.exp,v retrieving revision 1.2 diff -u -p -r1.2 info-fun.exp --- info-fun.exp 21 Jun 2012 20:46:22 -0000 1.2 +++ info-fun.exp 1 Aug 2012 18:34:44 -0000 @@ -67,9 +67,17 @@ foreach libsepdebug {NO IN SEP} { with_t append match_str {int foo\(void\);[\r\n]*} } append match_str {Non-debugging symbols:[\r\n]*} + # Note: Targets like {m68k,ppc64,s390x}-linux also have, e.g., + # 00000011.plt_call.foo+0 (m68k). + set plt_foo_match "($hex \[^\r\n\]*plt\[^\r\n\]*foo\[^\r\n\]*\[\r\n\]*)?" + append match_str $plt_foo_match + # This text we want to match precisely. append match_str "$hex *foo(@plt)?\[\r\n\]*" + # Watch for again to not have to worry about the order of appearance. + append match_str $plt_foo_match if { "$libsepdebug" == "NO" } { - append match_str "$hex *foo\[\r\n\]*" + # Note: The ".?" is for targets like m68k-linux that have ".foo" here. + append match_str "$hex *.?foo\[\r\n\]*" } gdb_test "info fun foo" "$match_str"