From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3411 invoked by alias); 15 Aug 2007 20:52:10 -0000 Received: (qmail 2864 invoked by uid 22791); 15 Aug 2007 20:52:05 -0000 X-Spam-Check-By: sourceware.org Received: from a.mail.sonic.net (HELO a.mail.sonic.net) (64.142.16.245) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 15 Aug 2007 20:52:01 +0000 Received: from webmail.sonic.net (b.webmail.sonic.net [64.142.100.148]) by a.mail.sonic.net (8.13.8.Beta0-Sonic/8.13.7) with ESMTP id l7FKpiCh009034; Wed, 15 Aug 2007 13:51:44 -0700 Received: from 12.7.175.2 (SquirrelMail authenticated user msnyder) by webmail.sonic.net with HTTP; Wed, 15 Aug 2007 13:51:44 -0700 (PDT) Message-ID: <20463.12.7.175.2.1187211104.squirrel@webmail.sonic.net> In-Reply-To: <200708150652.l7F6qPEL009472@brahms.sibelius.xs4all.nl> References: <22565.12.7.175.2.1187137125.squirrel@webmail.sonic.net> <200708150652.l7F6qPEL009472@brahms.sibelius.xs4all.nl> Date: Wed, 15 Aug 2007 20:52:00 -0000 Subject: Re: [OB] tui, coding standard From: msnyder@sonic.net To: "Mark Kettenis" Cc: msnyder@sonic.net, gdb-patches@sourceware.org User-Agent: SquirrelMail/1.4.9a MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00320.txt.bz2 >> Date: Tue, 14 Aug 2007 17:18:45 -0700 (PDT) >> From: msnyder@sonic.net >> >> && and || operators. > > This diff wraps some lines that fit perfectly well on a single line; I > think you shouldn't do that. Otherwise, this looks ok. OK, maybe I was a little gung ho. Do you have an idea, for yourself, of what constitutes a line that is too long? Michael