From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91940 invoked by alias); 14 Sep 2018 21:27:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91928 invoked by uid 89); 14 Sep 2018 21:27:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=1.0 required=5.0 tests=BAYES_20,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy=sk:3c025cf, filestuff.c, UD:filestuff.c, filestuffc X-HELO: idris.smile.fr Received: from idris.smile.fr (HELO idris.smile.fr) (91.216.209.19) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 14 Sep 2018 21:27:48 +0000 Received: from localhost (localhost [127.0.0.1]) by idris.smile.fr (Postfix) with ESMTP id 65FB21EE27A8; Fri, 14 Sep 2018 23:27:46 +0200 (CEST) Received: from idris.smile.fr ([127.0.0.1]) by localhost (bluemind-mta.prod.vitry.intranet [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0RusFPdPqOiL; Fri, 14 Sep 2018 23:27:46 +0200 (CEST) Received: from [192.168.1.17] (LFbn-1-477-200.w86-245.abo.wanadoo.fr [86.245.183.200]) by idris.smile.fr (Postfix) with ESMTPSA id 3B2BF1EE27A5; Fri, 14 Sep 2018 23:27:46 +0200 (CEST) Subject: Re: [PATCH] Move 'is_regular_file' from common-utils.c to filestuff.c To: Sergio Durigan Junior , Pedro Alves Cc: GDB Patches , Rich Felker , Thomas Petazzoni , Romain Naour References: <20180912173113.2007-1-sergiodj@redhat.com> <6ee45c62-9bb6-c41a-b76e-0a9bf9c2c281@redhat.com> <874leulhqt.fsf@redhat.com> From: Romain Naour Message-ID: <203b1739-3418-2aa4-c40e-c2e63e717297@smile.fr> Date: Fri, 14 Sep 2018 21:27:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <874leulhqt.fsf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2018-09/txt/msg00465.txt.bz2 Hi All, Le 12/09/2018 à 19:59, Sergio Durigan Junior a écrit : > On Wednesday, September 12 2018, Pedro Alves wrote: > >> On 09/12/2018 06:31 PM, Sergio Durigan Junior wrote: >> >>> The most simple fix for this problem is to move 'is_regular_file' to >>> 'filestuff.c', which is not used by IPA. This ends up making the >>> files more logically organized as well, since 'is_regular_file' is a >>> file operation. >>> >>> No regressions found. >>> >>> gdb/ChangeLog: >>> 2018-09-12 Sergio Durigan Junior >>> >>> * common/common-utils.c: Don't include ''. >>> (is_regular_file): Move to... >>> * common/filestuff.c (is_regular_file): ... here. >>> * common/common-utils.h (is_regular_file): Move to... >>> * common/filestuff.h (is_regular_file): ... here. >> >> OK. > > Thanks, pushed. Thanks for the patch! It should be backported to 8.1.1 and 8.2 release. Best regards, Romain > > 3c025cfe5efc44eb4dfb03b53dca28e75096dd1e >