From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13048 invoked by alias); 21 Mar 2019 21:29:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13037 invoked by uid 89); 21 Mar 2019 21:29:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:456, boiler X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Mar 2019 21:29:47 +0000 Received: from [172.16.0.89] (192-222-157-41.qc.cable.ebox.net [192.222.157.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 2C1021E4A5; Thu, 21 Mar 2019 17:29:45 -0400 (EDT) Subject: Re: [PATCH v2 0/8] Support for AArch64 Pointer Authentication To: Alan Hayward , GDB Patches Cc: nd References: <20190306133325.2531-1-alan.hayward@arm.com> From: Simon Marchi Message-ID: <2038ae4a-ae0f-4104-d45b-47162d1fad44@simark.ca> Date: Thu, 21 Mar 2019 21:29:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2019-03/txt/msg00474.txt.bz2 On 2019-03-14 8:34 a.m., Alan Hayward wrote: > Ping for this. > Hopefully most of this is just standard boiler plate code, with detailed > bits in the two unwinder patches, and some common code changes in the > gdbserver patch. Hi Alan, The common gdbserver part looks good to me. I glanced over the rest, and it looks good to me as well, I sent some minor comments on a few patches. Simon