From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105639 invoked by alias); 20 Jul 2016 18:18:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 105625 invoked by uid 89); 20 Jul 2016 18:18:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=vip, VIP, evans, Evans X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 20 Jul 2016 18:18:56 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4DC12C05AA48; Wed, 20 Jul 2016 18:18:55 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u6KIIfCs017443; Wed, 20 Jul 2016 14:18:54 -0400 Subject: Re: [PATCH 4/5]: Enhancements to "flags": i386 cleanup To: Doug Evans , gdb-patches@sourceware.org References: <047d7b5dbb865204bd052cf0bc2b@google.com> Cc: cole945@gmail.com From: Pedro Alves Message-ID: <2026a39c-0b53-9142-74ce-091bc73832d8@redhat.com> Date: Wed, 20 Jul 2016 18:18:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <047d7b5dbb865204bd052cf0bc2b@google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-07/txt/msg00227.txt.bz2 Hi Doug, On 02/29/2016 11:09 PM, Doug Evans wrote: > Hi. > > This patch just simplifies things by removing the "end" spec in > i386 eflags definitions, and is otherwise a nop. > > I removed them because they're redundant. > I noticed that this makes older gdbs reject the new target descriptions. E.g., gdb 7.11.1 against master gdbserver: Remote debugging using :9999 warning: while parsing target description (at line 24): Field "CF" has neither type nor bit position warning: Could not load XML target description; ignoring Reverting the patch makes old gdb grok the tdesc again (git revert 49b7ae7bb8f2). Since it was meant as a cleanup, I think we should revert it on grounds of avoiding a back compatibility break. WDYT? Thanks, Pedro Alves > 2016-02-29 Doug Evans > > * features/i386/32bit-core.xml (i386_eflags): Remove "end" spec. > * features/i386/32bit-sse.xml (i386_eflags): Ditto. > * features/i386/64bit-core.xml (i386_eflags): Ditto. > * features/i386/64bit-sse.xml (i386_eflags): Ditto. > * features/i386/x32-core.xml (i386_eflags): Ditto. > > diff --git a/gdb/features/i386/32bit-core.xml > b/gdb/features/i386/32bit-core.xml > index a27863f..b00d913 100644 > --- a/gdb/features/i386/32bit-core.xml > +++ b/gdb/features/i386/32bit-core.xml > @@ -8,23 +8,23 @@ > > > > - > - > - > - > - > - > - > - > - > - > - > - > - > - > - > - > - > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > > > > diff --git a/gdb/features/i386/32bit-sse.xml > b/gdb/features/i386/32bit-sse.xml > index 5a44d1e..4448a7e 100644 > --- a/gdb/features/i386/32bit-sse.xml > +++ b/gdb/features/i386/32bit-sse.xml > @@ -23,20 +23,20 @@ > > > > - > - > - > - > - > - > - > - > - > - > - > - > - > - > + > + > + > + > + > + > + > + > + > + > + > + > + > + > > > > diff --git a/gdb/features/i386/64bit-core.xml > b/gdb/features/i386/64bit-core.xml > index 92f4e87..6e847c1 100644 > --- a/gdb/features/i386/64bit-core.xml > +++ b/gdb/features/i386/64bit-core.xml > @@ -8,23 +8,23 @@ > > > > - > - > - > - > - > - > - > - > - > - > - > - > - > - > - > - > - > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > > > > diff --git a/gdb/features/i386/64bit-sse.xml > b/gdb/features/i386/64bit-sse.xml > index 2a5271e..dd6a850 100644 > --- a/gdb/features/i386/64bit-sse.xml > +++ b/gdb/features/i386/64bit-sse.xml > @@ -23,20 +23,20 @@ > > > > - > - > - > - > - > - > - > - > - > - > - > - > - > - > + > + > + > + > + > + > + > + > + > + > + > + > + > + > > > > diff --git a/gdb/features/i386/x32-core.xml > b/gdb/features/i386/x32-core.xml > index ab51ffc..c03cdea 100644 > --- a/gdb/features/i386/x32-core.xml > +++ b/gdb/features/i386/x32-core.xml > @@ -8,23 +8,23 @@ > > > > - > - > - > - > - > - > - > - > - > - > - > - > - > - > - > - > - > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > > >