From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yTbHOZEv4mpxpj4AWB0awg (envelope-from ) for ; Wed, 28 Oct 2026 13:23:29 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=R4+GCa8c; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E61951E007; Wed, 28 Oct 2026 13:23:29 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1AE851E007 for ; Wed, 28 Oct 2026 13:23:29 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 506164BA2E29 for ; Wed, 28 Oct 2026 17:23:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 506164BA2E29 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=R4+GCa8c Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [IPv6:2607:f8b0:4864:20::336]) by sourceware.org (Postfix) with ESMTPS id 746ED4BA2E07 for ; Wed, 28 Oct 2026 17:23:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 746ED4BA2E07 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 746ED4BA2E07 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::336 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1793208185; cv=none; b=ApTrrRxHHel+LgJr63r7a2KmBdq9jo/fRaGzbe/7OaOwGaBEqH+U+OpkDAm5XiMfp3F7EyLm4ShaeVamQyUThHqEFOzXFfrKoqZ1oWpy2qzE6reBmCGaKhsDGPOa7Dm4VcH3r9B084jjW3XyD4JX4js0jskEhGuvLMp4DmXmdJM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1793208185; c=relaxed/simple; bh=HGQkf3Q0Ybf1X82D6/VmKjInmNOX/5xT0QJBLyiO/j8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=UrvSkAY5NPnwa2y7aF39QtJu/c8Qetf7l+cJ5WOkM9ugZY9jN/z2LMQkavVMIi7GWoZV9t4tQmCE0wob2sCeXODuMY5nEIx2I1RwgfTCvFzz/tvKgdwS/DGW/uFs4EeJW1GzcTtepj4LxeFfplHzAkz0qq+Lw8t2gkhK+Q8Ts40= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=R4+GCa8c DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 746ED4BA2E07 Received: by mail-ot1-x336.google.com with SMTP id 46e09a7af769-7f84a55cc06so667495a34.2 for ; Wed, 28 Oct 2026 10:23:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1793208184; x=1793812984; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=CIdjqUudlxAtjTqJzva3VYJI+LepiwHZn3qK+whKof4=; b=R4+GCa8ck3l60JdAXHXF9LimEEyNqcXpuNJwie+Udcvq8XjzCmtupg1E7v3aKrxI+3 E1XfgLyKJUeo/dhFdogDaOBgx1yAxD9VgdIn+Y7lvaLqglYwWrtO4aoKFUaBOgPORo6Q g2kDYrDCaq+jV3QmB9Io9lvaaNzLt9CjsI8r2wgEyZdLw4yQKLvgUfLGC5A86N1q2QFJ QxBnyLLiL75YvAFhcEmNTQUZ1wGvXk/ePp+1Ny5klVxflgx+rB0zK97yerVlQMcCx1ae 1QBxnCbOeWziS4qjEzyVU8yz8ivrlhrMTD3bxFLVr67QJHJ9NqoI/wJ8OURUe1r6zCU4 7+gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793208184; x=1793812984; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=CIdjqUudlxAtjTqJzva3VYJI+LepiwHZn3qK+whKof4=; b=p0OdSewbTCM8FfDM+5sIvF3TAGeT34cpzv8EIVANWXra9W2lZ5knKWJHIITI0dv62O lZRO0PvSJygV8zdiA4N4R+e+yBMlMQu5dp6n8xD09F5wJmrvxLP0+MgwuV1Vut8lQDJi YkJE0W/AvxlmDoYphmHC/mWanbU2LYmLeUnRWxoMoivcRTjFpjaWYyqd45yXWJxUxL2q KT5yFxYwXioFSKqO7gvXwD5IgipQ1uz9/w670V/ZeW3vTcpmKY7iQo/V+uOgDqyR0k6e MwhBWgeC9qMlhlxquKgAkFuxJI/sAdIc9zeh2pv1n33uMOOUKHN6nf1p9rVcg5zIE6EA Hmqw== X-Gm-Message-State: AFq9FYJp9vlGNArodZjkqiBFqBT4Xtn5z1QUhCPfbpUCEtdNSIxD+Ndr xKjlFSo061kblaz3qfd2vgeK5z8AuCI1bx5Q/uw24qeEB9NCzTt6lfR0ywI/QHPRj6biCvlAxqC 3BrTe5w== X-Gm-Gg: AYBFou1od3zKLB5QppnTNAsSYCD7AtMtcCDG2IwsuzNgIURpHcSN8/wbAATg+gmYrXE vbRu+RKpUwJTlO7s1ZYyiYB3qkhw+oQAZXEPFNQkIt0IEGKrwq8VOqQQ/mCgA+V/BubXfCeAMC2 +ld5lyKslYcm2kWRLfFlz8oNT7vSFky1PURby7ARMw5ttSLwHrF+8w1tHDeDoqX5cxDufmI8Bd8 AwXrYTQdOOX0jGu57FtPAm+YvWqljiNIFyRZaNHHzgP0i4lDyvlbMMDgnWCSOx/RGlZIpq9oLTb UwKyZWr7YuMDdWClNGtHx78XPdQNOkTOGRqHvq+DwuXqVnNbU9axcxpFn0uaKRyIb1hr30Mavgv ewI+kMmieJNsNjQp25QMDAqfdSZa6pmpQZUg0Cmie3Z2uROPX07C9Ocz+R68PKTCVVygH8vQT5a Ti52M8azz69caxJSzyZzgLcEyNheTTqNfmk5vpRQyVjHuw5WfAN28oW2rtJrJ4ugJS/ANmywVQT ezpAV7iveqIIu6hAcihFk48sO+qof0eZfDqQATc5iED+WRpX0Qa+uo04+y/H0k2gOYCBChXllh0 zcFn+otyOC4jgY3ZbNIXMW5GH93BNXkyCoOtmgGpdjEWd+tH5xw= X-Received: by 2002:a05:6808:124d:b0:4b2:8d7b:390b with SMTP id 5614622812f47-56382d8a138mr2007239b6e.19.1793208184564; Wed, 28 Oct 2026 10:23:04 -0700 (PDT) Received: from bapiya (97-122-110-129.hlrn.qwest.net. [97.122.110.129]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-4a8b788a09csm2985872fac.10.2026.10.28.10.23.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2026 10:23:03 -0700 (PDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Remove #ifdef from cooked-index-entry.c Date: Wed, 28 Oct 2026 11:23:01 -0600 Message-ID: <20261028172301.1376846-1-tromey@adacore.com> X-Mailer: git-send-email 2.56.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org cooked-index-entry.c has an #ifdef to work around a GCC 7.5.0 bug. However, the workaround just removes a 'constexpr' which is not needed. The constexpr behavior was desirable in the past, but this changed with commit 8cbf7d2a ("gdb/dwarf: remove unnecessary comparison in cooked_index_entry::compare"). This removes the #ifdef and the constexpr. --- gdb/dwarf2/cooked-index-entry.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/gdb/dwarf2/cooked-index-entry.c b/gdb/dwarf2/cooked-index-entry.c index 44b065157b8..c76c263117a 100644 --- a/gdb/dwarf2/cooked-index-entry.c +++ b/gdb/dwarf2/cooked-index-entry.c @@ -47,12 +47,7 @@ int cooked_index_entry::compare (const char *stra, const char *strb, comparison_mode mode) { -#if defined (__GNUC__) && !defined (__clang__) && __GNUC__ <= 7 - /* Work around error with gcc 7.5.0. */ auto munge = [] (char c) -> unsigned char -#else - auto munge = [] (char c) constexpr -> unsigned char -#endif { /* Treat '<' as if it ended the string. This lets something like "func" match "func>". See the "Breakpoints in base-commit: aeed64b39aed57729f66ad51560d8964e8201e6e -- 2.56.0