From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KSC2AfFD4mr71z4AWB0awg (envelope-from ) for ; Wed, 28 Oct 2026 14:50:25 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=fF7zM9+j; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id F3873378003; Wed, 28 Oct 2026 14:50:24 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 28A601E007 for ; Wed, 28 Oct 2026 14:50:24 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 52D744BA23D6 for ; Wed, 28 Oct 2026 18:50:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 52D744BA23D6 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=fF7zM9+j Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) by sourceware.org (Postfix) with ESMTPS id 72DCE4BA2E13 for ; Wed, 28 Oct 2026 18:49:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 72DCE4BA2E13 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 72DCE4BA2E13 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::22d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1793213376; cv=none; b=ktLNHyetpowD6+MO57wcTCXAhmYNQk14T21+Lz6k47LAbG4O/91Ei41ynz5aVFtEjCRazCXlFbdeFCAvWzLIq1OPSfyUp/FNDh8p6kjeLU9v0AF9aMdYNQj8boPe3OtZ+ROiRlO1eUn4qOWC6MnrUxVRXvVLjVeIVYttOTzfo0Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1793213376; c=relaxed/simple; bh=HZfTeH9Iu+ihbP7EE3wb+W4kzmjjAtjXSo7AZpTDK/w=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=bY2oGOPh2+sOVNrdmqSQhd2QTgYqDaRMyfPmFHjgiE/we/Yje9QkxdOf2Nk/ESvH3q9qcEDDQ7fFYWO1WyU4TX4LnhALwDeg/YRyqnJ0qhGu+F8wli4sU9opEozxzZxxfpYTn+5L2yILJscxJOtcrbxQvEjnEN/ZaUdpDi/oBn8= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=fF7zM9+j DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 72DCE4BA2E13 Received: by mail-oi1-x22d.google.com with SMTP id 5614622812f47-53ec9237600so843867b6e.3 for ; Wed, 28 Oct 2026 11:49:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1793213376; x=1793818176; darn=sourceware.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MZc50yCogC85nJtOQJOFAuPOQ6CfvbVc++RP10W0zVE=; b=fF7zM9+jjHJnKGaPCU94Zz645LZJeNz1dwnRcaPNgpcEM+pyZRHXccwdWCGeRGjpbR z94hUGxWDXmHlYtFaNJoI8i7wmFrt5OoadbJFdrGfbgIzKBSBtTEE20P+ox9ykChr1sH k5/aAgtmNGA0YKCAQbhENkP0K235pTtbEXY5vW2xgpcJCgngz7eKzuWewVxlIUNBDwlX EOmv6wCy9AxRYlDy7V1XXdphfazSK3wwR6wSMB1iMk9nvX6Fln49B6GveGDfT83RHAqd MltPaEMI8t8ZkS4vXQPk1jS2yoBplJZ1M1RYTm+ItLI1Nx46LN9QM9hLWsGBCtKo9Mvu M5kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793213376; x=1793818176; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MZc50yCogC85nJtOQJOFAuPOQ6CfvbVc++RP10W0zVE=; b=c4r46SMXi9TiPLUNeO2yt88UoKeQ/XtHvFX4HHFp0G8XLtHHfENdpArRPD3RCL13Px I8mBfaeYqvr54Wg6wOHSbzdsMU+8WXu7c4lGyuqRrWQzmK+o2U+uzJZ5L0qkh9l5zTut 7/P7Gql0cJ1/9JB5P0NCvvTRzrUFt2ZeTCplRQHb/F6ouwhst10irD7O1YsrDk+w+vap EV0RC0WfQVj5+fiAC3SspkEjcwbHkmbr+t7wx5La5sVyZwPtgffkRcJONS5ChZRgmGJ6 fIm9Umdhow7O4U62cWa1TNcpNhJezmLyLch0oGZ1K6Mian8c0v63Avop+sr4CtmaFUS4 jsfw== X-Gm-Message-State: AFq9FYIXd/C12d+46MFPjBfp8XzVhhRYvYWbMeSBXdMvZcG+JVA5JTsE 4JyGzl3KMRR6mI3sCGrIapE93ZWx69jRwh3IJSw1Ea0c/uFRoZWTjySFoJGBBtLKZA== X-Gm-Gg: AYBFou0opCbXzN3qeH8skaRLpdVfa3bU8RovsZSbWwBBK3TDuGiwrLP6Jz+d6QGZ1FB T3QVGtQuX/BCZZmoT6dguHT6ZOqQHd54WDy2vzDpXAAo62ChF7naLW0lVequpMuB70JxJsijwtc /RK/naD9IH5E6qG5GmKiA50HQe8bwvS8N+VzNr4h4DszVjvfFClQoSjCsbjvKHu92T83F3bfxV6 +L8yUZ4tVp835S0oLnxncsEuRpEQV4Ec0d+2MtxAz0LO5bgdBauxdW/4xNvTFy20szkPKL3g+Xc Xal4TP/xmGMcBnpy12ztmt98O4MVKcZKDXLRQbQtAXBWcjgJx4xjZJdEW4w8N+4bItbNPG5VTTu fdlcge1MH68QerdVf/rLmnrjY6MkhmkoBGVIMKrOHe1Xkb2vGg8KcZlejd6tvcLZhY8HOWQyklN 6G8n5E8AO9eQ7zpoXbjKsVVk8CHs4x3NsJ/XwgkmN825pbhI2I1Z9O2DLZifspEwqcd/pdNYXV5 0L9s5j9AOI0AqCrHOnWLY8ISknrRDtBvMM1L6aZuAGgtm/4i2RKVdImKrWARMY9VYoflbfD1jE9 qTFiRIQ0yNp0fs/+1IhbFL/WPV9OLoC80kI2QS2ycApk9zqDuhMwSSZU5VBDd9/L1NRnaJuehMW upQgbxU9p X-Received: by 2002:a05:6808:238a:b0:4f5:cb60:33c5 with SMTP id 5614622812f47-5639fa6a14amr2021090b6e.6.1793213375778; Wed, 28 Oct 2026 11:49:35 -0700 (PDT) Received: from [192.168.0.26] (97-122-110-129.hlrn.qwest.net. [97.122.110.129]) by smtp.gmail.com with ESMTPSA id 5614622812f47-563c3638604sm2002697b6e.1.2026.10.28.11.49.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2026 11:49:35 -0700 (PDT) From: Tom Tromey Date: Wed, 28 Oct 2026 12:49:33 -0600 Subject: [PATCH 1/2] Avoid potential memory leak in Rust parser MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261028-rust-no-reset-v1-1-a57eab44c9a5@adacore.com> References: <20261028-rust-no-reset-v1-0-a57eab44c9a5@adacore.com> In-Reply-To: <20261028-rust-no-reset-v1-0-a57eab44c9a5@adacore.com> To: gdb-patches@sourceware.org Cc: Tom Tromey X-Mailer: b4 0.15.2 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org rust_parser::parse_field has some support for completion. This code allocates a rust_structop using plain 'new', then stores it somewhere. However, between the allocation and the store, the function calls "lex()", which might throw. This would leak the rust_structop object. This patch rearranges the code slightly to avoid the memory leak. --- gdb/rust-parse.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/gdb/rust-parse.c b/gdb/rust-parse.c index db4122119a5..9aaf85dc81c 100644 --- a/gdb/rust-parse.c +++ b/gdb/rust-parse.c @@ -1544,17 +1544,18 @@ rust_parser::parse_field (operation_up &&lhs) case COMPLETE: { bool is_complete = current_token == COMPLETE; - auto struct_op = new rust_structop (std::move (lhs), - std::string (current_string_val)); + auto struct_op + = std::make_unique (std::move (lhs), + std::string (current_string_val)); lex (); if (is_complete) { - completion_op.reset (struct_op); - pstate->mark_struct_expression (struct_op); + pstate->mark_struct_expression (struct_op.get ()); + completion_op = std::move (struct_op); /* Throw to the outermost level of the parser. */ error (_("not really an error")); } - result.reset (struct_op); + result = std::move (struct_op); } break; -- 2.56.0