From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id I9DzF8xz4Gpc5i4AWB0awg (envelope-from ) for ; Tue, 27 Oct 2026 05:50:04 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=a2ivhMN+; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qT0R65lF; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=a2ivhMN+; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qT0R65lF; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4B8E9378002; Tue, 27 Oct 2026 05:50:04 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9E744378002 for ; Tue, 27 Oct 2026 05:50:01 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 149E84BA2E05 for ; Tue, 27 Oct 2026 09:50:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 149E84BA2E05 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=a2ivhMN+; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qT0R65lF; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=a2ivhMN+; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qT0R65lF Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 2A0B14BA2E05 for ; Tue, 27 Oct 2026 09:49:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2A0B14BA2E05 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2A0B14BA2E05 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1793094569; cv=none; b=JEsRqz8KmfzzXn2Wdcg2sFjqAom0mypUhw57arNA3uNWYmKFTo73aNqe/EUcKbTFsjSpgH+r1eHt4cQzuavYNUb17TRYEB+29/tdxb2zO34VAYSI6CmLGUnSKpfIksNRtqzj8zKD8+5dD+Zmp+buDWxEtvysPApOSM4sk40hRqU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1793094569; c=relaxed/simple; bh=XLIL1Uq62COaU5KBBKF7pA27weCgeRUSlqhm7oBiVqI=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=U3nFJEgekXgg8YoD4StXV6MG6gp6JKTnIpFKmbbmrm1liCb2dDEHqXfrVUQHfb1RjT3XUVHFb+/9ZzpqGkYcFoSYfBtCxhbAupGEJaycXY20h/2BBwl0+FSAa/feO4kmjzhz8sCkKnQpj5nrYy0TkR7NClR/7SVKeDCvnODqL7I= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=a2ivhMN+; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qT0R65lF; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=a2ivhMN+; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qT0R65lF DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2A0B14BA2E05 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 03F8721FA8 for ; Tue, 27 Oct 2026 09:49:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1793094568; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XBrmYRLM7KqmiIP2EemLTX/nTq5Io6iVj1hlW5im5s8=; b=a2ivhMN+83yq7yB8xtERnRFJw2XVvQKOorTYXIuKo3+k8PqVjn41N3qBcviwPmsNy1/cIr HIB3EyRMPxMdixIFwCSPNjp8hyT/MJE9pZB6lkqYQTViDFEkwHWPo7G0v8PKFLTw1Duszb AJAcfPIMJ2DRvbC/ZEktbm51KJAdkoA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1793094568; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XBrmYRLM7KqmiIP2EemLTX/nTq5Io6iVj1hlW5im5s8=; b=qT0R65lFqPIW3vG1LbUYxg2OsrelQk9hgnmpDt+hJfAAu2YzM1IhGW5fJ19cnj5rPKSP9U 4ogTmfSRQDTTsFDQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=a2ivhMN+; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=qT0R65lF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1793094568; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XBrmYRLM7KqmiIP2EemLTX/nTq5Io6iVj1hlW5im5s8=; b=a2ivhMN+83yq7yB8xtERnRFJw2XVvQKOorTYXIuKo3+k8PqVjn41N3qBcviwPmsNy1/cIr HIB3EyRMPxMdixIFwCSPNjp8hyT/MJE9pZB6lkqYQTViDFEkwHWPo7G0v8PKFLTw1Duszb AJAcfPIMJ2DRvbC/ZEktbm51KJAdkoA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1793094568; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XBrmYRLM7KqmiIP2EemLTX/nTq5Io6iVj1hlW5im5s8=; b=qT0R65lFqPIW3vG1LbUYxg2OsrelQk9hgnmpDt+hJfAAu2YzM1IhGW5fJ19cnj5rPKSP9U 4ogTmfSRQDTTsFDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C572913319 for ; Tue, 27 Oct 2026 09:49:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id tXIRIadz4Gp4ZQAAD6G6ig (envelope-from ) for ; Tue, 27 Oct 2026 09:49:27 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH] [gdb/build] Fix Wmaybe-uninitialized in tid_range_parser::get_tid_or_range Date: Tue, 27 Oct 2026 10:49:26 +0100 Message-ID: <20261027094926.2701072-1-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 03F8721FA8 X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-Spamd-Result: default: False [-12.51 / 50.00]; SUSE_INTERNAL_BYPASS(-9.00)[]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On aarch64-linux with an -O3 build, I run into: ... gdb/tid-parse.c: In function ‘int tid_is_in_list(const char*, int, int, int)’: gdb/tid-parse.c:375:39: warning: ‘tmp_thr_end’ may be used uninitialized \ [-Wmaybe-uninitialized] 374 | if (tmp_inf == inf_num | ~~~~~~~~~~~~~~~~~~ 375 | && tmp_thr_start <= thr_num && thr_num <= tmp_thr_end) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ gdb/tid-parse.c:370:35: note: ‘tmp_thr_end’ was declared here 370 | int tmp_inf, tmp_thr_start, tmp_thr_end; | ^~~~~~~~~~~ ... This is a false positive. The warning is triggered in the tail of function tid_range_parser::get_tid_or_range: ... /* If we successfully parsed a thread number or finished parsing a thread range, switch back to assuming the next TID is inferior-qualified. */ if (!m_range_parser.in_range ()) { m_state = STATE_INFERIOR; m_cur_tok = m_range_parser.cur_tok (); if (thr_end != NULL) *thr_end = *thr_start; } /* If we're midway through a range, and the caller wants the end value, return it and skip to the end of the range. */ if (thr_end != NULL && (m_state == STATE_THREAD_RANGE || m_state == STATE_STAR_RANGE)) { *thr_end = m_range_parser.end_value (); skip_range (); } return (*inf_num != 0 && *thr_start != 0); } ... To understand what's happening, we need to know two things: - m_state has enum type with 3 valid values: STATE_INFERIOR, STATE_THREAD_RANGE, STATE_STAR_RANGE, and - at the start of the code snippet, m_state != STATE_INFERIOR. The first lets us reduce this: ... if (thr_end != NULL && (m_state == STATE_THREAD_RANGE || m_state == STATE_STAR_RANGE)) ... to: ... if (thr_end != NULL && m_state != STATE_INFERIOR) ... The second lets us reduce it to: ... else if (thr_end != NULL) ... at which point the warning is no longer triggered. And if we copy the return to the first if clause, we simply get: ... if (thr_end != NULL) ... Do this simplification and get rid of the warning. Tested on aarch64-linux. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34892 --- gdb/tid-parse.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gdb/tid-parse.c b/gdb/tid-parse.c index 767a125974e..0cfd6737c14 100644 --- a/gdb/tid-parse.c +++ b/gdb/tid-parse.c @@ -302,13 +302,13 @@ tid_range_parser::get_tid_or_range (int *inf_num, if (thr_end != NULL) *thr_end = *thr_start; + + return (*inf_num != 0 && *thr_start != 0); } /* If we're midway through a range, and the caller wants the end value, return it and skip to the end of the range. */ - if (thr_end != NULL - && (m_state == STATE_THREAD_RANGE - || m_state == STATE_STAR_RANGE)) + if (thr_end != NULL) { *thr_end = m_range_parser.end_value (); base-commit: aec50b130daf9c6882017a9d5424943fb41991e5 -- 2.51.0