From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6RVuAndy32pRnxwAWB0awg (envelope-from ) for ; Mon, 26 Oct 2026 11:32:07 -0400 Received: by simark.ca (Postfix, from userid 112) id 06171378002; Mon, 26 Oct 2026 11:32:07 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 850591E023 for ; Mon, 26 Oct 2026 11:32:06 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6B8F54BA23D5 for ; Mon, 26 Oct 2026 15:32:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6B8F54BA23D5 Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 80BBA4BA2E28 for ; Mon, 26 Oct 2026 15:31:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 80BBA4BA2E28 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 80BBA4BA2E28 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1793028701; cv=none; b=iMzee+e8CC/x/GdPpsfHAs4ChLDCz87xqORaDoggkpK1Fj8dEjQgzDaEikO2KLCErvHdYQRymde2/IZ6BALjWwgd9hd38z1KEuumkoK0ye1tKXJ+kyrEmdHMS9fTZbcY0KUknolPZVJb0KpIpFh2lisTqfOFV8VEm/hLH8sa7Gg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1793028701; c=relaxed/simple; bh=q7CnwEiCMJvdJ8I5mPHsu+QbxtAjHHA8ukT4A/9ZU8E=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=Bzd9E3KOixV1Ff6uPkLBLjYPnX5oTgaHs+wROmzIcsyDw8rqfhG4j+v2PHZiwalchy4XOGKuarVVoyi0k5c+UO5b1MW5DQwqjCmu6zK8iJAg3IbZvz+5WWgmzJthmMBk1YM8fHT+figSJiW4HZooq2YiIfdTyYYa6GRB4uBI3y0= ARC-Authentication-Results: i=1; sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 80BBA4BA2E28 Received: by simark.ca (Postfix) id 3D5421E023; Mon, 26 Oct 2026 11:31:38 -0400 (EDT) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH] gdb: use auto_obstack in parsers Date: Mon, 26 Oct 2026 11:31:36 -0400 Message-ID: <20261026153137.2007217-1-simon.marchi@efficios.com> X-Mailer: git-send-email 2.56.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Replace some manual obstack init/free with auto_obstack. Change-Id: Id703a8dfabac7f544f54a5b936e59e3eb34185d8 --- gdb/c-exp-parser.c | 9 ++------- gdb/d-exp-parser.c | 9 ++------- gdb/go-exp-parser.c | 9 ++------- 3 files changed, 6 insertions(+), 21 deletions(-) diff --git a/gdb/c-exp-parser.c b/gdb/c-exp-parser.c index 64bf455e7220..0e6b35760dc3 100644 --- a/gdb/c-exp-parser.c +++ b/gdb/c-exp-parser.c @@ -350,8 +350,7 @@ parse_number (struct parser_state *par_state, const char *buf, int len, } /* Temporary obstack used for holding strings. */ -static struct obstack tempbuf; -static int tempbuf_init; +static auto_obstack tempbuf; /* Parse a string or character literal from TOKPTR. The string or character may be wide or unicode. *OUTPTR is set to just after the @@ -377,11 +376,7 @@ parse_string_or_char (const char *tokptr, const char **outptr, (as well as strings in other languages) with embedded null bytes */ - if (!tempbuf_init) - tempbuf_init = 1; - else - obstack_free (&tempbuf, NULL); - obstack_init (&tempbuf); + tempbuf.clear (); /* Record the string type. */ if (*tokptr == 'L') diff --git a/gdb/d-exp-parser.c b/gdb/d-exp-parser.c index e6b5f3af8498..0fd01b490032 100644 --- a/gdb/d-exp-parser.c +++ b/gdb/d-exp-parser.c @@ -271,8 +271,7 @@ parse_number (struct parser_state *ps, const char *p, } /* Temporary obstack used for holding strings. */ -static struct obstack tempbuf; -static int tempbuf_init; +static auto_obstack tempbuf; /* Parse a string or character literal from TOKPTR. The string or character may be wide or unicode. *OUTPTR is set to just after the @@ -296,11 +295,7 @@ parse_string_or_char (const char *tokptr, const char **outptr, (as well as strings in other languages) with embedded null bytes */ - if (!tempbuf_init) - tempbuf_init = 1; - else - obstack_free (&tempbuf, NULL); - obstack_init (&tempbuf); + tempbuf.clear (); /* Skip the quote. */ quote = *tokptr; diff --git a/gdb/go-exp-parser.c b/gdb/go-exp-parser.c index 96418dfae4fc..59afbf94bcec 100644 --- a/gdb/go-exp-parser.c +++ b/gdb/go-exp-parser.c @@ -230,8 +230,7 @@ parse_number (struct parser_state *par_state, } /* Temporary obstack used for holding strings. */ -static struct obstack tempbuf; -static int tempbuf_init; +static auto_obstack tempbuf; /* Parse a string or character literal from TOKPTR. The string or character may be wide or unicode. *OUTPTR is set to just after the @@ -255,11 +254,7 @@ parse_string_or_char (const char *tokptr, const char **outptr, (as well as strings in other languages) with embedded null bytes */ - if (!tempbuf_init) - tempbuf_init = 1; - else - obstack_free (&tempbuf, NULL); - obstack_init (&tempbuf); + tempbuf.clear (); /* Skip the quote. */ quote = *tokptr; base-commit: 5d74f2038840c5e60e4b8b63fb8e64b98b26686b -- 2.56.0