From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2cxqOxIP22pLHA8AWB0awg (envelope-from ) for ; Fri, 23 Oct 2026 03:38:59 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=tFw3VjjK; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=YpH+4ZJm; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=tFw3VjjK; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=YpH+4ZJm; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id EC8A1378003; Fri, 23 Oct 2026 03:38:58 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7966B378002 for ; Fri, 23 Oct 2026 03:38:58 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 39BE14BA799F for ; Fri, 23 Oct 2026 07:38:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 39BE14BA799F Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=tFw3VjjK; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=YpH+4ZJm; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=tFw3VjjK; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=YpH+4ZJm Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 54A2F4BA79AC for ; Fri, 23 Oct 2026 07:38:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 54A2F4BA79AC Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 54A2F4BA79AC Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792741095; cv=none; b=wbikkZvQ2UMIFDNi/TA2H7OKX8QovAl0YmP0Of5fgQWmWeSwoz1Uvl3eN6I8Zz3ULaAqkQtqd4y8lIudnYxo5SLhGjfVTOgiRYGbU8pIz/Bx+dx9Qrdsc5UwzvHZ3Cu/q361DCQ80iu5aYwIX66jHfKNw02x0ECZcSunqDxGQGg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792741095; c=relaxed/simple; bh=m4KmoDw6FsC0TsCta1qDMT4h34BOg1CSWZffbEpMN5g=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=MZVj0CdlSaCYwAiMHAOOeYVvaZJE8m42FIxseFv0RJs+Hp9r5K73FXZAtzL9/dYld2SjCVfCnrlddBfzwPknGfiH/bXR+Upew+xVPZGL48PSQDY8tXYZSnPdwsoZRRvIo5CGu4IethofQ1NSmIXnIZsTeXZCqrQOVLht2M6tTUU= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=tFw3VjjK; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=YpH+4ZJm; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=tFw3VjjK; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=YpH+4ZJm DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 54A2F4BA79AC Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 61C4C22126 for ; Fri, 23 Oct 2026 07:38:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1792741094; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XCIaqOvgb0t3G6jugD92ThkQoO6HZYdUvSz6E+/yKV8=; b=tFw3VjjKOFIi2iL27/jgAoC9fn3k1NxlD8YbiKQv18G4q7gaGdqcoRqAKDNUWO8qP7EbtS PucVgDPQpB0j9feVf4meJ/pfScLZW4dKqgC942cF1AEd6Q0vfDQ4pfRTM7Igf+5NpYCPjP lMgy5VU1PC5DnpLlS0+OVcHtaOmuAuI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1792741094; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XCIaqOvgb0t3G6jugD92ThkQoO6HZYdUvSz6E+/yKV8=; b=YpH+4ZJmGjUpAnrAZh6oaXf3JVX8bVeAdNIJ4+9GW+FfHz/mZOp2dk27a1s7+MtYLFarDm SdbrBFMiZSmmr8Bg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1792741094; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XCIaqOvgb0t3G6jugD92ThkQoO6HZYdUvSz6E+/yKV8=; b=tFw3VjjKOFIi2iL27/jgAoC9fn3k1NxlD8YbiKQv18G4q7gaGdqcoRqAKDNUWO8qP7EbtS PucVgDPQpB0j9feVf4meJ/pfScLZW4dKqgC942cF1AEd6Q0vfDQ4pfRTM7Igf+5NpYCPjP lMgy5VU1PC5DnpLlS0+OVcHtaOmuAuI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1792741094; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XCIaqOvgb0t3G6jugD92ThkQoO6HZYdUvSz6E+/yKV8=; b=YpH+4ZJmGjUpAnrAZh6oaXf3JVX8bVeAdNIJ4+9GW+FfHz/mZOp2dk27a1s7+MtYLFarDm SdbrBFMiZSmmr8Bg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2DE4F134E9 for ; Fri, 23 Oct 2026 07:38:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Jy73LeUO22qkUAAAD6G6ig:T3 (envelope-from ) for ; Fri, 23 Oct 2026 07:38:14 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH 2/3] [gdb] Don't flush in handle_fatal_signal Date: Fri, 23 Oct 2026 09:38:12 +0200 Message-ID: <20261023073813.2224939-3-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20261023073813.2224939-1-tdevries@suse.de> References: <20261023073813.2224939-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-11.80 / 50.00]; SUSE_INTERNAL_BYPASS(-9.00)[]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-0.998]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_ONE(0.00)[1]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCVD_TLS_ALL(0.00)[] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org In handle_fatal_signal we use "gdb_stderr->flush ()". In this function, we only want to use async-safe output, and flushing isn't. Furthermore, all output is done using sig_write, which is unbuffered, so there's nothing to flush. Drop it. --- gdb/event-top.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/gdb/event-top.c b/gdb/event-top.c index 0fb6eafec57..78683ec364f 100644 --- a/gdb/event-top.c +++ b/gdb/event-top.c @@ -1016,14 +1016,6 @@ handle_fatal_signal (int sig) sig_write ("."); } sig_write ("\n\n"); - - if (gdb_stderr == nullptr || gdb_stderr->fd () == -1) - { - /* Writing to file descriptor instead of stream, no flush - required. */ - } - else - gdb_stderr->flush (); } #endif -- 2.51.0