Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [PATCH 0/4] [gdb/tui] Fix hang in tui_disable in handle_fatal_signal
Date: Wed, 21 Oct 2026 10:01:16 +0200	[thread overview]
Message-ID: <20261021080120.349861-1-tdevries@suse.de> (raw)

This patch series contains four patches.

The first adds missing logging_file::fd.

The second updates test-case gdb.tui/new-ui.exp to issue a
"maint internal-error" from a new UI while the main UI is in TUI mode.

The third patch tries to handle that scenario better, by actually triggering
an internal error.

The last patch fixes PR34732.

Tested on x86_64-linux.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34732

Tom de Vries (4):
  [gdb] Add logging_file::fd
  [gdb/testsuite] Check internal-error in gdb.tui/new-ui.exp
  [gdb/tui] Switch to main UI before disabling TUI
  [gdb/tui] Fix hang in tui_disable in handle_fatal_signal

 gdb/event-top.c                               |  8 +-
 gdb/logging-file.h                            |  6 ++
 .../gdb.base/logging-internal-error.exp       | 75 +++++++++++++++++++
 gdb/testsuite/gdb.tui/new-ui.exp              | 42 +++++++++++
 gdb/tui/tui-interp.c                          |  6 +-
 gdb/tui/tui-io.c                              | 11 ++-
 gdb/tui/tui-io.h                              |  3 +
 gdb/tui/tui.c                                 | 59 +++++++++++----
 gdb/tui/tui.h                                 | 11 ++-
 gdb/utils.c                                   | 11 ++-
 10 files changed, 210 insertions(+), 22 deletions(-)
 create mode 100644 gdb/testsuite/gdb.base/logging-internal-error.exp


base-commit: cfd8ea4e101d9793895d9b8b016da5c2ec6a672a
-- 
2.51.0


             reply	other threads:[~2026-10-21  8:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-21  8:01 Tom de Vries [this message]
2026-10-21  8:01 ` [PATCH 1/4] [gdb] Add logging_file::fd Tom de Vries
2026-10-21 16:54   ` Tom Tromey
2026-10-23  8:02     ` Tom de Vries
2026-10-23 17:41       ` Tom Tromey
2026-10-23 18:25         ` Tom de Vries
2026-10-21  8:01 ` [PATCH 2/4] [gdb/testsuite] Check internal-error in gdb.tui/new-ui.exp Tom de Vries
2026-10-21  8:01 ` [PATCH 3/4] [gdb/tui] Switch to main UI before disabling TUI Tom de Vries
2026-10-21  8:01 ` [PATCH 4/4] [gdb/tui] Fix hang in tui_disable in handle_fatal_signal Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261021080120.349861-1-tdevries@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox