[PATCH 08/13] gdb: remove \^ escape sequence support from C++ name parser

[Simon Marchi <simon.marchi@efficios.com>]

cp_parse_escape, used by the C++ name parser to parse escape sequences
in character literals, accepts "\^" followed by a character.  This
denotes a control character, as in caret notation: "\^A" is 1, "\^?" is
0177 (DEL).

This is not valid C or C++, no known compiler (gcc or clang) nor the
demangler produce it in symbol names, so I don't think that the C++ name
parser needs to accept it.

This support is a leftover from GDB's old generic parse_escape function,
in utils.c, which already supported "\^" since basically forever.  When
the C++ name parser was introduced, in commit fb4c6eba439c (2005-03-11),
it got a copy of parse_escape, including the "\^" support.  That copy
was renamed to cp_parse_escape in commit 5256a53bb3fb (2008-10-27).
parse_escape itself lost the "\^" support in commit 6c7a06a3facf
(2009-03-20), but the copy was not updated.

Remove it.  A "\^" sequence is now handled like other unknown escape
sequences.

Change-Id: I866d04281d16dc2f82ea391ffa84370450682951
---
 gdb/cp-name-parser.c | 18 ------------------
 1 file changed, 18 deletions(-)

diff --git a/gdb/cp-name-parser.c b/gdb/cp-name-parser.c
index d7ecb534b718..4c5f18c9851f 100644
--- a/gdb/cp-name-parser.c
+++ b/gdb/cp-name-parser.c
@@ -494,24 +494,6 @@ cp_parse_escape (const char **string_ptr)
       case 0:
 	(*string_ptr)--;
 	return 0;
-      case '^':
-	{
-	  c = *(*string_ptr)++;
-
-	  if (c == '?')
-	    return 0177;
-	  else if (c == '\\')
-	    target_char = cp_parse_escape (string_ptr);
-	  else
-	    target_char = c;
-
-	  /* Now target_char is something like `c', and we want to find
-	     its control-character equivalent.  */
-	  target_char = target_char & 037;
-
-	  return target_char;
-	}
-
       case '0':
       case '1':
       case '2':
-- 
2.56.0