Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@efficios.com>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: [PATCH 2/2] gdb/guile: remove unused escape_symbol variable
Date: Mon, 19 Oct 2026 12:06:39 -0400	[thread overview]
Message-ID: <20261019160644.629989-2-simon.marchi@efficios.com> (raw)
In-Reply-To: <20261019160644.629989-1-simon.marchi@efficios.com>

Building GDB with a recent clang fails with:

    /home/smarchi/src/binutils-gdb/gdb/guile/scm-value.c:78:12: error: variable 'escape_symbol' set but not used [-Werror,-Wunused-but-set-global]

value->string only accepts 'error and 'substitute for its #:errors
argument, so the 'escape symbol is never used.  It has been unused since
commit ed3ef33944c3 ("Add Guile as an extension language.",
2014-02-09).  Remove it.

Change-Id: Ie088e3c133c4443a0131d5b9830814724be405fe
---
 gdb/guile/scm-value.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/gdb/guile/scm-value.c b/gdb/guile/scm-value.c
index 277195688093..0e388bf1f056 100644
--- a/gdb/guile/scm-value.c
+++ b/gdb/guile/scm-value.c
@@ -75,7 +75,6 @@ static SCM length_keyword;
 
 /* Possible #:errors values.  */
 static SCM error_symbol;
-static SCM escape_symbol;
 static SCM substitute_symbol;
 \f
 /* Administrivia for value smobs.  */
@@ -1541,6 +1540,5 @@ gdbscm_initialize_values (void)
   length_keyword = scm_from_latin1_keyword ("length");
 
   error_symbol = scm_from_latin1_symbol ("error");
-  escape_symbol = scm_from_latin1_symbol ("escape");
   substitute_symbol = scm_from_latin1_symbol ("substitute");
 }
-- 
2.56.0


      reply	other threads:[~2026-10-19 16:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-19 16:06 [PATCH 1/2] gdb/guile: remove unused orig_*_port_scm variables Simon Marchi
2026-10-19 16:06 ` Simon Marchi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261019160644.629989-2-simon.marchi@efficios.com \
    --to=simon.marchi@efficios.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox