From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id NNngCWI71mq10TIAWB0awg (envelope-from ) for ; Mon, 19 Oct 2026 11:46:42 -0400 Received: by simark.ca (Postfix, from userid 112) id 15DDA1E04E; Mon, 19 Oct 2026 11:46:42 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3F9421E04E for ; Mon, 19 Oct 2026 11:46:41 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 078BA4BA23D8 for ; Mon, 19 Oct 2026 15:46:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 078BA4BA23D8 Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id DE3BD4BA2E23 for ; Mon, 19 Oct 2026 15:46:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DE3BD4BA2E23 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DE3BD4BA2E23 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792424776; cv=none; b=ScqDfNCR1EtgQK5+EJHJcg82iH0GYXZUORCKV1flRw1ORpP429tiPIAbFJW9FMrXaPiG71+skEgW2AFW6tQCoFDmbySpa+DXHSlZxpSDU/6aDQ18UtRBbyf7/k2MiZH7h1G/yZTUudhQnSIQhJLgpAK29CiyJbcT/hYGHfDVYd8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792424776; c=relaxed/simple; bh=uKMxT+N0kushwLgCXwMM5JLqZ54P4Lj9Lofy4jIMyfI=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=Kx3nu1OtMV/fycD06VbXkaBFcNE3qfJWHj8038cOUS3Yzf7e8Hsk6JEX4COwUOPs3qj8es9bDGuK8zrLtVwAwwfhlCFX4jb8VRB1KS6eWJTcK5A1UewYBJ6LSFynwdE/nCLqvXYHLHcBi84eVZbiVOHKGxSQkGTSHFy8VqveFRM= ARC-Authentication-Results: i=1; sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DE3BD4BA2E23 Received: by simark.ca (Postfix) id 76CF31E04E; Mon, 19 Oct 2026 11:46:14 -0400 (EDT) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [pushed] gdbserver: remove unused last_tracepoint variable Date: Mon, 19 Oct 2026 11:46:07 -0400 Message-ID: <20261019154613.544164-1-simon.marchi@efficios.com> X-Mailer: git-send-email 2.56.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Building gdbserver with a recent clang fails with: /home/smarchi/src/binutils-gdb/gdbserver/tracepoint.cc:753:27: error: variable 'last_tracepoint' set but not used [-Werror,-Wunused-but-set-global] The variable has been unused since commit 1e4d17643d49 (2011-11-14), which changed add_tracepoint to insert new tracepoints in address order instead of appending them at the end of the list. That commit removed the only read of last_tracepoint, but left the assignments. Remove the variable. Change-Id: I85293f31f7994c49a6a878f4192c97874ed26eee --- gdbserver/tracepoint.cc | 7 ------- 1 file changed, 7 deletions(-) diff --git a/gdbserver/tracepoint.cc b/gdbserver/tracepoint.cc index 593dca65f768..a5bb22540fdc 100644 --- a/gdbserver/tracepoint.cc +++ b/gdbserver/tracepoint.cc @@ -747,11 +747,6 @@ IP_AGENT_EXPORT_VAR int expr_eval_result = expr_eval_no_error; #ifndef IN_PROCESS_AGENT -/* Pointer to the last tracepoint in the list, new tracepoints are - linked in at the end. */ - -static struct tracepoint *last_tracepoint; - static const char * const eval_result_names[] = { #define AX_RESULT_TYPE(ENUM,STR) STR, @@ -1738,7 +1733,6 @@ add_tracepoint (int num, CORE_ADDR addr) ; tpoint->next = *tp_next; *tp_next = tpoint; - last_tracepoint = tpoint; seen_step_action_flag = 0; @@ -2260,7 +2254,6 @@ cmd_qtinit (char *packet) clear_readonly_regions (); tracepoints = NULL; - last_tracepoint = NULL; /* Clear out any leftover trace state variables. Ones with target defined getters should be kept however. */ base-commit: a0afe8f89d660b0cbcf5f7f12167427f3d2a5c37 -- 2.56.0