From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [pushed] [gdb/testsuite] Fix gdb.tui/scroll-bottom-right.exp with editing off
Date: Sat, 17 Oct 2026 11:41:28 +0200 [thread overview]
Message-ID: <20261017094128.2591991-1-tdevries@suse.de> (raw)
With test-case gdb.tui/scroll-bottom-right.exp and make-check-all.sh I
ran into:
...
HOST BOARD: local-remote-host-notty, TARGET BOARD: remote-gdbserver-on-localhost
FAIL: gdb.tui/scroll-bottom-right.exp: prompt at left border
FAIL: gdb.tui/scroll-bottom-right.exp: responsive prompt
...
The problem is that the host board sets editing to off, while the test-case
uses ^L, which requires editing on.
Fix this by using echo instead.
Tested on x86_64-linux.
---
gdb/testsuite/gdb.tui/scroll-bottom-right.exp | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/gdb/testsuite/gdb.tui/scroll-bottom-right.exp b/gdb/testsuite/gdb.tui/scroll-bottom-right.exp
index ff00e90bb56..0abf9c29ffb 100644
--- a/gdb/testsuite/gdb.tui/scroll-bottom-right.exp
+++ b/gdb/testsuite/gdb.tui/scroll-bottom-right.exp
@@ -53,9 +53,13 @@ gdb_assert \
{[Term::wait_for_region_contents {*}$last_line "$gdb_prompt"]} \
"got back prompt"
-# Send ^L to get prompt at left border. Echo doesn't add an implicit newline,
-# so the prompt is now near the right border.
-send_gdb "\014"
+# The echo command doesn't add an implicit newline, so after
+# "echo $str60$str10" the prompt ends up near the right border. Send an echo
+# without arguments to get the prompt at the left border.
+# (gdb) echo 0123456789...0123456789
+# 0123456789...0123456789(gdb) echo
+# (gdb)
+send_gdb "echo\n"
gdb_assert {[Term::wait_for ""]} "prompt at left border"
# Check that gdb is responsive.
base-commit: 2605fa5d119b31d383ca7826d45266edd6cd2a21
--
2.51.0
reply other threads:[~2026-10-17 9:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261017094128.2591991-1-tdevries@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox