From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OfFoLEwL0mpDxhkAWB0awg (envelope-from ) for ; Fri, 16 Oct 2026 07:32:28 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=v/YQ5/NW; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qHT2xVYO; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=un3mgGW7; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=9Y1NfX90; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B0E481E050; Fri, 16 Oct 2026 07:32:28 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EDBDC1E047 for ; Fri, 16 Oct 2026 07:32:27 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 187D24BA2E21 for ; Fri, 16 Oct 2026 11:32:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 187D24BA2E21 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=v/YQ5/NW; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qHT2xVYO; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=un3mgGW7; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=9Y1NfX90 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 685FB4BA2E14 for ; Fri, 16 Oct 2026 11:31:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 685FB4BA2E14 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 685FB4BA2E14 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792150287; cv=none; b=MN2feFTeiq+L8n2jb3MXbT93zoWFGkt4+dJICxbixSx1tV79QVceDivu47e6rRlGl9xvNp0J/H049Bei4f/JmgCx2rSWjmU40M1xUs8J3r99/F0kOjgxtserM+owWqOLRxSCS+g5bqLSyq8DEFkXfbQX7cTBtr/rXBgiIn78Y9M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792150287; c=relaxed/simple; bh=67F9ZIptQqSrYKFwpuzlnHmbcVXnkvZEe3ldVdhdWyo=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=JkDg0ubKn4CYiSLVXk/7zDQrodBpBvnu6zPkcaNZpV9mX2DGcC8PhmQBjqBKPz7qtmJiRucTYw64TLaeVlx+gJevu+Iwjg+j9p4rR80L1gyMTupMm+SvEDN1PicPas37RMWjwUU+KanII8ZCEssM1vOSNlTKgnol2ncwSBcWCI0= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=v/YQ5/NW; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qHT2xVYO; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=un3mgGW7; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=9Y1NfX90 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 685FB4BA2E14 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1DD1221C55 for ; Fri, 16 Oct 2026 11:31:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1792150286; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P3u/Eq3cj2Pnse2wzVdFISa/IpP2Wog9L87NYC2Dcxw=; b=v/YQ5/NWS5pM4lZrz9KpcuuXtEKwPmqE0HCWyEof79E9REm31IvHDD9jQFyON0ARm+FaE4 a2vGbMoqU88L5qwTBJcO/UBSDwXCDWVZHfaqWUfVV29Txq3XxTgX090s8Lmk79L8aevZmi Iq56ZahULYCUu/z0mdC2KCi8Bd9XgFs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1792150286; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P3u/Eq3cj2Pnse2wzVdFISa/IpP2Wog9L87NYC2Dcxw=; b=qHT2xVYOo/zjX3da86AUp6CFCWDTGqk4ZbDxHh6bCmsKyRUThAOE9tb3qX35T5x0StI0Oj NFK62PJC8Vr3PVBw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=un3mgGW7; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=9Y1NfX90 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1792150285; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P3u/Eq3cj2Pnse2wzVdFISa/IpP2Wog9L87NYC2Dcxw=; b=un3mgGW7HVy9r7pQMCP10t9Vq7BrdHWbxtfvzbQCK42Zj9f55tjkLssaaH/j+/Cturo+mq Zj5UqEymhkPGSq763pMHkJPYBuYlLeY8EYI8WJNJHJyVvL7Wo5z2zs+iVa58P0MZg61ZrU 2DhZ9a6cs9soQ1C6C+c+1hlHQmW0cEw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1792150285; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P3u/Eq3cj2Pnse2wzVdFISa/IpP2Wog9L87NYC2Dcxw=; b=9Y1NfX90SWE/9vWA3jE05tr+KUqHz7qoyHYPytjdLavOeY4npHCKg6J9ju2isYyvHQZmx+ rK1g+umurDeM1rBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 987B5139B7 for ; Fri, 16 Oct 2026 11:31:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id DyljCQwL0mqzFAAAD6G6ig:T3 (envelope-from ) for ; Fri, 16 Oct 2026 11:31:24 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [pushed 2/3] [gdb/testsuite] Fix "FIXME scroll" error in Term::_insert Date: Fri, 16 Oct 2026 13:31:22 +0200 Message-ID: <20261016113123.6460-3-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20261016113123.6460-1-tdevries@suse.de> References: <20261016113123.6460-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: 1DD1221C55 X-Rspamd-Action: no action X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_ONE(0.00)[1]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_TLS_ALL(0.00)[]; TO_DN_NONE(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Use Term::_scroll in Term::_insert to fix the error "FIXME scroll". At the point that tuiterm was added, it had two of those, one in Term::_ctl_0x0a and one in Term::_insert. The one in Term::_ctl_0x0a was fixed by commit efe1b6507b7 ("gdb/testsuite: fix line feed scrolling in tuiterm.exp"). We're essentially reusing that code to fix Term::_insert as well. The scrolling affected by this patch is scrolling after wrapping. This commit implements ANSI wrapping behaviour. Wrapping in xterm requires support for the newline glitch. There's an issue open about this [1]. [1] https://sourceware.org/bugzilla/show_bug.cgi?id=30451 --- gdb/testsuite/gdb.tui/tuiterm.exp | 12 ++++++++++-- gdb/testsuite/lib/tuiterm.exp | 5 +---- 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/gdb/testsuite/gdb.tui/tuiterm.exp b/gdb/testsuite/gdb.tui/tuiterm.exp index 4966800c0bb..75bd205d51e 100644 --- a/gdb/testsuite/gdb.tui/tuiterm.exp +++ b/gdb/testsuite/gdb.tui/tuiterm.exp @@ -81,8 +81,7 @@ set small_initial { # yz01234 # # The bottom right cell is left blank: trying to write to it using _insert -# would move the cursor past the screen, causing a scroll, but scrolling is -# not implemented at the moment. +# would move the cursor past the screen, causing a scroll. proc setup_small {} { setup_terminal 8 4 @@ -594,6 +593,15 @@ proc test_repeat { } { "qrstuvwx" "yz01234 " } 5 1 + + Term::_move_cursor 7 3 + Term::_csi_b 1 + check "repeat at bottom-right corner" { + "xxXXXnop" + "qrstuvwx" + "yz01234X" + " " + } 0 3 } proc test_vertical_line_position_absolute { } { diff --git a/gdb/testsuite/lib/tuiterm.exp b/gdb/testsuite/lib/tuiterm.exp index 39fcb082b47..9d29549fdce 100644 --- a/gdb/testsuite/lib/tuiterm.exp +++ b/gdb/testsuite/lib/tuiterm.exp @@ -922,7 +922,6 @@ proc Term::_insert {str} { variable _cur_col variable _cur_row - variable _rows variable _cols variable _attrs variable _chars @@ -934,9 +933,7 @@ proc Term::_insert {str} { if {$_cur_col >= $_cols} { set _cur_col 0 incr _cur_row - if {$_cur_row >= $_rows} { - error "FIXME scroll" - } + _scroll } } } -- 2.51.0