From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ndJ0CewH0Wo0yBIAWB0awg (envelope-from ) for ; Thu, 15 Oct 2026 13:05:48 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=kZNN9xxp; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id F2D221E050; Thu, 15 Oct 2026 13:05:47 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2688C1E04E for ; Thu, 15 Oct 2026 13:05:46 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CCC914BA2E2E for ; Thu, 15 Oct 2026 17:05:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CCC914BA2E2E Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=kZNN9xxp Received: from CY7PR03CU001.outbound.protection.outlook.com (mail-westcentralusazlp170100005.outbound.protection.outlook.com [IPv6:2a01:111:f403:c112::5]) by sourceware.org (Postfix) with ESMTPS id 2CB7B4BA2E05 for ; Thu, 15 Oct 2026 17:05:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2CB7B4BA2E05 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2CB7B4BA2E05 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c112::5 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1792083918; cv=pass; b=NwZakhaqNqTymHfpsLZCuTStISIcJt/C52/Fia+53JxhcVN2x0dvIsu/zGHRGG/f9khzLR7njiXGUbXDy4dq6hBQDfpXAxWl9tO5gxhkMT705NDizridkRnHje2mVbTNZjn4yIHhe5DRSyF6UdCDwUw5Dnvluta6ph7dP42th40= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1792083918; c=relaxed/simple; bh=rOwJPpheYFcktlqb1e8P8XUueACyQchSue0cmcoZUTc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=W7jKIpkXbxpQq3urrRntMpLdfEM9ZSW6RWbqrfYSin6ekdrVW93Ads3mEasp3n+H/9nQrKZeRXPsJ6jH8dchicQVe+hiaCtT2fKJ12ZMCNtoVjtocY4AhCBela16tUJgIyFN+VtO71atl2vBoCKdYcCUpI4YqisE637vu+vriO0= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=kZNN9xxp DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2CB7B4BA2E05 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HwWn3w/Mb8GOp/dG82+EeIqJlIo5pD8VeEyUr9x2PAQPaNN+JWbLPx1rx9lLCB34x8BqZ9pnhK+HVctYab3iAkyfjV+EXdNo5gQgBBAoRxDXqP5RUPf5k6k5zvje99s8vJkxe/bt7Bb6iXS/bllLRjTAhr9e/J/WBsDu/ETWVur3shufZEr+8wrtXsoOYvIR68eH9AjHxroBDRV4W0cRtDLkwIol8UEryeL4MDPkIXntQR/MtIN77zwLUIpMKh6sE3t14h94SdbZ3Ciq0ShEZux0rCChBLkc4Olzhz/inNj2u48sEVVRtvaEg+P6YkANlLF5J1IXBUrKQKIM9AuOZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h/rOJwmdTtH5m3MZTHXKlIbCNeg6aL4k9Wg3SrplipY=; b=CopMa+jIKRFisjQoSsnM0qw81dTn5aAmB/4617Z2MJ9RGQoQTMfxJn6GYPJzgmhi9bt0aYebc2ZnqAGu5yv5q502F6E7dpkyneZ5p4MNrXxt4lp98lpIy0bNSvzHM5BbPVN1v4bfauYTqFBk4Twz2gDCDs6UZO7flh+6atHpDiQIQaMeC5VoPOT+2UDIGjtylzr2PDbpaniNTqCKV5s+/Le4jki+R9RUIg+4z2qv7qS/QTgz7VD9PB3gifSB4Gs5HPJcmc6qXw9moJvUe8pYUGHWOYAZd3uRv+XfPIijvtKI0jm3Riug8LWN/hhOUlo0eJlxix2YOU5KirCdutq4hA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=sourceware.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h/rOJwmdTtH5m3MZTHXKlIbCNeg6aL4k9Wg3SrplipY=; b=kZNN9xxpCwPvx0i7swWhb7pJfjLIf6sLbRXhmforE2PAG0+yqh1q62g8McYvkgQcn3mYcDjHVntnfDHNbju+BbZ3B27f6vE1GAyPj1mplcSGNqgIbAUS1dIq0V761bqg6spLZoPrQDsO9y1D9ChHL23JKCU9sjn3GUQWeNItIcw= Received: from PH7P220CA0100.NAMP220.PROD.OUTLOOK.COM (2603:10b6:510:32d::14) by IA0PR12MB7751.namprd12.prod.outlook.com (2603:10b6:208:430::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.23; Thu, 15 Oct 2026 17:05:08 +0000 Received: from CY7PEPF000000E8.namprd04.prod.outlook.com (2603:10b6:510:32d:cafe::36) by PH7P220CA0100.outlook.office365.com (2603:10b6:510:32d::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.472.20 via Frontend Transport; Thu, 15 Oct 2026 17:05:08 +0000 X-MS-Exchange-Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CY7PEPF000000E8.mail.protection.outlook.com (10.167.247.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.522.6 via Frontend Transport; Thu, 15 Oct 2026 17:05:07 +0000 Received: from rocgdb-taktemur.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.53; Thu, 15 Oct 2026 12:05:00 -0500 From: Tankut Baris Aktemur To: , , Subject: [PATCH] gdb, amdgpu: add config guards for AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE Date: Thu, 15 Oct 2026 19:04:50 +0200 Message-ID: <20261015170450.2520815-1-tankutbaris.aktemur@amd.com> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY7PEPF000000E8:EE_|IA0PR12MB7751:EE_ X-MS-Office365-Filtering-Correlation-Id: 8fd1c046-14ac-48ca-1518-08df2ade7700 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700016|1800799024|23010399003|376014|82310400026|56012099006|11063799006|261009223027099003|10067099003|6133799003|18002099003; X-Microsoft-Antispam-Message-Info: UoRfkFklQv8ueuuonvwWvyHBMSbEUiA+e2eMNhPutNO+czUnKmdGZHJkNGRPy+A7MdiK8poUVCPBC9f5XiqsP52BkEBRGvnPH0g+UVgNxkIeBFIRvbl9djtFCWWusSlbNN7wI7OirF69t0NGv1joBzpcQR7oiWt2BKQ+yCmucWYE9yNtKdP+RBpNesWUTDe48dwVAEhc2xzzjJF2gIPecucCG74uMJLBH1kaSqSjT9gcxW5hftlsS88NoCRXG851U4AX2FWyHXiWb2Ff8z6WxjLA9pEl0pZpGPRFoRMr3aOTRr8Bl3TEIqgWVxBf1ck3hp/DC4DCaEVhWfGYz7Rr508Vpujv7RUGgANBQuorTBYK47IOTRxKhtiEzcCu0O5gXgTUfLlE80+EbLNs76gfBh5b9lwMIUbndCSd6tBtzxLMmUsbw+AuLKvKRV1qjhI138HrPHBYrVqqw5uW8b3P3F8F2puhDAG1K1fkoZNvFwIE157bVGKbtxhVYlosLgZ/gvSucxaviqfaczIZDER7CVK+Nzno/HqvOcEzLALqxJXpCD9EHEjWaow36INv7iCnGR8ovtAW/gnLkAW9e70svtrkeYzIF7dpQiqY92F0s6W0kwHGjz6EsEpHaFE/v3KIkiOKPRxMnDrPfzc3zFtgVc8eOjcuKeVza6CgRwXLF84= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:satlexmb07.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(36860700016)(1800799024)(23010399003)(376014)(82310400026)(56012099006)(11063799006)(261009223027099003)(10067099003)(6133799003)(18002099003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: LWM74aTzd4o9lmZWvD5hcfcd5oLkG5+1K7r03iu0uZTS/cfAHQ4u0+b31QL6OKSwQgjupyD17kBdXn5FZ1sPPinxAYgFmH41yF4wYkk25jYgwP2bqboHCgkALa1eXaPkjPriPxL3E0Y84/n1wGSGT+vXSBSSbfc0uHCWXp/6XpRpi9h+85eJW64Yfi21ZW42Im6iTt0MzD68C8xxJgy+CrFq3avW/skpZatuXfvesEu3CGUKTZX+QPGMH9FDCSrWi00NR5xwflELUw96ntiGOwIwTQdM9UrqXHNGDF9VcLPIOo5bDtnKMpsMOOSQRgy+m3/XQ0v//R0cnvAqgGWUwnzkdU9K9yY/yPgyeE/zPoFLRpXwRPWWElFDRTNb7z++39N3UuDKxbieNNlyAx/37rl9DQBfb3MK0d6bo7pADvPynRrFOMgomX9339sIg0XM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2026 17:05:07.6858 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8fd1c046-14ac-48ca-1518-08df2ade7700 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY7PEPF000000E8.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7751 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Commit e52a8aca2baf6481c4e8fea45530283759096be5 "gdb, amdgpu: handle UNAVAILABLE error when accessing memory" used an enum value from amd-dbgapi named AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE that may not be available in all installed packages. This causes a build failure as reported by Tom Tromey at https://sourceware.org/pipermail/gdb-patches/2026-October/231115.html Detect at configuration time if the enum value exists and guard the newly added code accordingly. --- gdb/amd-dbgapi-target.c | 4 ++++ gdb/config.in | 3 +++ gdb/configure | 36 ++++++++++++++++++++++++++++++++++++ gdb/configure.ac | 21 +++++++++++++++++++++ 4 files changed, 64 insertions(+) diff --git a/gdb/amd-dbgapi-target.c b/gdb/amd-dbgapi-target.c index 2fd175de6f7..1446187c75f 100644 --- a/gdb/amd-dbgapi-target.c +++ b/gdb/amd-dbgapi-target.c @@ -786,11 +786,13 @@ amd_dbgapi_target::xfer_partial (enum target_object object, const char *annex, AMD_DBGAPI_ADDRESS_SPACE_GLOBAL, offset, &len, writebuf); +#if AMD_DBGAPI_HAS_STATUS_ERROR_MEMORY_UNAVAILABLE if (status == AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE) { *xfered_len = requested_len; return TARGET_XFER_UNAVAILABLE; } +#endif if (status != AMD_DBGAPI_STATUS_SUCCESS) return TARGET_XFER_E_IO; @@ -2576,8 +2578,10 @@ amd_dbgapi_xfer_global_memory_callback if (status == TARGET_XFER_EOF) return AMD_DBGAPI_STATUS_ERROR_PROCESS_EXITED; +#if AMD_DBGAPI_HAS_STATUS_ERROR_MEMORY_UNAVAILABLE else if (status == TARGET_XFER_UNAVAILABLE) return AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE; +#endif else if (status != TARGET_XFER_OK) return AMD_DBGAPI_STATUS_ERROR_MEMORY_ACCESS; diff --git a/gdb/config.in b/gdb/config.in index 7ea0e9cfce8..93060f573c5 100644 --- a/gdb/config.in +++ b/gdb/config.in @@ -6,6 +6,9 @@ /* Additional directories to look for separate debug info. */ #undef ADDITIONAL_DEBUG_DIRS +/* Define if AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE is available. */ +#undef AMD_DBGAPI_HAS_STATUS_ERROR_MEMORY_UNAVAILABLE + /* Directories from which to load auto-loaded scripts. */ #undef AUTO_LOAD_DIR diff --git a/gdb/configure b/gdb/configure index 0ed49887480..eaa8588fe69 100755 --- a/gdb/configure +++ b/gdb/configure @@ -25105,6 +25105,42 @@ $as_echo "#define HAVE_AMD_DBGAPI 1" >>confdefs.h as_fn_error $? "amd-dbgapi not supported for host ${gdb_host}" "$LINENO" 5 ;; esac + + # Detect if AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE can be used. + save_CPPFLAGS="$CPPFLAGS" + CPPFLAGS="$CPPFLAGS $AMD_DBGAPI_CFLAGS" + { $as_echo "$as_me:${as_lineno-$LINENO}: checking whether AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE is available" >&5 +$as_echo_n "checking whether AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE is available... " >&6; } + cat confdefs.h - <<_ACEOF >conftest.$ac_ext +/* end confdefs.h. */ +#include +int +main () +{ +amd_dbgapi_status_t s = AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE; + + ; + return 0; +} +_ACEOF +if ac_fn_c_try_compile "$LINENO"; then : + amd_dbgapi_has_status_error_memory_unavailable=yes + { $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5 +$as_echo "yes" >&6; } +else + amd_dbgapi_has_status_error_memory_unavailable=no + { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5 +$as_echo "no" >&6; } +fi +rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext + CPPFLAGS="$save_CPPFLAGS" + + if test "x${amd_dbgapi_has_status_error_memory_unavailable}" = "xyes"; then + +$as_echo "#define AMD_DBGAPI_HAS_STATUS_ERROR_MEMORY_UNAVAILABLE 1" >>confdefs.h + + fi + elif test "$gdb_require_amd_dbgapi" = true -o "$with_amd_dbgapi" = yes; then # amd-dbgapi was not found and... # diff --git a/gdb/configure.ac b/gdb/configure.ac index e0117ede292..274d248a64d 100644 --- a/gdb/configure.ac +++ b/gdb/configure.ac @@ -368,6 +368,27 @@ if test "$gdb_require_amd_dbgapi" = true \ AC_MSG_ERROR([amd-dbgapi not supported for host ${gdb_host}]) ;; esac + + # Detect if AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE can be used. + save_CPPFLAGS="$CPPFLAGS" + CPPFLAGS="$CPPFLAGS $AMD_DBGAPI_CFLAGS" + AC_MSG_CHECKING([whether AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE is available]) + AC_COMPILE_IFELSE( + [AC_LANG_PROGRAM( + [[#include ]], + [[amd_dbgapi_status_t s = AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE;]] + )], + [amd_dbgapi_has_status_error_memory_unavailable=yes + AC_MSG_RESULT([yes])], + [amd_dbgapi_has_status_error_memory_unavailable=no + AC_MSG_RESULT([no])]) + CPPFLAGS="$save_CPPFLAGS" + + if test "x${amd_dbgapi_has_status_error_memory_unavailable}" = "xyes"; then + AC_DEFINE(AMD_DBGAPI_HAS_STATUS_ERROR_MEMORY_UNAVAILABLE, 1, + [Define if AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE is available.]) + fi + elif test "$gdb_require_amd_dbgapi" = true -o "$with_amd_dbgapi" = yes; then # amd-dbgapi was not found and... # -- 2.53.0