From: Simon Marchi <simon.marchi@efficios.com>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: [PATCH 14/16] gdbserver: remove fallback declarations of perror, vasprintf and vsnprintf
Date: Tue, 13 Oct 2026 11:36:00 -0400 [thread overview]
Message-ID: <20261013153657.1610298-15-simon.marchi@efficios.com> (raw)
In-Reply-To: <20261013153657.1610298-1-simon.marchi@efficios.com>
server.h declares perror, vasprintf and vsnprintf if configure did not
find a declaration for them. perror and vsnprintf are standard C++,
and libiberty.h already declares vasprintf and vsnprintf when the
system doesn't.
Remove the fallback declarations from server.h, and the
AC_CHECK_DECLS call from configure.ac.
Regenerate config.in and configure.
Change-Id: I6afe4a6fa610a37599b7b7d28628dea43b584892
---
gdbserver/config.in | 4 ----
gdbserver/configure | 32 --------------------------------
gdbserver/configure.ac | 2 --
gdbserver/server.h | 13 -------------
4 files changed, 51 deletions(-)
diff --git a/gdbserver/config.in b/gdbserver/config.in
index d0b609003800..7aae2f7398b5 100644
--- a/gdbserver/config.in
+++ b/gdbserver/config.in
@@ -58,10 +58,6 @@
/* Define to 1 if you have the declaration of `ffs', and to 0 if you don't. */
#undef HAVE_DECL_FFS
-/* Define to 1 if you have the declaration of `perror', and to 0 if you don't.
- */
-#undef HAVE_DECL_PERROR
-
/* Define to 1 if you have the declaration of `snprintf', and to 0 if you
don't. */
#undef HAVE_DECL_SNPRINTF
diff --git a/gdbserver/configure b/gdbserver/configure
index d695c6191e33..9555b15bd725 100755
--- a/gdbserver/configure
+++ b/gdbserver/configure
@@ -13228,38 +13228,6 @@ _ACEOF
-ac_fn_c_check_decl "$LINENO" "perror" "ac_cv_have_decl_perror" "$ac_includes_default"
-if test "x$ac_cv_have_decl_perror" = xyes; then :
- ac_have_decl=1
-else
- ac_have_decl=0
-fi
-
-cat >>confdefs.h <<_ACEOF
-#define HAVE_DECL_PERROR $ac_have_decl
-_ACEOF
-ac_fn_c_check_decl "$LINENO" "vasprintf" "ac_cv_have_decl_vasprintf" "$ac_includes_default"
-if test "x$ac_cv_have_decl_vasprintf" = xyes; then :
- ac_have_decl=1
-else
- ac_have_decl=0
-fi
-
-cat >>confdefs.h <<_ACEOF
-#define HAVE_DECL_VASPRINTF $ac_have_decl
-_ACEOF
-ac_fn_c_check_decl "$LINENO" "vsnprintf" "ac_cv_have_decl_vsnprintf" "$ac_includes_default"
-if test "x$ac_cv_have_decl_vsnprintf" = xyes; then :
- ac_have_decl=1
-else
- ac_have_decl=0
-fi
-
-cat >>confdefs.h <<_ACEOF
-#define HAVE_DECL_VSNPRINTF $ac_have_decl
-_ACEOF
-
-
ac_fn_c_check_type "$LINENO" "socklen_t" "ac_cv_type_socklen_t" "#include <sys/types.h>
#if HAVE_SYS_SOCKET_H
# include <sys/socket.h>
diff --git a/gdbserver/configure.ac b/gdbserver/configure.ac
index 1f461fa05727..2ae3e1c6e494 100644
--- a/gdbserver/configure.ac
+++ b/gdbserver/configure.ac
@@ -102,8 +102,6 @@ LIBS="$old_LIBS"
libiberty_INIT
-AC_CHECK_DECLS([perror, vasprintf, vsnprintf])
-
AC_CHECK_TYPES(socklen_t, [], [],
[#include <sys/types.h>
#if HAVE_SYS_SOCKET_H
diff --git a/gdbserver/server.h b/gdbserver/server.h
index bbba3650de7d..1a9e6ef62f8a 100644
--- a/gdbserver/server.h
+++ b/gdbserver/server.h
@@ -33,19 +33,6 @@ static_assert (sizeof (CORE_ADDR) >= sizeof (void *));
#include "gdbsupport/version.h"
-#if !HAVE_DECL_PERROR
-#ifndef perror
-extern void perror (const char *);
-#endif
-#endif
-
-#if !HAVE_DECL_VASPRINTF
-extern int vasprintf(char **strp, const char *fmt, va_list ap);
-#endif
-#if !HAVE_DECL_VSNPRINTF
-int vsnprintf(char *str, size_t size, const char *format, va_list ap);
-#endif
-
#ifdef IN_PROCESS_AGENT
# define PROG "ipa"
#else
--
2.56.0
next prev parent reply other threads:[~2026-10-13 15:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 15:35 [PATCH 00/16] Cleanup obsolete configure checks Simon Marchi
2026-10-13 15:35 ` [PATCH 01/16] gdb: don't check for sys/debugreg.h Simon Marchi
2026-10-13 15:35 ` [PATCH 02/16] gdb: don't check for sigsetmask and ttrace Simon Marchi
2026-10-13 15:35 ` [PATCH 03/16] gdbsupport: don't check for strstr declaration Simon Marchi
2026-10-13 15:35 ` [PATCH 04/16] gdbserver, gdbsupport: remove unneeded sys/procfs.h type checks Simon Marchi
2026-10-13 15:35 ` [PATCH 05/16] gdbserver: don't define HAVE_SYNC_BUILTINS Simon Marchi
2026-10-13 15:35 ` [PATCH 06/16] gdb: don't check for long double support Simon Marchi
2026-10-13 15:35 ` [PATCH 07/16] gdbserver: remove leftover Windows CE check in configure.ac Simon Marchi
2026-10-13 15:35 ` [PATCH 08/16] gdbsupport: don't check for memory.h Simon Marchi
2026-10-13 15:35 ` [PATCH 09/16] gdbserver: don't check for string.h Simon Marchi
2026-10-13 15:35 ` [PATCH 10/16] gdb, gdbserver: remove configure checks already done by GDB_AC_COMMON Simon Marchi
2026-10-13 15:35 ` [PATCH 11/16] gdb: remove redundant dlopen library search Simon Marchi
2026-10-13 15:35 ` [PATCH 12/16] gdb: don't check for long long support in the compiler Simon Marchi
2026-10-13 15:35 ` [PATCH 13/16] gdb: remove AC_C_CONST and AC_C_INLINE Simon Marchi
2026-10-13 15:36 ` Simon Marchi [this message]
2026-10-13 15:36 ` [PATCH 15/16] gdb: remove redundant snprintf declaration check Simon Marchi
2026-10-13 15:36 ` [PATCH 16/16] gdbserver, gdbsupport: don't check for signal.h, fcntl.h and locale.h Simon Marchi
2026-10-14 12:08 ` [PATCH 00/16] Cleanup obsolete configure checks Tom Tromey
2026-10-14 12:53 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261013153657.1610298-15-simon.marchi@efficios.com \
--to=simon.marchi@efficios.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox