From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id eSV3C3xKzmpKgAIAWB0awg (envelope-from ) for ; Tue, 13 Oct 2026 11:13:00 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=p/5dU77J; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=W2QKF9/J; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Soe8dck/; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Qkwe6/uI; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id F1C931E051; Tue, 13 Oct 2026 11:12:59 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 46EA91E04E for ; Tue, 13 Oct 2026 11:12:59 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6AB9D4BA7987 for ; Tue, 13 Oct 2026 15:12:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6AB9D4BA7987 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=p/5dU77J; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=W2QKF9/J; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Soe8dck/; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Qkwe6/uI Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 135DE4BA2E39 for ; Tue, 13 Oct 2026 15:12:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 135DE4BA2E39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 135DE4BA2E39 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791904354; cv=none; b=XvsEi0hkS02q72h87ib2mJOt43iAst7bi8h7qofJ75H9Opy31/gpkyKvIFxeLtTGeodvJlJjhnz+p81Tj4TAmpuWE2FhdRHwscn9MqzHFIqXHP24tTBlyB4xIhCoa/NhyrbKQbbi94aEjbOOpEh3nPueY6TZWtajlAXXkcltYCc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791904354; c=relaxed/simple; bh=8JGdTpgxEiUXvSlgpjsZdYLeFo9T+kmr3dN82ZCcXyo=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=AsZ2LpAkeHVlSEkI+U+YUAFm9U9Ru0MU3JCwbcUmPAiYsC82TP0jCjRhGDV9wEYAV99GcWcylMGayw5VdwmZTYHaQr8/HQ65g7QL5ceP0pGqTlNAMJT4S87JBuzf291xLjWlGHPo9/eHACLQ4OpSKFfd7iFufMIzTonU7foaEaU= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=p/5dU77J; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=W2QKF9/J; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Soe8dck/; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Qkwe6/uI DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 135DE4BA2E39 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id AF34921F92 for ; Tue, 13 Oct 2026 15:12:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1791904352; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=tRAnEVQ0laAgWgkuwvC5c3n98ZaKg1aX43qo79dVCAg=; b=p/5dU77JQ1yw3gHtJFbgMuahQJWysf1lsiQzMN5DeX2frV/NDevsyqLoLOPQKF2erVbC4d xYs/EbKxLNoMBREi50vmRsYjIz0oAubVCUNm22ydqxbr5uPsV70qkCysv7k9wJmrEdOjMK rGeaLkxyikUR5BJJOuoKdFeB016lxb0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1791904352; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=tRAnEVQ0laAgWgkuwvC5c3n98ZaKg1aX43qo79dVCAg=; b=W2QKF9/J/Ex/uTe83scbNoEgBpnbqCKrMkQqTleIRFbkhzfN9umTBzY9uii24jzmLQeXmd gwGv3EU5BJtQ9HCQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="Soe8dck/"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="Qkwe6/uI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1791904351; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=tRAnEVQ0laAgWgkuwvC5c3n98ZaKg1aX43qo79dVCAg=; b=Soe8dck/a8HANXAJrUNrWUoTSi2r/e8U1Y+9XmEUi3rHzovUD6hs+MQXgSpab8A0PQxR7V M1eXEKwpL1PanE5s/nTY3oM0qsRspYUsL/7He+FlS0walNGA7GEHzf+qBKmdihBs/Q2lT1 GMBIh7wYrOHda6YBJq6MeEtk/WVNyAE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1791904351; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=tRAnEVQ0laAgWgkuwvC5c3n98ZaKg1aX43qo79dVCAg=; b=Qkwe6/uIWyLNwFu9PtrUtAVNQDhyqq3lkrJ/YzqKvu9NasOjU92U3BXoxzUizrcbBlUMw4 jkmGDbVypiYYkCAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7AF18134B8 for ; Tue, 13 Oct 2026 15:12:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 0QSoFF9KzmppaQAAD6G6ig (envelope-from ) for ; Tue, 13 Oct 2026 15:12:31 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [pushed] [gdb/testsuite] Add isremote fallback Date: Tue, 13 Oct 2026 17:12:30 +0200 Message-ID: <20261013151230.1252959-1-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: AF34921F92 X-Rspamd-Action: no action X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; ARC_NA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; RCVD_TLS_ALL(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On openSUSE Leap 16.0 with dejagnu 1.6.3 both is_remote and isremote are supported. On openSUSE Leap 15.6 with dejagnu 1.6.1 only is_remote is supported. In a recent commit I added: ... proc remote_kill_spawn_id_p { board sig } { ... if {[isremote $board]} { ... which works fine with dejagnu 1.6.3 but with 1.6.1 I run into: ... UNRESOLVED: gdb.base/quit-live.exp: appear_how=run: extra_inferior=0: \ testcase aborted due to invalid command name: isremote ERROR: tcl error sourcing gdb.base/quit-live.exp. ERROR: invalid command name "isremote" ... The dejagnu sources 1.6.3 call is_remote "legacy", and dejagnu NEWS calls it deprecated, so I suppose it'll eventually disappear. Fix this by making sure that proc isremote is available. Instead, we could just replace isremote with is_remote in remote_kill_spawn_id_p, but that does nothing to prevent re-introduction of the same problem elsewhere. We could undefine proc isremote, but we'd just be forcing the user to use a deprecated function on newer platforms. Tested test-case gdb.base/quit-live.exp on both aforementioned configurations (x86_64-linux). --- gdb/testsuite/lib/future.exp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/gdb/testsuite/lib/future.exp b/gdb/testsuite/lib/future.exp index 44fc17b3f00..1bf4b35c1fe 100644 --- a/gdb/testsuite/lib/future.exp +++ b/gdb/testsuite/lib/future.exp @@ -759,6 +759,13 @@ if { [array size use_gdb_compile] != 0 } { unproc gdb_default_target_compile } +# Dejagnu versions before 1.6.3 don't define isremote. +if {[info procs isremote] == ""} { + proc isremote {board} { + return [is_remote $board] + } +} + # Various ccache versions provide incorrect debug info such as ignoring # different current directory, breaking GDB testsuite. set env(CCACHE_DISABLE) 1 base-commit: bad8b979b27e050b2b4db16a261f8a78e24b8aa2 -- 2.51.0