From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id fybXI/kszmrxtAEAWB0awg (envelope-from ) for ; Tue, 13 Oct 2026 09:07:05 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=X0dHS0iq; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=QoonR96p; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=X0dHS0iq; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=QoonR96p; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4AE3A1E051; Tue, 13 Oct 2026 09:07:05 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6079D1E04E for ; Tue, 13 Oct 2026 09:07:03 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CD3A34BA798A for ; Tue, 13 Oct 2026 13:07:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CD3A34BA798A Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=X0dHS0iq; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=QoonR96p; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=X0dHS0iq; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=QoonR96p Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id A91384BA7980 for ; Tue, 13 Oct 2026 13:06:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A91384BA7980 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A91384BA7980 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791896785; cv=none; b=jFqbV6KbhIuRL0VZtEZZwxf31ODag63wQcfjCJ2Cl0sKNCVkwUwGNS6EN03Behik8gjJwaFQ2KWeibqOIosSJqKfBykVwhUlDIxFVYVgQ3e8ZSlshgOpvLs28239LMMgCIBRyZQYG0teigFWbKKWDpmflAeD0GjrNR4NnGVD1l8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791896785; c=relaxed/simple; bh=oWhTTvmq92VaDBjl2y1Ts0u1MfA+tXR6v1JGeoQhcFg=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=e+pReNeTOKfmuQX/Be23myRlMZv4cu5fFn99BmdKY231CwfIifOcY10X2Fv52hh3iljYVssTU3ikJDEq2juWZbRRqAtRgp8MpOKcvy/VbMAzrmuY/3WXyoILxjWTZSC9Lw7WmTx3t7ftuuMlCkiUmfKv3gEpQVLrho3rG2zMIhU= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=X0dHS0iq; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=QoonR96p; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=X0dHS0iq; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=QoonR96p DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A91384BA7980 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DAE1C21EDF for ; Tue, 13 Oct 2026 13:06:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1791896775; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=mdI7Qh7yZuFayGZtmLk9mvAHvBX1CIcWaHf2hrllpHs=; b=X0dHS0iqxknnGY9S0b40rzuHMHUTObaQUZBWG1ldR6KIc2M53VEVB/+qkLxK1o0kii10th hI8fqlDBtcwFZlOgv+V1UKasdNF5tyAPyRN2M35p/SrLA7eJr2ISnLqbLnAiNMqDi8e1XV YsLbv1gCz715S3GMr7sDiSHQS1hC26I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1791896775; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=mdI7Qh7yZuFayGZtmLk9mvAHvBX1CIcWaHf2hrllpHs=; b=QoonR96pmoLM1MAsfEK3cs/fCm3XbOfm4yXK/8anVDXP9dMWytKl4SuUF7kcNVjSb0N9Rr FXGVCFsElJRwzZDw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=X0dHS0iq; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=QoonR96p DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1791896775; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=mdI7Qh7yZuFayGZtmLk9mvAHvBX1CIcWaHf2hrllpHs=; b=X0dHS0iqxknnGY9S0b40rzuHMHUTObaQUZBWG1ldR6KIc2M53VEVB/+qkLxK1o0kii10th hI8fqlDBtcwFZlOgv+V1UKasdNF5tyAPyRN2M35p/SrLA7eJr2ISnLqbLnAiNMqDi8e1XV YsLbv1gCz715S3GMr7sDiSHQS1hC26I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1791896775; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=mdI7Qh7yZuFayGZtmLk9mvAHvBX1CIcWaHf2hrllpHs=; b=QoonR96pmoLM1MAsfEK3cs/fCm3XbOfm4yXK/8anVDXP9dMWytKl4SuUF7kcNVjSb0N9Rr FXGVCFsElJRwzZDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A252B134B8 for ; Tue, 13 Oct 2026 13:06:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id C/n8F8cszmqnWQAAD6G6ig (envelope-from ) for ; Tue, 13 Oct 2026 13:06:15 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [pushed] [gdb/testsuite] Fix FAIL in gdb.tui/tui-mode-switch.exp Date: Tue, 13 Oct 2026 15:06:14 +0200 Message-ID: <20261013130614.1156344-1-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: DAE1C21EDF X-Rspamd-Action: no action X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.982]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_EQ_ENVFROM(0.00)[]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCVD_TLS_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,gdb.tui:url,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,sourceware.org:url]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; TO_DN_NONE(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org With test-case gdb.tui/tui-mode-switch.exp I ran into: ... PASS: $exp: enter TUI ^[[?1006;1000l^[[12;1H^[[?1049l^[[23;0;0t^M^[[?1l^[>PASS: $exp: exit TUI Box Dump (40 x 1) @ (0, 11): 11 Box Dump (40 x 1) @ (0, 11): 11 Box Dump (40 x 1) @ (0, 11): 11 Box Dump (40 x 1) @ (0, 11): 11 Box Dump (40 x 1) @ (0, 11): 11 Box Dump (40 x 1) @ (0, 11): 11 b(gdb) bBox Dump (40 x 1) @ (0, 11): 11 b(gdb) b WARNING: timeout in accept_gdb_output Screen Dump (size 40 columns x 12 rows, cursor at column 8, row 11): 0 (gdb) 1 (gdb) 2 (gdb) 3 (gdb) 4 (gdb) 5 (gdb) 6 (gdb) 7 (gdb) 8 (gdb) 9 (gdb) 10 (gdb) 11 b(gdb) b FAIL: $exp: type b ... The FAIL happens in this part of the test: ... # Enter TUI. send_gdb "\030\001" gdb_assert { [Term::wait_for ""] } "enter TUI" # Exit TUI. send_gdb "\030\001" gdb_assert { [Term::wait_for ""] } "exit TUI" # Type b. send_gdb "b" ... It's a bit easier to see what happens if we switch on logging in Term::_log using verbose -log: ... PASS: $exp: enter TUI ^[[?1006;1000l^[[12;1H^[[?1049l^[[23;0;0t^M^[[?1l^[>+++ wait_for: ESC +++ wait_for: CSI +++ wait_for: _csi_0x3f_l <<>> +++ ignored: Disable SGR Mouse Mode +++ ignored: Don't send Mouse X & Y on button press and release PASS: $exp: exit TUI ... The wait_for for "exit TUI" triggers on the prompt of the TUI that's still there, so "b" is typed too early. >From there on, there's a short window between endwin in tui_disable and emitting the prompt where echo is enabled. If the b arrives in that window, we get "b(gdb) b". We can reproduce the FAIL reliably by adding a 200ms sleep after endwin in tui_disable. Fix this by waiting on the CLI prompt on the line where we're expecting it. I checked that reverting commit ee3c07a28be ("[gdb/tui] Clear readline buffer on switching to TUI") still makes the test-case fail. Tested on x86_64-linux, both with and without the reproducer delay. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34737 --- gdb/testsuite/gdb.tui/tui-mode-switch.exp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.tui/tui-mode-switch.exp b/gdb/testsuite/gdb.tui/tui-mode-switch.exp index 250b557125e..f4e3bb78245 100644 --- a/gdb/testsuite/gdb.tui/tui-mode-switch.exp +++ b/gdb/testsuite/gdb.tui/tui-mode-switch.exp @@ -39,7 +39,8 @@ gdb_assert { [Term::wait_for ""] } "enter TUI" # Exit TUI. send_gdb "\030\001" -gdb_assert { [Term::wait_for ""] } "exit TUI" +gdb_assert { [Term::wait_for_region_contents {*}$line "^$gdb_prompt "] } \ + "exit TUI" # Type b. send_gdb "b" base-commit: 559b2fef9f095796b2bc9adb8cb47eaee822fe27 -- 2.51.0