From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mTZHF0EUxmo0NA0AWB0awg (envelope-from ) for ; Wed, 07 Oct 2026 05:43:29 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=W4uVtf5U; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=gHWg08Gq; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ZyoTKPu9; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=v31o7I6n; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 517C91E051; Wed, 07 Oct 2026 05:43:29 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A0B391E04E for ; Wed, 07 Oct 2026 05:43:28 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E130C4BA2E29 for ; Wed, 7 Oct 2026 09:43:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E130C4BA2E29 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=W4uVtf5U; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=gHWg08Gq; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ZyoTKPu9; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=v31o7I6n Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 022AA4BA2E19 for ; Wed, 7 Oct 2026 09:41:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 022AA4BA2E19 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 022AA4BA2E19 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791366068; cv=none; b=J/gFTVQdn3iFPWLNdGkrtONFCaiJmQneTJWTUCSdaNrth+Uoi2aaZswAC5rEf8PHpgmMRxSN5vhU4VUmXhGBDgX2/G35Dyv20woxLscWyW3p4YCegztgpbDot2BffIdJ6cp/oy8JWZgLfUkrk3Byu+Gy3PD9SnVxjAwTTNb9fZs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791366068; c=relaxed/simple; bh=B6KdMdUVvJKKN8hZzXhaK1/hu1eZe7NuLnbDlkBhzks=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=GN0Vs7e2EzPd3vIFVSLkC6R/RIKIWcptUfTlBtVWvSta5muFji4bjg7PE+SUboELf8e+YHPBY1UAIb2oqXUu9wP1dgDIfEBHnzOdJnCFmM+EdZuY/xX4D8lnkz1qJKJvswlAmY/39xSEUGfM5WFEZ3IhaKSxgui0xKvREeGRrxg= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=W4uVtf5U; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=gHWg08Gq; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ZyoTKPu9; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=v31o7I6n DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 022AA4BA2E19 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2C11921F56 for ; Wed, 7 Oct 2026 09:40:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1791366063; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IEpgmYHHCH6a1+AAJsdPdfohIHtkKRJW4Kmj2N/cAYE=; b=W4uVtf5UVnMboyebgi0poInZ6AL/WHsFXUZ73i3m3dIhjuM6f58gwmOXQCnTRDnyOvAHCH eHe/vKMyleacslXZDKkvVJZJB+cV3oEj4NOFnl/3Vdaa/IS4tXwS0X7klySWHvv9aia85E w8bxB472KRnbWiZocP+GEZodc115gUw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1791366063; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IEpgmYHHCH6a1+AAJsdPdfohIHtkKRJW4Kmj2N/cAYE=; b=gHWg08Gqys60W+orMqDx2JcEJuz1BExrtWvYmBOaDGSYo2TuBzdGBPnbTXLJMqHwdvqM/Q pSsumYSOn6SWGCBA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ZyoTKPu9; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=v31o7I6n DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1791366059; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IEpgmYHHCH6a1+AAJsdPdfohIHtkKRJW4Kmj2N/cAYE=; b=ZyoTKPu9FYPdAxeV7FLH6dPDSH8roInw1K+wPjdU9ifVjPTaIaEZrbWBMrbORz8Aq+KFuA Jw+Qjx9X5NEyutIwfRZ9kbF1iHbWHexcFtmxBXePpRh8vziHmABfadEuUei+gWWfI/HbAp p0/vuwMA7T56QBCPkyZITMqAj5BVElE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1791366059; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IEpgmYHHCH6a1+AAJsdPdfohIHtkKRJW4Kmj2N/cAYE=; b=v31o7I6nuqLN3wKY/+8fntM5CTE79S6a6UoN3OK5GQoWd3r8eA0VL/owVhjK58Hipnlynk Y+Y6Jr2oS5rlaxBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id EB7D213B95 for ; Wed, 7 Oct 2026 09:40:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id JEXHFKoTxmo3EwAAD6G6ig:T5 (envelope-from ) for ; Wed, 07 Oct 2026 09:40:58 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH v4 04/11] [gdb/tui] Fix buglet in tui_find_disassembly_address Date: Wed, 7 Oct 2026 11:40:50 +0200 Message-ID: <20261007094057.1811886-5-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20261007094057.1811886-1-tdevries@suse.de> References: <20261007094057.1811886-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: 2C11921F56 X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MIME_TRACE(0.00)[0:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_TLS_ALL(0.00)[]; TO_DN_NONE(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org In commit 72535eb14bd ("[gdb/tui] Fix segfault in tui_find_disassembly_address"), in a loop in tui_find_disassembly_address I added: ... /* Disassemble forward. */ next_addr = tui_disassemble (gdbarch, asm_lines, new_low, max_lines); + if (asm_lines.empty ()) + break; last_addr = asm_lines.back ().addr; ... In retrospect, I think I missed something there. After the loop, new_low may be returned: ... if (asm_lines.size () < max_lines) { if (!possible_new_low.has_value ()) return new_low; ... so we'd be returning an address from where in fact we can't disassemble. Fix this by reverting to prev_low in this case. --- gdb/tui/tui-disasm.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gdb/tui/tui-disasm.c b/gdb/tui/tui-disasm.c index a6cf12ba9c2..c242614be45 100644 --- a/gdb/tui/tui-disasm.c +++ b/gdb/tui/tui-disasm.c @@ -251,7 +251,10 @@ tui_find_disassembly_address (struct gdbarch *gdbarch, CORE_ADDR pc, int from) /* Disassemble forward. */ next_addr = tui_disassemble (gdbarch, asm_lines, new_low, max_lines); if (asm_lines.empty ()) - break; + { + new_low = prev_low; + break; + } last_addr = asm_lines.back ().addr; /* If disassembling from the current value of NEW_LOW reached PC -- 2.51.0