[PATCH v4 00/11] [gdb/tui] Some section hole handling fixes

[Tom de Vries <tdevries@suse.de>]

This series consists of 11 patches.

The first four deal with tui_find_disassembly_address:
- the first two do refactoring
- the third is an optimization
- the fourth fixes a buglet.

The fifth factors out update_section_map.

The sixth adds section_addrmap.

The seventh extends addrmap::find with low/high results.

The eight makes gdb_disassembly return the number of disassembled insns.

The ninth patch fixes PR34617, for both TUI and CLI.

The tenth patch prevents stopping disassembly at section holes for CLI
and TUI, fixing PR34399.

The eleventh patch skips over data sections.  This is an RFC.

Changes in v2:
- add patch fixing tui_disassemble comment after review comment
- drop restrictive fix for PR tui/34399 after review comments
- add patches implementing an enabling fix for PR tui/34399.

Changes in v3:
- committed the first three patches of v2
- drop the find_pc_section refactoring approach of the 4th and 5th patches of
  v2
- instead add three refactoring/infrastructure patches:
  - factor out update_section_map
  - add section_addrmap
  - extend addrmap::find with low/high results
- rework the last two patches into these two patches:
  - handle sections when disassembling
  - don't stop disassembly at section hole

Changes in v4:
- add first four patches dealing with tui_find_disassembly_address
- factor out "makes gdb_disassembly return the number of disassembled
  insns" patch out of another patch
- add RFC patch
- add test-case gdb.base/disasm-section-sync.exp in
  "Handle sections when disassembling"
- replace disassemble_skip_sections with disassemble_section_p
- fix some style nits
- do less re-calculation of address map

Versions:
- v1 https://sourceware.org/pipermail/gdb-patches/2026-August/229584.html
- v2 https://sourceware.org/pipermail/gdb-patches/2026-September/230207.html
- v3 https://sourceware.org/pipermail/gdb-patches/2026-September/230515.html

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34399
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34617

Tom de Vries (11):
  [gdb/tui] Use early exit in tui_find_disassembly_address
  [gdb/tui] Make low_prev loop-local in tui_find_disassembly_address
  [gdb/tui] Disassemble less often in tui_find_disassembly_address
  [gdb/tui] Fix buglet in tui_find_disassembly_address
  [gdb] Factor out update_section_map
  [gdb] Add section_addrmap
  [gdb] Extend addrmap::find with low/high results
  [gdb] Make gdb_disassembly return number of insns
  [gdb] Handle sections when disassembling
  [gdb] Don't stop disassembly at section hole
  [RFC, gdb/tui] Don't scroll into non-code sections

 gdb/addrmap.c                                 |  78 +++-
 gdb/addrmap.h                                 |  23 +-
 gdb/cli/cli-cmds.c                            |  11 +-
 gdb/disasm.c                                  | 125 ++++++-
 gdb/disasm.h                                  |  20 +-
 gdb/objfiles.c                                |  62 +++-
 gdb/objfiles.h                                |   6 +
 gdb/testsuite/gdb.base/disasm-section-sync.S  |  47 +++
 .../gdb.base/disasm-section-sync.exp          |  28 ++
 gdb/tui/tui-disasm.c                          | 338 +++++++++++-------
 gdb/tui/tui-disasm.h                          |   3 +-
 gdb/tui/tui-source.c                          |   2 +-
 gdb/tui/tui-source.h                          |   3 +-
 gdb/tui/tui-winsource.c                       |  13 +-
 gdb/tui/tui-winsource.h                       |  12 +-
 gdb/tui/tui.c                                 |   4 +-
 gdb/tui/tui.h                                 |   3 +-
 17 files changed, 583 insertions(+), 195 deletions(-)
 create mode 100644 gdb/testsuite/gdb.base/disasm-section-sync.S
 create mode 100644 gdb/testsuite/gdb.base/disasm-section-sync.exp


base-commit: b8a700f22bfa79ed841ec350938d0b310a5048b9
-- 
2.51.0