From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4c5UM9aNw2r1KzwAWB0awg (envelope-from ) for ; Mon, 05 Oct 2026 07:45:26 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=pDfzIA4d; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id CE6721E050; Mon, 05 Oct 2026 07:45:26 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 730211E04F for ; Mon, 05 Oct 2026 07:45:24 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1DEF64BA79BE for ; Mon, 5 Oct 2026 11:45:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1DEF64BA79BE Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=pDfzIA4d Received: from mail-dy2-x0f.google.com (mail-dy2-x0f.google.com [IPv6:2607:f8b0:4864:36::f]) by sourceware.org (Postfix) with ESMTPS id A2E904BA79A7 for ; Mon, 5 Oct 2026 11:44:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A2E904BA79A7 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A2E904BA79A7 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:36::f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791200695; cv=none; b=DvqU33N3T4FZn9uoQfxkajUl8Jbm8TLUP163nIGKJieU/sae8rNIqfB9nr/atiqzAMbXU5tLTUH74ULW4RrbhohD83qy9iu85Il25iIh5ktrKxdhP8Cx+I1sr3oPq8JEv3S27B0TDKTh3Jx0MqKtLf+dahtMVlivhJ1b725WMxE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791200695; c=relaxed/simple; bh=QvVRnVpu2tDcK6U5XmgsPwfZiGKfSOa/ko8BNCm6xyw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=HFhH2E+Kvoe8+fKU8TrZ0L4Grd15/HdVe2Vjeh6FNujiaKF8CGtBz8XSj7A52A1NRHFKTBq2akDq7AgdZ6IJunaE0ZBagu4dfYhBM/oj5+Gm19ysbzsW06B5RokTuchaks00qYnLYlqP/wPn9xl9n4trOQIzXtm+EpxItunBtK8= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=pDfzIA4d DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A2E904BA79A7 Received: by mail-dy2-x0f.google.com with SMTP id 5a478bee46e88-34b3a9cd8edso780186eec.1 for ; Mon, 05 Oct 2026 04:44:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791200695; x=1791805495; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=NYjjY9rZM4uAbvO2Qy2jNX3QTB8aX8KkLZ9j8zDa8sw=; b=pDfzIA4d8XxcuO7+ghLYpVhnezk/SOdN3CBrtufPIV1GgtPLM69dbejClpewW8ej9E G/dSyDJSu4MBDfVF7gi5w7oQJ7z1sWUmk4dAaANBQ5toVREdTcHDfu3qjoTc4dDOSTQg IKQZpg1kAONJeYHxxB3CN8UcRMEDWVtRCFyoGRuvrnMwXDbgBIgwhcdIMqJtem5Y2LmK QnGUrU6PmT0aWphEHgOodnAT5xDRVl1Qy/NgCJImM68ll5kz9Q8emM+N4REV2nz5HirS cD09muBOEPVwGPMmQUnJrj7nE24ZedHMGKn7zeKHKuPXR/JnfmsEzHjRHZAlfz8k837y 6vOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791200695; x=1791805495; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NYjjY9rZM4uAbvO2Qy2jNX3QTB8aX8KkLZ9j8zDa8sw=; b=wbcGfSE/eRIeCrE+hOs6UyZH686QXIJI39ySzkHc8QYBu6bHdA4HSKS4P3l6vYWlo2 kpfSHAw0VQwUKPsxZwV7waB1lMAzy4wKY2PDUmqeEJKObcCJ9UHecfhG7a+bxrqsIhvj WYn40djWXOqyZD9D/W0idSVfxMVuOogAIpJyu143joCxB08Qq3I7p/1nfM9OlrGFzmOJ CMBudE2dg9IBxy3kIt6746UYqIplFNYYkzIs6FYYBnro5N6XWaWEptpNc+n84vi3shbv CfaXB+R3pEERQKBXLr05dwcHQc+uf3xAj+qtqIUJDzevRZ5Yxtd3mxU//OdFAi4Sc7AO fD1g== X-Gm-Message-State: AFuF++kHDYm4SKIAr6thmE97QT2UnCZ4ZHTFR2Eo4tUIKEV7VgKntAkZ nTo3nzMUeau9hkBzJABs86YrOfzlBVnfyxyGhllIpuiMQ8qeLVcU8K7v X-Gm-Gg: AYBFou3wQODkYScDr+jL4WxHZeILPQzCos5/ULUmaByYCHbBvGvUCIC5px9fTqqEtyH 13CpR4Ad7S8pqlr4DWNFWbgunEVRZiMP//h9NJa2zKJuayaYHNuFngZnJDUz04qzNtVZwvULlOD KjzZhabm0sDsOGywwlClEDb89GcFehEXaoEX9PJxeuj6qUq8oaJBxavR2iNqOaKqtsgNQ02456L flJNcHw4yFhEd6NTmOBR/v1l7AzSmc9XQG0y3JqTqvQwgxmg787hGXhD0ddCFg4JotcP9GBRIb0 lbdpkGCXm3Km+DNSobyA6IX6YL+LVet8k+1fYPQ+qvhL4bNipJVzvMLNhkMAczoklzXpbYIhQ5g sg4817y3NEFv20m9wAt+h+dzO8iBFrPX3gyGu3jRQGOSi1ahe0iir5VAsm2a6qxbVvpzvWXHe99 vLNK4lk2FRbf50VRc/y7n1RVcF4ksFwbwvrVeYmbsjw0RkZtI6Z8AA+gEbOw4T0AvAP0qnK6W6t sEkdJBy6kTK353m04MZfPCX0A8= X-Received: by 2002:a05:693c:6392:10b0:34c:375c:5387 with SMTP id 5a478bee46e88-34f21961094mr11991673eec.10.1791200694291; Mon, 05 Oct 2026 04:44:54 -0700 (PDT) Received: from localhost.localdomain ([122.171.21.153]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3512718a18esm16378379eec.17.2026.10.05.04.44.51 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 05 Oct 2026 04:44:53 -0700 (PDT) From: Aditya Vidyadhar Kamath To: ulrich.weigand@de.ibm.com, simon.marchi@polymtl.ca, tom@tromey.com Cc: gdb-patches@sourceware.org, Aditya.Kamath1@ibm.com, sangamesh.swamy@in.ibm.com, Aditya Vidyadhar Kamath Subject: [PATCH v4 1/4] Fix styles in aix-thread.c to follow GNU style code. Date: Mon, 5 Oct 2026 17:14:36 +0530 Message-ID: <20261005114435.31454-2-akamath996@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org From: Aditya Vidyadhar Kamath https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards As per GDB code guidelines making minor changes to follow before cleaning up aix-thread.c legacy code. The following things were done: 1: 80 length column maintained now. 2: Some functions changed from function() to function () 3: Switch case also changed [only style] to follow the guideline. --- gdb/aix-thread.c | 91 ++++++++++++++++++++++++++---------------------- 1 file changed, 49 insertions(+), 42 deletions(-) diff --git a/gdb/aix-thread.c b/gdb/aix-thread.c index 647ed063671..65b9c5f7479 100644 --- a/gdb/aix-thread.c +++ b/gdb/aix-thread.c @@ -299,16 +299,16 @@ ptrace_check (int req, int id, int ret) req, id, ret, errno); return ret == -1 ? 0 : 1; } - break; - case PTT_READ_VEC: - case PTT_READ_VSX: - if (debug_aix_thread) - gdb_printf (gdb_stdlog, - "ptrace (%d, %d) = %d (errno = %d)\n", - req, id, ret, errno); - if (ret == -1) - return -1; - break; + break; + case PTT_READ_VEC: + case PTT_READ_VSX: + if (debug_aix_thread) + gdb_printf (gdb_stdlog, + "ptrace (%d, %d) = %d (errno = %d)\n", + req, id, ret, errno); + if (ret == -1) + return -1; + break; } error (_("aix-thread: ptrace (%d, %d) returned %d (errno = %d %s)"), req, id, ret, errno, safe_strerror (errno)); @@ -368,7 +368,8 @@ pid_to_prc (ptid_t *ptidp) the address of SYMBOLS[].name. */ static int -pdc_symbol_addrs (pthdb_user_t user_current_pid, pthdb_symbol_t *symbols, int count) +pdc_symbol_addrs (pthdb_user_t user_current_pid, pthdb_symbol_t *symbols, + int count) { int i; char *name; @@ -447,13 +448,13 @@ pdc_read_regs (pthdb_user_t user_current_pid, if (!ptrace64aix (PTT_READ_GPRS, tid, (unsigned long) gprs64, 0, NULL)) memset (gprs64, 0, sizeof (gprs64)); - memcpy (context->gpr, gprs64, sizeof(gprs64)); + memcpy (context->gpr, gprs64, sizeof (gprs64)); } else { if (!ptrace32 (PTT_READ_GPRS, tid, (uintptr_t) gprs32, 0, NULL)) memset (gprs32, 0, sizeof (gprs32)); - memcpy (context->gpr, gprs32, sizeof(gprs32)); + memcpy (context->gpr, gprs32, sizeof (gprs32)); } } @@ -462,7 +463,7 @@ pdc_read_regs (pthdb_user_t user_current_pid, { if (!ptrace32 (PTT_READ_FPRS, tid, (uintptr_t) fprs, 0, NULL)) memset (fprs, 0, sizeof (fprs)); - memcpy (context->fpr, fprs, sizeof(fprs)); + memcpy (context->fpr, fprs, sizeof (fprs)); } /* Special-purpose registers. */ @@ -473,49 +474,49 @@ pdc_read_regs (pthdb_user_t user_current_pid, if (!ptrace64aix (PTT_READ_SPRS, tid, (unsigned long) &sprs64, 0, NULL)) memset (&sprs64, 0, sizeof (sprs64)); - memcpy (&context->msr, &sprs64, sizeof(sprs64)); + memcpy (&context->msr, &sprs64, sizeof (sprs64)); } else { if (!ptrace32 (PTT_READ_SPRS, tid, (uintptr_t) &sprs32, 0, NULL)) memset (&sprs32, 0, sizeof (sprs32)); - memcpy (&context->msr, &sprs32, sizeof(sprs32)); + memcpy (&context->msr, &sprs32, sizeof (sprs32)); } } /* vector registers. */ __vmx_context_t vmx; - if (__power_vmx() && (flags & PTHDB_FLAG_REGS)) + if (__power_vmx () && (flags & PTHDB_FLAG_REGS)) { if (data->arch64) { if (!ptrace64aix (PTT_READ_VEC, tid, (long long) &vmx, 0, 0)) memset (&vmx, 0, sizeof (vmx)); - memcpy (&context->vmx, &vmx, sizeof(__vmx_context_t)); + memcpy (&context->vmx, &vmx, sizeof (__vmx_context_t)); } else { if (!ptrace32 (PTT_READ_VEC, tid, (long long) &vmx, 0, 0)) memset (&vmx, 0, sizeof (vmx)); - memcpy (&context->vmx, &vmx, sizeof(__vmx_context_t)); + memcpy (&context->vmx, &vmx, sizeof (__vmx_context_t)); } } /* vsx registers. */ __vsx_context_t vsx; - if (__power_vsx() && (flags & PTHDB_FLAG_REGS)) + if (__power_vsx () && (flags & PTHDB_FLAG_REGS)) { if (data->arch64) { if (!ptrace64aix (PTT_READ_VSX, tid, (long long) &vsx, 0, 0)) memset (&vsx, 0, sizeof (vsx)); - memcpy (&context->vsx, &vsx, sizeof(__vsx_context_t)); + memcpy (&context->vsx, &vsx, sizeof (__vsx_context_t)); } else { if (!ptrace32 (PTT_READ_VSX, tid, (long long) &vsx, 0, 0)) memset (&vsx, 0, sizeof (vsx)); - memcpy (&context->vsx, &vsx, sizeof(__vsx_context_t)); + memcpy (&context->vsx, &vsx, sizeof (__vsx_context_t)); } } return 0; @@ -576,7 +577,7 @@ pdc_write_regs (pthdb_user_t user_current_pid, } /* vector registers. */ - if (__power_vmx() && (flags & PTHDB_FLAG_REGS)) + if (__power_vmx () && (flags & PTHDB_FLAG_REGS)) { if (data->arch64) ptrace64aix (PTT_WRITE_VEC, tid, (unsigned long) &context->vmx, 0, 0); @@ -585,7 +586,7 @@ pdc_write_regs (pthdb_user_t user_current_pid, } /* vsx registers. */ - if (__power_vsx() && (flags & PTHDB_FLAG_REGS)) + if (__power_vsx () && (flags & PTHDB_FLAG_REGS)) { if (data->arch64) ptrace64aix (PTT_WRITE_VSX, tid, (unsigned long) &context->vsx, 0, 0); @@ -636,7 +637,8 @@ pdc_write_data (pthdb_user_t user_current_pid, void *buf, if (debug_aix_thread) gdb_printf (gdb_stdlog, - "pdc_write_data (user_current_pid = %ld, buf = 0x%lx, addr = %s, len = %ld)\n", + "pdc_write_data (user_current_pid = %ld, buf = 0x%lx," + " addr = %s, len = %ld)\n", user_current_pid, (long) buf, hex_string (addr), len); { @@ -682,7 +684,8 @@ pdc_realloc (pthdb_user_t user_current_pid, void *buf, size_t len, void **bufp) { if (debug_aix_thread) gdb_printf (gdb_stdlog, - "pdc_realloc (user_current_pid = %ld, buf = 0x%lx, len = %ld, bufp = 0x%lx)\n", + "pdc_realloc (user_current_pid = %ld, buf = 0x%lx," + " len = %ld, bufp = 0x%lx)\n", user_current_pid, (long) buf, len, (long) bufp); *bufp = xrealloc (buf, len); if (debug_aix_thread) @@ -1268,7 +1271,8 @@ supply_sprs32 (struct regcache *regcache, function. */ static void -fetch_regs_user_thread (struct regcache *regcache, pthdb_pthread_t pdtid) +fetch_regs_user_thread (struct regcache *regcache, + pthdb_pthread_t pdtid) { struct gdbarch *gdbarch = regcache->arch (); ppc_gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); @@ -1381,7 +1385,7 @@ fetch_regs_kernel_thread (struct regcache *regcache, int regno, else ret = ptrace32 (PTT_READ_VEC, tid, (uintptr_t) &vmx, 0, 0); if (ret < 0) - memset(&vmx, 0, sizeof(__vmx_context_t)); + memset (&vmx, 0, sizeof (__vmx_context_t)); for (i = 0; i < ppc_num_vrs; i++) regcache->raw_supply (tdep->ppc_vr0_regnum + i, &(vmx.__vr[i])); regcache->raw_supply (tdep->ppc_vrsave_regnum, &(vmx.__vrsave)); @@ -1398,7 +1402,7 @@ fetch_regs_kernel_thread (struct regcache *regcache, int regno, else ret = ptrace32 (PTT_READ_VSX, tid, (long long) &vsx, 0, 0); if (ret < 0) - memset(&vsx, 0, sizeof(__vsx_context_t)); + memset (&vsx, 0, sizeof (__vsx_context_t)); for (i = 0; i < ppc_num_vshrs; i++) regcache->raw_supply (tdep->ppc_vsr0_upper_regnum + i, &(vsx.__vsr_dw1[i])); } @@ -1461,7 +1465,7 @@ aix_thread_target::fetch_registers (struct regcache *regcache, int regno) { thread = current_inferior ()->find_thread (regcache->ptid ()); aix_thread_info *priv = get_aix_thread_info (thread); - tid = regcache->ptid().lwp (); + tid = regcache->ptid ().lwp (); if (tid == PTHDB_INVALID_TID) fetch_regs_user_thread (regcache, priv->pdtid); @@ -1480,9 +1484,10 @@ fill_altivec (const struct regcache *regcache, __vmx_context_t *vmx) int regno; for (regno = 0; regno < ppc_num_vrs; regno++) - if (REG_VALID == regcache->get_register_status (tdep->ppc_vr0_regnum + regno)) + if (REG_VALID == regcache->get_register_status + (tdep->ppc_vr0_regnum + regno)) regcache->raw_collect (tdep->ppc_vr0_regnum + regno, - &(vmx->__vr[regno])); + &(vmx->__vr[regno])); if (REG_VALID == regcache->get_register_status (tdep->ppc_vrsave_regnum)) regcache->raw_collect (tdep->ppc_vrsave_regnum, &(vmx->__vrsave)); @@ -1500,7 +1505,8 @@ fill_vsx (const struct regcache *regcache, __vsx_context_t *vsx) int regno; for (regno = 0; regno < ppc_num_vshrs; regno++) - if (REG_VALID == regcache->get_register_status ( tdep->ppc_vsr0_upper_regnum + regno)) + if (REG_VALID == regcache->get_register_status + (tdep->ppc_vsr0_upper_regnum + regno)) regcache->raw_collect (tdep->ppc_vsr0_upper_regnum + regno, &(vsx->__vsr_dw1[0]) + regno); } @@ -1630,7 +1636,8 @@ fill_sprs32 (const struct regcache *regcache, but I doubt it's worth the effort. */ static void -store_regs_user_thread (const struct regcache *regcache, pthdb_pthread_t pdtid) +store_regs_user_thread (const struct regcache *regcache, + pthdb_pthread_t pdtid) { struct gdbarch *gdbarch = regcache->arch (); ppc_gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); @@ -1656,9 +1663,9 @@ store_regs_user_thread (const struct regcache *regcache, pthdb_pthread_t pdtid) /* Fill altivec-registers. */ - if (__power_vmx()) + if (__power_vmx ()) { - memset(&vmx, 0, sizeof(__vmx_context_t)); + memset (&vmx, 0, sizeof (__vmx_context_t)); for (i = 0; i < ppc_num_vrs; i++) if (REG_VALID == regcache->get_register_status (tdep->ppc_vr0_regnum + i)) { @@ -1674,9 +1681,9 @@ store_regs_user_thread (const struct regcache *regcache, pthdb_pthread_t pdtid) /* Fill vsx registers. */ - if (__power_vsx()) + if (__power_vsx ()) { - memset(&vsx, 0, sizeof(__vsx_context_t)); + memset (&vsx, 0, sizeof (__vsx_context_t)); for (i = 0; i < ppc_num_vshrs; i++) if (REG_VALID == regcache->get_register_status (tdep->ppc_vsr0_regnum + i)) { @@ -1866,7 +1873,7 @@ store_regs_kernel_thread (const struct regcache *regcache, int regno, && regno <= tdep->ppc_vrsave_regnum))) { __vmx_context_t vmx; - if (__power_vmx()) + if (__power_vmx ()) { if (data->arch64) ret = ptrace64aix (PTT_READ_VEC, tid, (long long) &vmx, 0, 0); @@ -1874,7 +1881,7 @@ store_regs_kernel_thread (const struct regcache *regcache, int regno, ret = ptrace32 (PTT_READ_VEC, tid, (long long) &vmx, 0, 0); if (ret > 0) { - fill_altivec(regcache, &vmx); + fill_altivec (regcache, &vmx); if (data->arch64) ret = ptrace64aix (PTT_WRITE_VEC, tid, (long long) &vmx, 0, 0); else @@ -1887,11 +1894,11 @@ store_regs_kernel_thread (const struct regcache *regcache, int regno, /* VSX registers. */ if (tdep->ppc_vsr0_upper_regnum != -1 && (regno == -1 - || (regno >=tdep->ppc_vsr0_upper_regnum + || (regno >= tdep->ppc_vsr0_upper_regnum && regno < tdep->ppc_vsr0_upper_regnum + ppc_num_vshrs))) { __vsx_context_t vsx; - if (__power_vsx()) + if (__power_vsx ()) { if (data->arch64) ret = ptrace64aix (PTT_READ_VSX, tid, (long long) &vsx, 0, 0); -- 2.51.2