From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SXb+D3Bzw2oqpzsAWB0awg (envelope-from ) for ; Mon, 05 Oct 2026 05:52:48 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=vrany.io header.i=@vrany.io header.a=rsa-sha256 header.s=protonmail header.b=KHVa2MVj; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1BD0B1E050; Mon, 05 Oct 2026 05:52:48 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A06BF1E04E for ; Mon, 05 Oct 2026 05:52:45 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 049E94BA2E3A for ; Mon, 5 Oct 2026 09:52:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 049E94BA2E3A Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=vrany.io header.i=@vrany.io header.a=rsa-sha256 header.s=protonmail header.b=KHVa2MVj Received: from mail-4398.protonmail.ch (mail-4398.protonmail.ch [185.70.43.98]) by sourceware.org (Postfix) with ESMTPS id 037B84BA2E3E for ; Mon, 5 Oct 2026 09:52:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 037B84BA2E3E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=vrany.io Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vrany.io ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 037B84BA2E3E Authentication-Results: sourceware.org; arc=none smtp.remote-ip=185.70.43.98 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791193941; cv=none; b=eCgOXrkMaFhVAVP5Br/pVVTKiTTC2OQIRGxjw9LG3G538w+0IJvOPfgTubYYNwy4IuvetPvZ7PTZyWWkwe/SdOuthyhSEydmkjeom6HgZeMQ+ZpOJabKvD2PGAl3a4i+JcABFUEgzjif7+9TUgW1/R2lD3JLBTzrh3x4XD6JL/8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791193941; c=relaxed/simple; bh=fFvsyZM0UQrJ08cEZ5GwHVeuNtzlwfrxSVY2JcTZY8A=; h=DKIM-Signature:Date:To:From:Subject:Message-ID:MIME-Version; b=WezDxvMvVQbORHzjEuyKfh1QEdyt5L+U2pkLsL4bO1TtEBLcKOa14WTsv8eEiyTK0fjyyyHf09tjjxACipjYii1cXgF+WFroDyiSf0x7cQi/lMOBwcLdn7XIIMziXPPeoeeAziThP3INnD+Gqpy4yNHxpsDGBHMut65LKm3GN4A= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=vrany.io header.i=@vrany.io header.a=rsa-sha256 header.s=protonmail header.b=KHVa2MVj DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 037B84BA2E3E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrany.io; s=protonmail; t=1791193929; x=1791453129; bh=3mK2cvnN5sB3U0hBt5bkL53u/F67s8BAqHtOOHQvt7o=; h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=KHVa2MVjOsbagzPJSoWv9JDuy9EbV+KlfJJpgBnrbbhAw8rTJW0NoDr3WlHrdNcOx 8JIKNyzOwz8nbxSgA02xUP79W6nakkr+hT4ReupCTKbIWgKBqhYqSO/XnbLozgWJCu m6vUCy00PnKJHotY4UfrFIwmG4z4czjL1oqLySvnKtam9WAioB6eChI0bvZxXvBvOQ XcnWyWDxiq0jyka6s9XMzbvfUm7xvXi9JOKGg4Yn0ZLPkbaaqHcTGxcCq7T8mDptQh XQvVxdaChGUwbn3dcIjKkcnnUL7cQJ8JyOYv2edhcdgrjt8t84t9L/gErePQId6bxw ffgWJiFJjQL4A== Date: Mon, 05 Oct 2026 09:52:05 +0000 To: gdb-patches@sourceware.org From: Jan Vrany Cc: Jan Vrany Subject: [PATCH] gdb/testsuite: use with_timeout_factor in 2 more tests Message-ID: <20261005095158.1186551-1-jan@vrany.io> Feedback-ID: 40767693:user:proton X-Pm-Message-ID: a173205f9f18e5a20c57751108d6896325b28042 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org When running tests on some really slow targets, I got timeout in gdb.base/funcargs.exp and gdb.base/completion.exp. The usual remedy I use is to set timeout to higher value in site.exp. However this does not help in case of aforementioned tests because they set timeout to fixed value, regardless of whether the timeout has been increased or not, causing them to fail on some of my machines. This commit fixes the problem by using with_timeout_factor. Since with_timeout_factor wraps large chunks of code, I decided not to reformat (indent) it to make the patch easier to read and to avoid "noise" when git-blaming. --- gdb/testsuite/gdb.base/completion.exp | 6 +++++- gdb/testsuite/gdb.base/funcargs.exp | 11 +++++++---- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/gdb/testsuite/gdb.base/completion.exp b/gdb/testsuite/gdb.base= /completion.exp index 44cf649d5b6..f145f084999 100644 --- a/gdb/testsuite/gdb.base/completion.exp +++ b/gdb/testsuite/gdb.base/completion.exp @@ -61,7 +61,8 @@ if {![runto_main]} { return } =20 -set timeout 30 +with_timeout_factor 3 { + gdb_test_no_output "set max-completions unlimited" =20 gdb_test_no_output "complete print values\[0\].x." \ @@ -995,3 +996,6 @@ foreach_with_prefix spc { " " "" } { =09 } } } + +# end of with_timeout_factor +} diff --git a/gdb/testsuite/gdb.base/funcargs.exp b/gdb/testsuite/gdb.base/f= uncargs.exp index fdfdf07b78c..dd3240ba5e0 100644 --- a/gdb/testsuite/gdb.base/funcargs.exp +++ b/gdb/testsuite/gdb.base/funcargs.exp @@ -1031,13 +1031,15 @@ proc_with_prefix stepping_over_trampolines { } { } } =20 -set prev_timeout $timeout + if {[istarget "mips*tx39-*"]} { - set timeout 300 + set timeout_factor 30 } else { - set timeout 60 + set timeout_factor 6 } =20 +with_timeout_factor $timeout_factor { + # Determine expected output for unsigned long variables, # the output varies with sizeof (unsigned long). =20 @@ -1104,4 +1106,5 @@ call_after_alloca localvars_in_indirect_call stepping_over_trampolines =20 -set timeout $prev_timeout +# end of with_timeout_factor +} --=20 2.53.0