From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qbEDIBU1w2ouWDoAWB0awg (envelope-from ) for ; Mon, 05 Oct 2026 01:26:45 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=V/T8P8JO; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7E3451E047; Mon, 05 Oct 2026 01:26:45 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DCAB11E047 for ; Mon, 05 Oct 2026 01:26:44 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 24D284BA23FF for ; Mon, 5 Oct 2026 05:26:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 24D284BA23FF Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=V/T8P8JO Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 2A8E64BA23CE for ; Mon, 5 Oct 2026 05:26:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2A8E64BA23CE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2A8E64BA23CE Authentication-Results: sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791177974; cv=none; b=jd77Y0MSE6X9BDgKNiz48+JunkUpwqGo1vs6BsnQITKlQnQY0XmNhG/Ow38OqZgmaxErNFxGwL4LNcqpOxZRafgLoJpiCWxjWJyHvy1eWLImVAvg/zFQV33XMlpr8m+IhZXLa8brSjz5wrpjPIi3+BeCE1N45fe4Saa6OJj7Gmg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791177974; c=relaxed/simple; bh=iUbioFQ5aRa4WY36BsgwiaIgXKKkOdGME9dmyLr2Irk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=CEJX9g6iCb2Bw0h3ucF4UYFpmAFe4zt1/OPXEgXYRV27GwaFV0NO20xlWO79S4iZ11fv4bZeeTrIH1MeoFZd0yyl+Mi7JYDY9eDlK3VF/DYaT0BMSCkHXFJ1zhF11rp4TXLL1QyyXmuSKY+Skl3wsTQcuKa38tLVywi3PtwDEgo= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=V/T8P8JO DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2A8E64BA23CE Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 6955Q5Kd046781 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 5 Oct 2026 01:26:10 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 6955Q5Kd046781 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1791177971; bh=QSfz1G3gzb7t4OVkqWz4Khhm57PdC3kdAETOyS7ynkg=; h=From:To:Cc:Subject:Date:From; b=V/T8P8JOQqCiAPZoGaY84k7awI0BamOqpXbktpW7SkNAvdhhP3bEUzLDYnRJYDXSv CDxcKz4a0JgFNzCK2NsPkZGZoGznr2nKKpNGltinab5RYQ8TvYqg27ttjuDtK8Td96 muQHOFzWHF0HJ0wxiicVS0Oo1dVY+JRN4dFh8BjWKgbvACXrfT0JTrsvt+cP3cCikT KGZNd7koogkzzd90PUhwgIiD4+sWHt143vIXh1NQ9Pistg0PnF5NtoiizDm3tME20Z ba7+Cdf9xyIha/jdDFEOYrMiNbvYv2PPx574hgb8/n8g33V3TiEfjDIZ4JY6Q5rkby Y+Lb4Yywa+eSQ== Received: by simark.ca (Postfix) id 483301E047; Mon, 05 Oct 2026 01:26:05 -0400 (EDT) From: simon.marchi@polymtl.ca To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 1/3] gdb/testsuite: fix rust compiler selection in gdb_default_target_compile Date: Mon, 5 Oct 2026 01:25:47 -0400 Message-ID: <20261005052602.1288766-1-simon.marchi@polymtl.ca> X-Mailer: git-send-email 2.55.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 5 Oct 2026 05:26:05 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org From: Simon Marchi The "set compiler" line looks like a copy-paste error from the if just above. If we compare this to the Go handler, then it seems clear that the intent was to write: if {[board_info $dest exists rustcompiler]} { set compiler [target_info rustcompiler] } else { set compiler [find_rustc] } The name rustcompiler follows the convention used by other languages (e.g. "gocompiler", "dcompiler", etc). This also matches what was sent upstream to DejaGnu in commit c8beff4a0843 ("Add Rust support to default_target_compile"). Change-Id: Ic21b397ff6a2afbcda72901203ff7834c752ff3f --- gdb/testsuite/lib/future.exp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/lib/future.exp b/gdb/testsuite/lib/future.exp index 44fc17b3f004..a5444df66c87 100644 --- a/gdb/testsuite/lib/future.exp +++ b/gdb/testsuite/lib/future.exp @@ -308,8 +308,8 @@ proc gdb_default_target_compile_1 {source destfile type options} { if {[board_info $dest exists rustflags]} { append add_flags " [target_info rustflags]" } - if {[board_info $dest exists rustflags]} { - set compiler [target_info rustflags] + if {[board_info $dest exists rustcompiler]} { + set compiler [target_info rustcompiler] } else { set compiler [find_rustc] } base-commit: 2ce6c3190773eb22f467446c4fdc7edb123ce82f -- 2.55.0