From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Sc9/BHM2vmrkLCMAWB0awg (envelope-from ) for ; Thu, 01 Oct 2026 06:31:15 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=E2roEsXW; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0CA5C1E051; Thu, 01 Oct 2026 06:31:15 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 19AD31E033 for ; Thu, 01 Oct 2026 06:31:14 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A85D84BB58F1 for ; Thu, 1 Oct 2026 10:31:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A85D84BB58F1 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=E2roEsXW Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by sourceware.org (Postfix) with ESMTPS id 0F9424BB5910 for ; Thu, 1 Oct 2026 10:29:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0F9424BB5910 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0F9424BB5910 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=192.198.163.14 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790850548; cv=none; b=CTrax4InCBNltaC5rqVImY3pGn+9s4fcEO+tT/xNuWm+9I6CF0n1jzHSQCt1pElG925B0w4h5vJbinUG8Rnuvh2QQ9y7McKCKI+qbwvdjwCFGKy6dP8oukH2JKY5YgSH4ODHguhdrJ4qnw49oVFUC1De/Xjbi+fBAtMtGJkzxkU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790850548; c=relaxed/simple; bh=ZSBFvk2sse9o1duiThXkp6vOCLxGEQ63U7M3WcRZgkA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=AContBGuLO6Utf8PQk/oqIUjT2xwOj/M5SBmgeFsLgEKLpHglUxpMXJibRbuuibitPpM1dHrKqOWo5MDAixsntkWp3vOL3yE+q8LTH5cKnLQtTrJ7GDvee0rFv2MaejP8x/7wSmTqbv/FmUzLCeqewKqXiVmJeM9y+/EmdtNq1o= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=E2roEsXW DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0F9424BB5910 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1790850548; x=1822386548; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=ZSBFvk2sse9o1duiThXkp6vOCLxGEQ63U7M3WcRZgkA=; b=E2roEsXWj+CDKJWJzHZXnsvsQ8eECi/Vc6nOG8eXwG932Sd+lKVVDY1v UG2j0rA/nsQMw6Sxq+Kf9vQGEly4TAkvBgLVRu1phPANbxXb8EMmUw4nQ Mxlk2FjzxEauxjWnt3fiUaT6a3Z3NKvje1XHjo1ddnRMHouEPnNMn9gq7 SVWOjUjo9ViImrk5jZTgdBSGzBMj9bUM2lQGD+ZnSgUgcA/TRZCyNa+EN CqbDz+G5kv8jG1k0yHK69sYtg9m2uzlD/zx5/y+U7KIuVBTg+mqDoJkWx 26JAkftL3IRP1NgV/rXNjRLwtM93WtDUX/uJqjeRmOB0vJ7NpdlEPJAgb Q==; X-CSE-ConnectionGUID: UN1dklvnRHG4rIbZpWw/nQ== X-CSE-MsgGUID: wUEl2dKdSTuLR8QAta2gKQ== X-IronPort-AV: E=McAfee;i="6800,10657,11921"; a="91619627" X-IronPort-AV: E=Sophos;i="6.27,134,1787036400"; d="scan'208";a="91619627" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2026 03:29:02 -0700 X-CSE-ConnectionGUID: dvJpUiULTx67j2jCB+Qv4Q== X-CSE-MsgGUID: bkcak2vHS+K7gix/JMy9lg== X-ExtLoop1: 1 Received: from gkldtt-dev-004.igk.intel.com (HELO localhost) ([10.123.221.202]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2026 03:29:00 -0700 From: Markus Metzger To: gdb-patches@sourceware.org Subject: [RFC PATCH 4/8] gdb, thread: simplify print_selected_thread_frame() Date: Thu, 1 Oct 2026 12:28:43 +0200 Message-ID: <20261001102847.576880-5-markus.t.metzger@intel.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261001102847.576880-1-markus.t.metzger@intel.com> References: <20261001102847.576880-1-markus.t.metzger@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Handle selections one by one in separate blocks. This fixes an issue with forgetting a newline at the end of the output if USER_SELECTED_THREAD is specified, USER_SELECTED_FRAME is not specified, and the thread is not running. Since the function is never called with just USER_SELECTED_THREAD, this does not occur in practice. This will change with a subsequent commit. --- gdb/thread.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/gdb/thread.c b/gdb/thread.c index 0f86f6efe38..bbcd3e61cd1 100644 --- a/gdb/thread.c +++ b/gdb/thread.c @@ -2141,19 +2141,16 @@ print_selected_thread_frame (struct ui_out *uiout, uiout->text (target_pid_to_str (inferior_ptid)); uiout->text (")]"); } - } - if (tp->state () == THREAD_RUNNING) - { - if (selection & USER_SELECTED_THREAD) - uiout->text ("(running)\n"); + if (tp->state () == THREAD_RUNNING) + uiout->text ("(running)"); + + uiout->text ("\n"); } - else if (selection & USER_SELECTED_FRAME) - { - if (selection & USER_SELECTED_THREAD) - uiout->text ("\n"); - if (has_stack_frames ()) + if (selection & USER_SELECTED_FRAME) + { + if ((tp->state () != THREAD_RUNNING) && has_stack_frames ()) print_stack_frame_to_uiout (uiout, get_selected_frame (), 1, SRC_AND_LOC, 1); } -- 2.53.0 ________________________________________ Intel Deutschland GmbH Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany Tel: +49 (89) 99143-0 www.intel.de Managing Directors: Candice Moore, Jeffrey Schneiderman, Ramachandran Sitaraman Chairperson of the Supervisory Board: Sonja Pierer Registered Seat: Munich Commercial Register B: Amtsgericht Munich HRB 186928 This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.