From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GXJaIDjYvGonlB0AWB0awg (envelope-from ) for ; Wed, 30 Sep 2026 05:36:56 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=vrany.io header.i=@vrany.io header.a=rsa-sha256 header.s=protonmail header.b=0hfckt0P; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 71BD51E033; Wed, 30 Sep 2026 05:36:56 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 043B51E033 for ; Wed, 30 Sep 2026 05:36:54 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2ECD64BB3B94 for ; Wed, 30 Sep 2026 09:36:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2ECD64BB3B94 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=vrany.io header.i=@vrany.io header.a=rsa-sha256 header.s=protonmail header.b=0hfckt0P Received: from mail-10626.protonmail.ch (mail-10626.protonmail.ch [79.135.106.26]) by sourceware.org (Postfix) with ESMTPS id 9FE0B4BB1C2A for ; Wed, 30 Sep 2026 09:36:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9FE0B4BB1C2A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=vrany.io Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vrany.io ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9FE0B4BB1C2A Authentication-Results: sourceware.org; arc=none smtp.remote-ip=79.135.106.26 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790760983; cv=none; b=mX2MDDkRoOgJaZ46UBfM62PYbTuNgCkKB1yTZyQQq9CSyh/V3EYXcg/VL7aG8T04NGXbw/489k4Gwvu4QJpuVzINpMQIxXGPUpwSsLLth3GNrXuULpRXIUqDsK66No34s9E3e0Ogtki9h6XnkyK27fpNAnTxNkgoeCroBAwHYb8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790760983; c=relaxed/simple; bh=cT7YBuTnOfnQHZZNG8NuQqw5HkCRMJ1tED1dNgpcXpM=; h=DKIM-Signature:Date:To:From:Subject:Message-ID:MIME-Version; b=Q24t5sBjMYoCJFL9m9lFk3pNxjhmpSoj+FV0DNmipI9Xij2vvk40xLoJ/6YWvsoOnafGQB1cSm3uUN17U73k1Mrom9HP+mjP2bns+fkFxgYnB4COHmroHQ3Ll72XHycSjho+Dhv3oaJkFsj+MMRdjdmjwczA78kmVI2SOKsiQ6w= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=vrany.io header.i=@vrany.io header.a=rsa-sha256 header.s=protonmail header.b=0hfckt0P DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9FE0B4BB1C2A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrany.io; s=protonmail; t=1790760973; x=1791020173; bh=rEiFtJHNvzbOGUM5UExpp+knBptAsQ62hT79pTgLJeY=; h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=0hfckt0P7TmO/h6xsdNGEyBNaCZ/RI7bWglH054WvQCrHuCE9OblvwTEPB3rFwuGM 4VXbA7QRCenfFAOVVs6tH0DCECVFjM5I4Aty7wU/kjDR4wLvxezwMdmfVioSxm+pGb IDdH8IxYbb1iTlL4VozppMLX4dVX6rT+YoZkYsdTKDcVO8BNIMKtnXAga215VpKUMm mRC+pSOnaMRMEtygwzdGtWQizhHF0o4imlv1y02NUX+qRIh89N53Hns+bAjivdo1X0 vNJ99/S6XeoWimbuIGSe3T8w6Ish8HgwJfSF+kBzIdHVB8xJDtCsqsqPCaXZlf02n+ QUq70LLoAOORA== Date: Wed, 30 Sep 2026 09:36:09 +0000 To: gdb-patches@sourceware.org From: Jan Vrany Cc: Jan Vrany Subject: [PATCH] gdb/python: prevent conversion from pointer to bool in to_python() Message-ID: <20260930093550.1288712-1-jan@vrany.io> Feedback-ID: 40767693:user:proton X-Pm-Message-ID: a22aa7deec5b5691ecf5bd8fc82951cf24c37d6b MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org While converting some Python code to use new "safety" APIs I realized that calling to_python() with a pointer like (for example): to_python (symtab->compunit ().objfile ()) calls to_python(bool) which is unlikely to be what the user wants. This commit changes the code to make it a compile-time error. After trying several approaches, the least intrusive seemed to be handling bool specially in to_python() template for integral types and removing to_python(bool) altogether. This way, the above example fails with: error: no matching function for call to =E2=80=98to_python(objfile*)= =E2=80=99 Tested on x86_64-linux. --- gdb/python/py-safety.h | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/gdb/python/py-safety.h b/gdb/python/py-safety.h index 3294f38c8b6..9414951b9ba 100644 --- a/gdb/python/py-safety.h +++ b/gdb/python/py-safety.h @@ -71,17 +71,13 @@ namespace safety_details used in gdb, these are all Python-facing and will return NULL on error. */ =20 -static inline PyObject * -to_python (bool value) -{ - return PyBool_FromLong (value); -} - template>> static inline PyObject * to_python (T value) { - if constexpr (std::is_signed::value) + if constexpr (std::is_same::value) + return PyBool_FromLong (value); + else if constexpr (std::is_signed::value) return gdb_py_object_from_longest (value).release (); else return gdb_py_object_from_ulongest (value).release (); --=20 2.53.0